* riscv fenv.h header file guard typo
@ 2019-07-31 22:47 Joel Sherrill
2019-07-31 23:13 ` Howland, Craig D. - US via newlib
0 siblings, 1 reply; 3+ messages in thread
From: Joel Sherrill @ 2019-07-31 22:47 UTC (permalink / raw)
To: Newlib
Hi
While working on the proposed fenv.h infrastructure support, I noticed that
the riscv fenv.h and sys/fenv.h appear to have very similar header guards
(only a trailing _ differentiates them).
/libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_
Would it be better for sys/fenv.h to have _SYS_FENV_H?
--joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: riscv fenv.h header file guard typo
2019-07-31 22:47 riscv fenv.h header file guard typo Joel Sherrill
@ 2019-07-31 23:13 ` Howland, Craig D. - US via newlib
2019-08-02 3:39 ` Kito Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Howland, Craig D. - US via newlib @ 2019-07-31 23:13 UTC (permalink / raw)
To: Newlib
________________________________________
From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf of Joel Sherrill <joel@rtems.org>
Sent: Wednesday, July 31, 2019 6:47 PM
To: Newlib
Subject: riscv fenv.h header file guard typo
Hi
While working on the proposed fenv.h infrastructure support, I noticed that
the riscv fenv.h and sys/fenv.h appear to have very similar header guards
(only a trailing _ differentiates them).
/libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_
Would it be better for sys/fenv.h to have _SYS_FENV_H?
--joel
Yes, better.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: riscv fenv.h header file guard typo
2019-07-31 23:13 ` Howland, Craig D. - US via newlib
@ 2019-08-02 3:39 ` Kito Cheng
0 siblings, 0 replies; 3+ messages in thread
From: Kito Cheng @ 2019-08-02 3:39 UTC (permalink / raw)
To: Howland, Craig D. - US; +Cc: Newlib
Hi Joel:
Thanks, I've send a patch for that :)
https://www.sourceware.org/ml/newlib/2019/msg00407.html
On Thu, Aug 1, 2019 at 7:13 AM Howland, Craig D. - US via newlib
<newlib@sourceware.org> wrote:
>
>
> ________________________________________
> From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf of Joel Sherrill <joel@rtems.org>
> Sent: Wednesday, July 31, 2019 6:47 PM
> To: Newlib
> Subject: riscv fenv.h header file guard typo
>
> Hi
>
> While working on the proposed fenv.h infrastructure support, I noticed that
> the riscv fenv.h and sys/fenv.h appear to have very similar header guards
> (only a trailing _ differentiates them).
>
> /libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
> ./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_
>
> Would it be better for sys/fenv.h to have _SYS_FENV_H?
>
> --joel
>
> Yes, better.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-02 3:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 22:47 riscv fenv.h header file guard typo Joel Sherrill
2019-07-31 23:13 ` Howland, Craig D. - US via newlib
2019-08-02 3:39 ` Kito Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).