From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com
 [IPv6:2607:f8b0:4864:20::e31])
 by sourceware.org (Postfix) with ESMTPS id 91DF9387089F
 for <newlib@sourceware.org>; Thu,  4 Feb 2021 08:18:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 91DF9387089F
Received: by mail-vs1-xe31.google.com with SMTP id l192so1333041vsd.5
 for <newlib@sourceware.org>; Thu, 04 Feb 2021 00:18:38 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=BMdlqk//okDfy0oNlhd7LmynxEWmg9FYDu2kPpfS3uo=;
 b=Bo9B/v3r5OipEFqybpVbfGvIfOiTaxXd9AB05o5JYdr0oqsORrSSElxsDa2tqXfgrR
 qcDFgkFDF5FtXTs99r2a351CTBNrOoSRpfGsXfH3czUGrYDThcR4IrOEwgga0Jdg5xrS
 x8dXk14JP4uj8v6/Lc1R0YEVH5IYf+SSCXgKuMY2tGyR/86O5YXbhyu/PmbbmO9xf1BS
 cR+3UbfFMcu+E2S/hE1TrWwvfPaFZegXu2JJZyyVKJrf+KpGa9KT10NlY4GuMewZNcs1
 q7yL33fAGLKfuOyO8u+2opnFvyCkPbXj/gCVl8/FTIcl1x74AHfu3IPyORWYr2ePjAML
 i2Ag==
X-Gm-Message-State: AOAM531lms0PnDDWlvvx1TYxk2E2INx1GkO3xECjmJE+SRNeaJA2yMPk
 FOn//i1qYt9CXt5MN/qreH+FtUHP/pWhRDY51w2QWVvxVMs=
X-Google-Smtp-Source: ABdhPJxgK5EvunDTa/QYLxdUoDUs0wZ8kPGPjAgehPcNY22VLh8EdHCaJxYuyhRG7LixRte/zJzjJ5UpgpGNdvZs1is=
X-Received: by 2002:a67:1341:: with SMTP id 62mr4314184vst.49.1612426717988;
 Thu, 04 Feb 2021 00:18:37 -0800 (PST)
MIME-Version: 1.0
References: <20210204073400.14458-1-eddiekuo@andestech.com>
In-Reply-To: <20210204073400.14458-1-eddiekuo@andestech.com>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Thu, 4 Feb 2021 16:18:26 +0800
Message-ID: <CA+yXCZCJETaEedWp0ha1=tG7YFyQ38Q+g+u9WKn_W=DcrfRNxA@mail.gmail.com>
Subject: Re: [PATCH 1/1] RISC-V: Use __bss_start for the starting point of
 .bss.
To: Yeting Kuo <eddiekuo@andestech.com>
Cc: Newlib <newlib@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: newlib@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Newlib mailing list <newlib.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/newlib>,
 <mailto:newlib-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/newlib/>
List-Post: <mailto:newlib@sourceware.org>
List-Help: <mailto:newlib-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/newlib>,
 <mailto:newlib-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2021 08:18:41 -0000

The patch is LGTM, good catch, thanks!

On Thu, Feb 4, 2021 at 3:58 PM Yeting Kuo <eddiekuo@andestech.com> wrote:
>
> From: Yeting Kuo <fakepaper56@gmail.com>
>
> It's more flexible for the positions of .bss and .data.
> ---
>  libgloss/riscv/crt0.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libgloss/riscv/crt0.S b/libgloss/riscv/crt0.S
> index 160c07853..7a4e4e32c 100644
> --- a/libgloss/riscv/crt0.S
> +++ b/libgloss/riscv/crt0.S
> @@ -27,7 +27,7 @@ _start:
>  .option pop
>
>    # Clear the bss segment
> -  la      a0, _edata
> +  la      a0, __bss_start
>    la      a2, _end
>    sub     a2, a2, a0
>    li      a1, 0
> --
> 2.17.0
>