From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106672 invoked by alias); 7 Jun 2017 06:56:00 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 106646 invoked by uid 89); 7 Jun 2017 06:55:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=lg, LG, HTo:U*howland X-HELO: mail-vk0-f42.google.com Received: from mail-vk0-f42.google.com (HELO mail-vk0-f42.google.com) (209.85.213.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 06:55:58 +0000 Received: by mail-vk0-f42.google.com with SMTP id g66so1616561vki.1 for ; Tue, 06 Jun 2017 23:56:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=SbcsSe+domkvxzGR24pH+LT1igYeuRb0gDzgWE/M8vE=; b=k3lsJi1MujnkmyeEGzTIIAed9Eo1xlnWmKYrovrrPhu+DbRHF6Ll4oPH7azwKSr7Z3 X3lCO9QxVbufaBEY23T0HDqAt6TKB/wgk1WMWxY6uVWQo3MtlroCDcSWaoUKd53/nfpC kVUdqB2751HQ5P3avlmNPCZQDPT0V9i4OXtMtqyDN/61NX9p7zUcNIwCwSZabLTPRwXU W9Cfvx3xBPTXRrmZ2JkZRiWzWDW9WToSkVkI735J00Q9d86fPKidMJw/1woJAjv14bjx DpugD06PQeocsNnsjNdQMrmOJbL8G8AAXWCkSwvOZmLLgs83H1/Ev95S4hTYH3clIB1r JdUw== X-Gm-Message-State: AODbwcASRndRuuZ42fViQDKzbQtBp6Gehcan/o/VFE3TDA2Q/P2aI0hF 5BA6XY+yhrnygTAQO934Ijy4R/Xiwg== X-Received: by 10.31.54.140 with SMTP id d134mr2658528vka.15.1496818559460; Tue, 06 Jun 2017 23:55:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.96.137 with HTTP; Tue, 6 Jun 2017 23:55:38 -0700 (PDT) In-Reply-To: <0aab66f6-20a6-10ec-f399-2a39799ab980@LGSInnovations.com> References: <0aab66f6-20a6-10ec-f399-2a39799ab980@LGSInnovations.com> From: Kito Cheng Date: Wed, 07 Jun 2017 06:56:00 -0000 Message-ID: Subject: Re: [PATCH] Print sign of NaN values To: Craig Howland Cc: newlib@sourceware.org Content-Type: multipart/mixed; boundary="001a1143b52287c3220551593a73" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00377.txt.bz2 --001a1143b52287c3220551593a73 Content-Type: text/plain; charset="UTF-8" Content-length: 466 Hi Craig: Thanks your review :) here is updated patch. On Tue, Jun 6, 2017 at 12:45 AM, Craig Howland wrote: > On 06/03/2017 09:54 AM, Kito Cheng wrote: >> >> This patch let -NaN can print the right sign like glibc do[1] :) >> >> Ref: >> [1] >> https://sourceware.org/git/?p=glibc.git;a=commit;h=003c9895a89e71767ad64bafac1ca99622be2eb7 > > For vfwprintf.c, the two assignments to sign ought to be "sign = L'-';" > (missing the L). > --001a1143b52287c3220551593a73 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Print-sign-of-NaN-values.patch" Content-Disposition: attachment; filename="0001-Print-sign-of-NaN-values.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j3mn0pxx0 Content-length: 2066 RnJvbSA5M2E2MTg4NjFlODVhNDA0YTlhZDdlNDkzM2RhYjU2NmE1NWUxZDVm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLaXRvIENoZW5nIDxr aXRvLmNoZW5nQGdtYWlsLmNvbT4KRGF0ZTogU2F0LCAzIEp1biAyMDE3IDIx OjQxOjI5ICswODAwClN1YmplY3Q6IFtQQVRDSF0gUHJpbnQgc2lnbiBvZiBO YU4gdmFsdWVzLgoKLS0tCiBuZXdsaWIvbGliYy9zdGRpby92ZnByaW50Zi5j ICB8IDQgKysrKwogbmV3bGliL2xpYmMvc3RkaW8vdmZ3cHJpbnRmLmMgfCA0 ICsrKysKIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvbmV3bGliL2xpYmMvc3RkaW8vdmZwcmludGYuYyBiL25ld2xp Yi9saWJjL3N0ZGlvL3ZmcHJpbnRmLmMKaW5kZXggZWQ5MmJiMi4uMzU4NTQy MyAxMDA2NDQKLS0tIGEvbmV3bGliL2xpYmMvc3RkaW8vdmZwcmludGYuYwor KysgYi9uZXdsaWIvbGliYy9zdGRpby92ZnByaW50Zi5jCkBAIC0xMjQ1LDYg KzEyNDUsOCBAQCByZXN3aXRjaDoJc3dpdGNoIChjaCkgewogCQkJCWJyZWFr OwogCQkJfQogCQkJaWYgKGlzbmFuIChfZnB2YWx1ZSkpIHsKKwkJCQlpZiAo c2lnbmJpdCAoX2ZwdmFsdWUpKQorCQkJCQlzaWduID0gJy0nOwogCQkJCWlm IChjaCA8PSAnRycpIC8qICdBJywgJ0UnLCAnRicsIG9yICdHJyAqLwogCQkJ CQljcCA9ICJOQU4iOwogCQkJCWVsc2UKQEAgLTEyNzYsNiArMTI3OCw4IEBA IHJlc3dpdGNoOglzd2l0Y2ggKGNoKSB7CiAJCQkJYnJlYWs7CiAJCQl9CiAJ CQlpZiAoZXhwdCA9PSAxKSB7CisJCQkJaWYgKHNpZ25iaXQgKF9mcHZhbHVl KSkKKwkJCQkJc2lnbiA9ICctJzsKIAkJCQlpZiAoY2ggPD0gJ0cnKSAvKiAn QScsICdFJywgJ0YnLCBvciAnRycgKi8KIAkJCQkJY3AgPSAiTkFOIjsKIAkJ CQllbHNlCmRpZmYgLS1naXQgYS9uZXdsaWIvbGliYy9zdGRpby92Zndwcmlu dGYuYyBiL25ld2xpYi9saWJjL3N0ZGlvL3Zmd3ByaW50Zi5jCmluZGV4IGYw MTc5YTAuLjQ3ODZlZDYgMTAwNjQ0Ci0tLSBhL25ld2xpYi9saWJjL3N0ZGlv L3Zmd3ByaW50Zi5jCisrKyBiL25ld2xpYi9saWJjL3N0ZGlvL3Zmd3ByaW50 Zi5jCkBAIC05NzAsNiArOTcwLDggQEAgcmVzd2l0Y2g6CXN3aXRjaCAoY2gp IHsKIAkJCQlicmVhazsKIAkJCX0KIAkJCWlmIChpc25hbiAoX2ZwdmFsdWUp KSB7CisJCQkJaWYgKHNpZ25iaXQgKF9mcHZhbHVlKSkKKwkJCQkJc2lnbiA9 IEwnLSc7CiAJCQkJaWYgKGNoIDw9IEwnRycpIC8qICdBJywgJ0UnLCAnRics IG9yICdHJyAqLwogCQkJCQljcCA9IEwiTkFOIjsKIAkJCQllbHNlCkBAIC0x MDAxLDYgKzEwMDMsOCBAQCByZXN3aXRjaDoJc3dpdGNoIChjaCkgewogCQkJ CWJyZWFrOwogCQkJfQogCQkJaWYgKGV4cHQgPT0gMSkgeworCQkJCWlmIChz aWduYml0IChfZnB2YWx1ZSkpCisJCQkJCXNpZ24gPSBMJy0nOwogCQkJCWlm IChjaCA8PSBMJ0cnKSAvKiAnQScsICdFJywgJ0YnLCBvciAnRycgKi8KIAkJ CQkJY3AgPSBMIk5BTiI7CiAJCQkJZWxzZQotLSAKMi43LjQKCgo= --001a1143b52287c3220551593a73--