From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91476 invoked by alias); 27 Jun 2017 18:10:12 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 91457 invoked by uid 89); 27 Jun 2017 18:10:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=correction, __*_VISIBLE, H*i:sk:fece0fb, __use_* X-HELO: mail-io0-f174.google.com Received: from mail-io0-f174.google.com (HELO mail-io0-f174.google.com) (209.85.223.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 18:10:09 +0000 Received: by mail-io0-f174.google.com with SMTP id r36so22467477ioi.1 for ; Tue, 27 Jun 2017 11:10:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=E628VHfkmMXVyjcsstl/3YjqplymiGr9QkvXOZZdYUA=; b=nyASDXqiZE9m1jZPIe/N+8B8nLE4a6IbM5qo+uZ0pI0GxZTJ1PPGYGEyX8Q4bx63dj uKYKVMb/mt1MDznQ6nu/eIg00yumDY3+6D5cU7QJaR3NjnKEMkHk5DgFPB9dycU/wLfM b1PS5+hhupvxnxvIKTtbf8t5SftdfiUIeOKm5pNzkgfA4RsZcJAkkQIYnX+hlWU/7Czg b5m+4ztiAtim2BhsW9MsrGz7Z0cyQzG3Euzwvzghp7pMYUpreoIrh1ukAQYszy2XZBqw ek3RqR/jl3NvRSVHxMt+cxcrm5fnbAvlUgxl3Snvsk5wzNPlpCEoZMuxnrSx12y3Osvi S4vQ== X-Gm-Message-State: AKS2vOx4pHzXsIjyJwHY+ZuaWkcWa9Tspd6Ng36mcj1G4NHq5cg2pEHp i/zJdeWoOA/5pmA+rZ6KlV15x/cewUoQOVA= X-Received: by 10.107.27.134 with SMTP id b128mr8219683iob.175.1498587007592; Tue, 27 Jun 2017 11:10:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.89 with HTTP; Tue, 27 Jun 2017 11:10:06 -0700 (PDT) In-Reply-To: References: From: "Dionna Amalie Glaze via newlib" Reply-To: Dionna Amalie Glaze Date: Tue, 27 Jun 2017 18:10:00 -0000 Message-ID: Subject: Re: New contributor o/ hello, and small diff. To: Yaakov Selkowitz Cc: newlib@sourceware.org Content-Type: multipart/mixed; boundary="001a113f5d1c4266200552f4fab3" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00487.txt.bz2 --001a113f5d1c4266200552f4fab3 Content-Type: text/plain; charset="UTF-8" Content-length: 655 Thanks for the correction, Yaakov. Is the updated patch acceptable? It pulls in some other symbols too, but the man pages for all those symbols should be supported with __BSD_VISIBLE or __XSI_VISIBLE >= 500. The other edit removes the only trailing whitespace in the file. On Tue, Jun 27, 2017 at 10:43 AM, Yaakov Selkowitz wrote: > On 2017-06-26 14:53, Dionna Amalie Glaze via newlib wrote: >> >> The formatted patch is attached. > > > This patch is incorrect. __USE_* are glibc internals; we use the > __*_VISIBLE internal macros as defined and documented in sys/features.h. > > -- > Yaakov -- -Dionna Glaze, PhD (she/her) --001a113f5d1c4266200552f4fab3 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-gethostname-getdtablesize-mktemp-ualarm-availab.patch" Content-Disposition: attachment; filename="0001-Make-gethostname-getdtablesize-mktemp-ualarm-availab.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4fvzf0b0 Content-length: 2603 RnJvbSAzMzliODU1ZmYxNGFlYzczYmY5NTI3ZjRjYzg0ZjlhNjIwZTJiYmUz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEaW9ubmEgR2xhemUg PGRpb25uYWdsYXplQGdvb2dsZS5jb20+CkRhdGU6IFR1ZSwgMjcgSnVuIDIw MTcgMTE6MDc6NDggLTA3MDAKU3ViamVjdDogW1BBVENIXSBNYWtlIGdldGhv c3RuYW1lLCBnZXRkdGFibGVzaXplLCBta3RlbXAsIHVhbGFybSBhdmFpbGFi bGUgaW4KIEJTRCwgWE9QRU5fU09VUkNFID49IDUwMC4KCi0tLQogbmV3bGli L2xpYmMvaW5jbHVkZS9zeXMvdW5pc3RkLmggfCAxMCArKysrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL25ld2xpYi9saWJjL2luY2x1ZGUvc3lzL3VuaXN0 ZC5oIGIvbmV3bGliL2xpYmMvaW5jbHVkZS9zeXMvdW5pc3RkLmgKaW5kZXgg ODQyMTljYTJlLi5kZWQ2MzIyNzkgMTAwNjQ0Ci0tLSBhL25ld2xpYi9saWJj L2luY2x1ZGUvc3lzL3VuaXN0ZC5oCisrKyBiL25ld2xpYi9saWJjL2luY2x1 ZGUvc3lzL3VuaXN0ZC5oCkBAIC0yMTIsNyArMjEyLDcgQEAgbG9uZyAgICBf RVhGVU4oc3lzY29uZiwgKGludCBfX25hbWUgKSk7CiBwaWRfdCAgIF9FWEZV Tih0Y2dldHBncnAsIChpbnQgX19maWxkZXMgKSk7CiBpbnQgICAgIF9FWEZV Tih0Y3NldHBncnAsIChpbnQgX19maWxkZXMsIHBpZF90IF9fcGdycF9pZCAp KTsKIGNoYXIgKiAgX0VYRlVOKHR0eW5hbWUsIChpbnQgX19maWxkZXMgKSk7 Ci1pbnQgICAgIF9FWEZVTih0dHluYW1lX3IsIChpbnQsIGNoYXIgKiwgc2l6 ZV90KSk7IAoraW50ICAgICBfRVhGVU4odHR5bmFtZV9yLCAoaW50LCBjaGFy ICosIHNpemVfdCkpOwogaW50ICAgICBfRVhGVU4odW5saW5rLCAoY29uc3Qg Y2hhciAqX19wYXRoICkpOwogaW50IAlfRVhGVU4odXNsZWVwLCAodXNlY29u ZHNfdCBfX3VzZWNvbmRzKSk7CiBpbnQgICAgIF9FWEZVTih2aGFuZ3VwLCAo dm9pZCApKTsKQEAgLTI1OSw5ICsyNTksOSBAQCBpbnQgICAgIF9FWEZVTih0 cnVuY2F0ZSwgKGNvbnN0IGNoYXIgKiwgb2ZmX3QgX19sZW5ndGgpKTsKICNl bmRpZgogI2VuZGlmCiAKLSNpZiBkZWZpbmVkKF9fQ1lHV0lOX18pIHx8IGRl ZmluZWQoX19ydGVtc19fKQorI2lmIGRlZmluZWQoX19DWUdXSU5fXykgfHwg ZGVmaW5lZChfX3J0ZW1zX18pIHx8IGRlZmluZWQoX19CU0RfVklTSUJMRSkg fHwgXAorICAgIChfX1hTSV9WSVNJQkxFID49IDUwMCkKIGludAlfRVhGVU4o Z2V0ZHRhYmxlc2l6ZSwgKHZvaWQpKTsKLWludAlfRVhGVU4oc2V0ZHRhYmxl c2l6ZSwgKGludCkpOwogdXNlY29uZHNfdCBfRVhGVU4odWFsYXJtLCAodXNl Y29uZHNfdCBfX3VzZWNvbmRzLCB1c2Vjb25kc190IF9faW50ZXJ2YWwpKTsK ICNpZiAhKGRlZmluZWQgIChfV0lOU09DS19IKSB8fCBkZWZpbmVkIChfV0lO U09DS0FQSV8pIHx8IGRlZmluZWQgKF9fVVNFX1czMl9TT0NLRVRTKSkKIC8q IHdpbnNvY2tbMl0uaCBkZWZpbmVzIGFzIF9fc3RkY2FsbCwgYW5kIHdpdGgg aW50IGFzIDJuZCBhcmcgKi8KQEAgLTI3MCw2ICsyNzAsMTAgQEAgdXNlY29u ZHNfdCBfRVhGVU4odWFsYXJtLCAodXNlY29uZHNfdCBfX3VzZWNvbmRzLCB1 c2Vjb25kc190IF9faW50ZXJ2YWwpKTsKIGNoYXIgKglfRVhGVU4obWt0ZW1w LCAoY2hhciAqKSk7CiAjZW5kaWYKIAorI2lmIGRlZmluZWQoX19DWUdXSU5f XykgfHwgZGVmaW5lZChfX3J0ZW1zX18pCitpbnQJX0VYRlVOKHNldGR0YWJs ZXNpemUsIChpbnQpKTsKKyNlbmRpZgorCiAjaWYgZGVmaW5lZChfX0NZR1dJ Tl9fKSB8fCBkZWZpbmVkKF9fU1BVX18pIHx8IGRlZmluZWQoX19ydGVtc19f KQogdm9pZCAgICBfRVhGVU4oc3luYywgKHZvaWQpKTsKICNlbmRpZgotLSAK Mi4xMy4xLjYxMS5nN2UzYjExYWUxLWdvb2cKCg== --001a113f5d1c4266200552f4fab3--