Re: Long double complex methods

["Dionna Amalie Glaze via newlib" <newlib@sourceware.org>]

Gave it a quick look-over (I'm not a core dev, but figured I'd look
since you seem eager). It looks like everything is indeed from the
current NetBSD codebase.

cacoshl.c has #if 0'd code that probably shouldn't be checked in? The
#if 0 is directly from NetBSD, but still #if 0s aren't nice.

clogl.c why not use cargl(z) for rr? The compiler would inline it, and
arg(z) is closer to the math.

cprojl.c More of a note to others: I was confused why you would use
HUGE_VAL instead of __INFINITY, but apparently that was a conscious
change here http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libm/complex/cprojl.c?rev=1.6&content-type=text/x-cvsweb-markup&only_with_tag=MAIN
from http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libm/complex/cprojl.c?rev=1.5&content-type=text/x-cvsweb-markup&only_with_tag=MAIN

Would you please include additions to libm/test/ for your included
functionality? That probably should be upstreamed to NetBSD too, since
I see they have no tests *gasp*
http://www.mirrorservice.org/pub/NetBSD/NetBSD-current/src/tests/lib/libm/

On Wed, Jun 28, 2017 at 1:34 PM, Aditya Upadhyay <aadit0402@gmail.com> wrote:
> Hello Developers,
>
> I have ported all long double complex methods with suffix "l" from
> NetBSD. I am attaching the patches for all the methods. I am
> requesting you to please review these patches and point me any
> modification needed.
>
> Thanks & Regards,



-- 
-Dionna Glaze, PhD (she/her)