From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25260 invoked by alias); 28 Jun 2017 21:36:28 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 25208 invoked by uid 89); 28 Jun 2017 21:36:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=no version=3.3.2 spammy=her, she, eager X-HELO: mail-io0-f175.google.com Received: from mail-io0-f175.google.com (HELO mail-io0-f175.google.com) (209.85.223.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 21:36:26 +0000 Received: by mail-io0-f175.google.com with SMTP id h134so43525901iof.2 for ; Wed, 28 Jun 2017 14:36:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=20Jp/c94WRreVCku0A1WwPwQR9ITLV16B2jd5uXq4Zo=; b=I/PEZMv3x4EtE0Ov1amMjS98P6Nxe1uZUEfxz1hk0d6hnuLo5KUlcuHVhrXb+o+P9o VlKl5Su6X/GWOV/6HDvJt60981VN4wV/rfkdj1tfq1TybPOO8lBzjGKWVeQjWloI6ale Rb2XcoVh3xXni8X58mO43gWrxH9VmEpOMi7XUguCzze0/wvKt2/B618xURQYDILG1NMF iO+i6J1cxmAFHeXNjLkOLyAI3vTREDIh0MHLJCPOXyjdH1HZZpwjEpne74LjHJ3Vy9tB GIAEO0ir1Yv6rK3/gklbRmQ6rCnxy/5RzvSmzkxINoYKu9NoLHACTUlEMiiUFJ5xDWNL o3nA== X-Gm-Message-State: AKS2vOwl3COmP9rFbBnP2NbfvkT0xtriOR10SnxNFNi+URLGSMP9gZlh xSsN3zYZZ9pCeyAGs/ws0BWhLXUTV3SI X-Received: by 10.107.27.134 with SMTP id b128mr14846586iob.175.1498685784310; Wed, 28 Jun 2017 14:36:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.89 with HTTP; Wed, 28 Jun 2017 14:36:23 -0700 (PDT) In-Reply-To: References: From: "Dionna Amalie Glaze via newlib" Reply-To: Dionna Amalie Glaze Date: Wed, 28 Jun 2017 21:36:00 -0000 Message-ID: Subject: Re: Long double complex methods To: Aditya Upadhyay Cc: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00498.txt.bz2 Gave it a quick look-over (I'm not a core dev, but figured I'd look since you seem eager). It looks like everything is indeed from the current NetBSD codebase. cacoshl.c has #if 0'd code that probably shouldn't be checked in? The #if 0 is directly from NetBSD, but still #if 0s aren't nice. clogl.c why not use cargl(z) for rr? The compiler would inline it, and arg(z) is closer to the math. cprojl.c More of a note to others: I was confused why you would use HUGE_VAL instead of __INFINITY, but apparently that was a conscious change here http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libm/complex/cprojl.c?rev=1.6&content-type=text/x-cvsweb-markup&only_with_tag=MAIN from http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libm/complex/cprojl.c?rev=1.5&content-type=text/x-cvsweb-markup&only_with_tag=MAIN Would you please include additions to libm/test/ for your included functionality? That probably should be upstreamed to NetBSD too, since I see they have no tests *gasp* http://www.mirrorservice.org/pub/NetBSD/NetBSD-current/src/tests/lib/libm/ On Wed, Jun 28, 2017 at 1:34 PM, Aditya Upadhyay wrote: > Hello Developers, > > I have ported all long double complex methods with suffix "l" from > NetBSD. I am attaching the patches for all the methods. I am > requesting you to please review these patches and point me any > modification needed. > > Thanks & Regards, -- -Dionna Glaze, PhD (she/her)