From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by sourceware.org (Postfix) with ESMTPS id 0B3103858D28 for ; Fri, 7 Jan 2022 20:02:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B3103858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb33.google.com with SMTP id y130so19778381ybe.8 for ; Fri, 07 Jan 2022 12:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a2GoS/PDWzU+lTXwj5GdeTBoboqOfIAZs1l72umgIxk=; b=ls1Mhfp4f+6gXnD+U56g3GM+vuhwBj33MDruEJVt6s2+c2cFa70XA8Yjao220wY9YZ 4Q05w8DAvzm4buOxoKqErHZHZATLMrz2A1HSBhnGm4Nvs7uIrO0t//YB0NT8GAnFxzHz 7mTFdAGboc3BylzpIbvbt56mj8J+gQmy0R71DGSMne3rn5eDX+Uha3vzTrFYg+DXD4Ei Nsudj7y8yDqZjYtZvlkPERsll5/6799306K92MTNbNdrJpZhfgyziBNIX5IWb/itFOSz R4HCUy952zt60y5l2FsuDf7aFJkrz3Ullvj+WdLlcLpAWu2SFZM0wWc2mNpiPCep0V6m vceA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a2GoS/PDWzU+lTXwj5GdeTBoboqOfIAZs1l72umgIxk=; b=2ZLnM2Uquq0XpCD+DKUEmNp07R76+1UG7+NEBuJ3eNlYgmVB5ta5n7+1n+4Soz6oyl ag3FsDwHtZ5IFQIGD0xuzyv0koR9cQ3vfN4xqXpDbYQaBSlvJjgCxgLeuXdWO08xO4Nw I9aT2s47iubgauQjXdpw0hxxGjpozLzNjVUe9Y3037k4SB3iarhwKgtcPz5V8mbnOl6O dgY8MH6BSfHHVWN080YSQWlsisf37RE6YZgyC0vrY8sO42JUc7N/N3uyWORmUBkyACQr Euxwo3iQEbOuaMHVjZeNn38H4qQXlkzGJFAebgVXY6fvdYzI8KIlvU5tHTf4KK8Be9Pn QHFA== X-Gm-Message-State: AOAM5336v4nDW23vmSUNm4FJhTGHl1T346L988577JRkZ4YaJcMU+JDL GH1BD2J8MbtCBrYL3YMVv2BnMuGz5seQnZrMFGPOXSIYpoU= X-Google-Smtp-Source: ABdhPJxOZM72+ZfpoDwY1bVWvn4KVSxbGo9xgCf35vET6WK6tzyvXbHwWrmnCZ75W9HWl2JEf8bJZAZ3pygUu+CilB4= X-Received: by 2002:a25:5095:: with SMTP id e143mr74490807ybb.726.1641585746701; Fri, 07 Jan 2022 12:02:26 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Keith Thompson Date: Fri, 7 Jan 2022 12:02:16 -0800 Message-ID: Subject: Re: Error in posix_spawn(3) man page To: newlib@sourceware.org Cc: Keith Thompson Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2022 20:02:30 -0000 On Fri, Jan 7, 2022 at 1:32 AM Corinna Vinschen wrote: > > Hi Keith, > > On Jan 5 13:39, Keith Thompson wrote: > > On Wed, Jan 5, 2022 at 3:47 AM Corinna Vinschen wrote: > > > > > > Hi Keith, > > > > > > On Dec 28 19:24, Keith Thompson wrote: > > > > The posix_spawn(3) man page has incorrect types for the argv and > > > > envp parameters for the posix_spawn and posix_spawnp functions. > > > > > > > > They're shown as > > > > char *const argv, char *const envp > > > > when they should be > > > > char *const argv[], char *const envp[] > > > > > > > > Suggested patch (though I'm not 100% sure how the square brackets > > > > are handled when generating the man page): > > > > > > Please send a git compatible patch in `git format-patch' format. > > > > > > > > > Thanks, > > > Corinna > > > > As requested. Given the way I copy-and-pasted the patch into my email, > > it might not have > > treated tabs correctly. > > It's not TABs, it's an incorrect patch format: > > $ git am 0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch > Applying: Fix documented argv and envp params for posix_spawn > error: libc/posix/posix_spawn.c: does not exist in index > Patch failed at 0001 Fix documented argv and envp params for posix_spawn > hint: Use 'git am --show-current-patch=diff' to see the failed patch > [...] > > Did you actually create the patch with `git format-patch'? > > > Thanks, > Corinna Yes, I did. Apparently `git format-patch` normally adds `a/` and `b/` prefixes to the paths. I don't know why it didn't do so in this case. I'll look into it. Meanwhile, you should be able to apply the patch by changing these lines: --- newlib/libc/posix/posix_spawn.c +++ newlib/libc/posix/posix_spawn.c to this: --- a/newlib/libc/posix/posix_spawn.c +++ b/newlib/libc/posix/posix_spawn.c