From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by sourceware.org (Postfix) with ESMTPS id EE16E3858408 for ; Sat, 8 Jan 2022 00:01:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE16E3858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb29.google.com with SMTP id w184so21148859ybg.5 for ; Fri, 07 Jan 2022 16:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CChNgWiPLjAaPBkI4jrmtaSZDwIYQY4rqlUer75j78M=; b=gd3mn5BDMel1Ml4j+WXs34MNJ1OZSgHgkkBDH4NGfh6E5ih34koszUPPtJi1kAibIm ms32I8x4vLws/XZLDQcaG7PnWKYIIQN0dWAa+SkQN384Jru+C3TRs32Ix4SdEIGFfsSm OzajwvZU/95m+2P24tf2XdKe1fPsVuxT45sf8XXgf6rxCefeVyMy3YqvkqPfNNNvi9ZE TSXsQrDkeBI3xD53D0KdWtz3RZXwY3u3OLxLT8ZV632XDqtzmPBBqbn8hVuWEIFlb38I ladnHloap7UyVK7E4MNX57FIyDDKa8lC2xecgGrWeniJj+ELuJCmfjk+J/PGfEZl+rHj cmrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CChNgWiPLjAaPBkI4jrmtaSZDwIYQY4rqlUer75j78M=; b=R4UfCSkM/0TZuMa1s4k9mxot1uFw15CLhLECwhq/XUx1OrEPzaCLYp0D9kiTK85NiL pNtMnoyAzfViahOHPvK8bfAV/dhAopZBDw1Wc809Kq5LgVF3GtPQYU7rawvesuj1MtK2 wNZ26+nM/SeMrcgKCmV97jK/lyAXiuUUj1Y5AYueCPOdd3L7tUVrM/Oni+19FigdcH+7 ZFOzlY9E5WmMCAuGqTNqmrU8GibXKg7pbn3aYO6vA8sWAZ+sdDrCGYbQlLyE2MPh2TPo bdn7U6Sze+tuFGbwWCJ/ZiwOyUARPoWkT9v3sWaHOZF6AJ78YsOBYiXa5NtBXHwxEiYv b3iA== X-Gm-Message-State: AOAM533yA2Vn/YmfnJDe3ZRNcKeGqZ1ywWlSbv3FRdSzo+w2H4GTLm5O P0kDTMt14IKuTxNumFBGJfof37B096xiYzUo2r+67CJu X-Google-Smtp-Source: ABdhPJxFpEZGHJxyeLN36tiT44JtDvIr9z5KfjLxWBUklL2KEGFFzPFfkat0TTC64ddK5kbvxE7inSrQ6QSksCWuPUQ= X-Received: by 2002:a05:6902:1106:: with SMTP id o6mr7713080ybu.195.1641600088093; Fri, 07 Jan 2022 16:01:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Keith Thompson Date: Fri, 7 Jan 2022 16:01:17 -0800 Message-ID: Subject: Re: Error in posix_spawn(3) man page To: newlib@sourceware.org Cc: Keith Thompson Content-Type: multipart/mixed; boundary="0000000000001d658e05d506ce61" X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jan 2022 00:01:30 -0000 --0000000000001d658e05d506ce61 Content-Type: text/plain; charset="UTF-8" On Fri, Jan 7, 2022 at 1:32 AM Corinna Vinschen wrote: > > Hi Keith, > > On Jan 5 13:39, Keith Thompson wrote: > > On Wed, Jan 5, 2022 at 3:47 AM Corinna Vinschen wrote: > > > > > > Hi Keith, > > > > > > On Dec 28 19:24, Keith Thompson wrote: > > > > The posix_spawn(3) man page has incorrect types for the argv and > > > > envp parameters for the posix_spawn and posix_spawnp functions. > > > > > > > > They're shown as > > > > char *const argv, char *const envp > > > > when they should be > > > > char *const argv[], char *const envp[] > > > > > > > > Suggested patch (though I'm not 100% sure how the square brackets > > > > are handled when generating the man page): > > > > > > Please send a git compatible patch in `git format-patch' format. > > > > > > > > > Thanks, > > > Corinna > > > > As requested. Given the way I copy-and-pasted the patch into my email, > > it might not have > > treated tabs correctly. > > It's not TABs, it's an incorrect patch format: > > $ git am 0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch > Applying: Fix documented argv and envp params for posix_spawn > error: libc/posix/posix_spawn.c: does not exist in index > Patch failed at 0001 Fix documented argv and envp params for posix_spawn > hint: Use 'git am --show-current-patch=diff' to see the failed patch > [...] > > Did you actually create the patch with `git format-patch'? > > > Thanks, > Corinna The problem was that I had diff.noprefix=true in my $HOME/.gitconfig. It caused `git format-patch` to omit the `a/` and `b/` prefixes, and `git am` doesn't appear to have any way to consume a patch with those prefixes missing. I've attached an updated patch that should apply cleanly. (I'd argue that this is a git bug, but of course this isn't the place to report it.) --0000000000001d658e05d506ce61 Content-Type: application/octet-stream; name="0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch" Content-Disposition: attachment; filename="0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ky527gan0 RnJvbSA3ZmRmZThjMjU0OWI1M2VhMzZkNjhiODc5MDIwZTAyMzZkNjQ4MGFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZWl0aCBUaG9tcHNvbiA8S2VpdGguUy5UaG9tcHNvbkBnbWFp bC5jb20+CkRhdGU6IFdlZCwgNSBKYW4gMjAyMiAxMzozMDoxNiAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBkb2N1bWVudGVkIGFyZ3YgYW5kIGVudnAgcGFyYW1zIGZvciBwb3NpeF9zcGF3bgoK LS0tCiBuZXdsaWIvbGliYy9wb3NpeC9wb3NpeF9zcGF3bi5jIHwgNCArKy0tCiAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL25ld2xp Yi9saWJjL3Bvc2l4L3Bvc2l4X3NwYXduLmMgYi9uZXdsaWIvbGliYy9wb3NpeC9wb3NpeF9zcGF3 bi5jCmluZGV4IDAwNTQ3MWZkZS4uODViZmE2NDc3IDEwMDY0NAotLS0gYS9uZXdsaWIvbGliYy9w b3NpeC9wb3NpeF9zcGF3bi5jCisrKyBiL25ld2xpYi9saWJjL3Bvc2l4L3Bvc2l4X3NwYXduLmMK QEAgLTM5LDExICszOSwxMSBAQCBTWU5PUFNJUwogCWludCBwb3NpeF9zcGF3bihwaWRfdCAqPFtw aWRdPiwgY29uc3QgY2hhciAqPFtwYXRoXT4sCiAJCQljb25zdCBwb3NpeF9zcGF3bl9maWxlX2Fj dGlvbnNfdCAqPFtmaWxlX2FjdGlvbnNdPiwKIAkJCWNvbnN0IHBvc2l4X3NwYXduYXR0cl90ICo8 W2F0dHJwXT4sCi0JCQljaGFyICpjb25zdCA8W2FyZ3ZdPiwgY2hhciAqY29uc3QgPFtlbnZwXT4p OworCQkJY2hhciAqY29uc3QgPFthcmd2XT5bXSwgY2hhciAqY29uc3QgPFtlbnZwXT5bXSk7CiAJ aW50IHBvc2l4X3NwYXducChwaWRfdCAqPFtwaWRdPiwgY29uc3QgY2hhciAqPFtmaWxlXT4sCiAJ CQljb25zdCBwb3NpeF9zcGF3bl9maWxlX2FjdGlvbnNfdCAqPFtmaWxlX2FjdGlvbnNdPiwKIAkJ CWNvbnN0IHBvc2l4X3NwYXduYXR0cl90ICo8W2F0dHJwXT4sCi0JCQljaGFyICpjb25zdCA8W2Fy Z3ZdPiwgY2hhciAqY29uc3QgPFtlbnZwXT4pOworCQkJY2hhciAqY29uc3QgPFthcmd2XT5bXSwg Y2hhciAqY29uc3QgPFtlbnZwXT5bXSk7CiAKIERFU0NSSVBUSU9OCiBVc2UgPDxwb3NpeF9zcGF3 bj4+IGFuZCA8PHBvc2l4X3NwYXducD4+IHRvIGNyZWF0ZSBhIG5ldyBjaGlsZCBwcm9jZXNzCi0t IAoyLjMzLjEKCg== --0000000000001d658e05d506ce61--