From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id A42533858D37 for ; Fri, 4 Mar 2022 00:06:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A42533858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x629.google.com with SMTP id a8so14057490ejc.8 for ; Thu, 03 Mar 2022 16:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1mZmjjwzCG6l88hqfeAviwLXlHnDMHa/MoHatVfR4b8=; b=EH2k+BCJYCLUOOx6W9V48ZFgl2hzR3J52v/jdOhnOCB+MD5tP7BQ67FCBtnwrPQqd/ rRLVEql6QsPzHrp5lJS7U11ZYsmF2SteWaiOAEQpT5VKHbz5JVREAI1lIoQlDyFE6IrX jLI5Ow7LnvyJeeb4suoj8E9Qwo9m+TsLhLkBdQwHUoziSynBpWu+nb8AVgHLIlnsPM3O WinKsQMAvKzh/tl+y7506wqBEIU+RctvWc8/gbwAON3CLem6Gxqk7vNMLje0XZ86YbxJ e0KdFIU7eUrK22cTeYFElPgoeuGLXWxbPz/ttoKWyR+uqV5KDrsOhoQbkkp1umVSdy0B 6Dkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1mZmjjwzCG6l88hqfeAviwLXlHnDMHa/MoHatVfR4b8=; b=egsfuhgGfrlYdaUaBQuMOvSKOPyDXpPjlo+pCJahntIXwaigUvlo0raiottx+92vwI 6r5/Bj41tIN7TI7A7RjX/nlFOMbzgZJI2l2FdQ8WVS2kRhfUGCRDl2xy5x1ICqksbtL1 ++LZigPDq4LafzFkKLia/lFygUxHVJnokCFuzqNthFd8zzESX/pEQU7zHQttye9Mea6Y ntOA36wmurgDlzikDV6HEeGoxj/qAHnpdcwXDJt9b3wMB1VlpqMcecqZibNIVb+65JNg RIJ2783f8d04OS0PsVKTy2dtvTG/4WB6AlfQ4l8POQULmnXnQftfg6DJDFux933Yq8Xi viOg== X-Gm-Message-State: AOAM530AR44FnO7GOw5AZvpRogzO8aq12XGGx8q8BDRFtsw02tFbDWKL QJyKPXXLlK9u5iy8Amw8VEhs0GRJw/pXwWLBTw1YpQNXv6Q= X-Google-Smtp-Source: ABdhPJyQf6/mtrPYL+KgYAODUoUffsgW77GTBPkJVPUtDnCX3a242QFerfZh8rJW+fP7nxxUT/m0yJJ7mqWxS1kdyQs= X-Received: by 2002:a17:906:2e90:b0:6d6:e921:934a with SMTP id o16-20020a1709062e9000b006d6e921934amr11827601eji.557.1646352394512; Thu, 03 Mar 2022 16:06:34 -0800 (PST) MIME-Version: 1.0 References: <20220225044501.27831-1-vapier@gentoo.org> In-Reply-To: From: Stafford Horne Date: Fri, 4 Mar 2022 09:06:23 +0900 Message-ID: Subject: Re: [PATCH] libgloss: add a little build system generation documentation To: Tamar Christina Cc: Richard Earnshaw , "newlib@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 00:06:37 -0000 On Thu, Mar 3, 2022 at 8:54 PM Tamar Christina wrote: > > Indeed, it's failing with 6.7 on Ubuntu 20.04. > > The patch didn't seem to help. > > It did put up an additional warning with the patch > > src-newlib/libgloss/doc/porting.texi:314: warning: node `Build System Internals' is next for `Board support' in sectioning but not in menu > src-newlib/libgloss/doc/porting.texi:360: warning: node `Board support' is prev for `Build System Internals' in sectioning but not in menu > src-newlib/libgloss/doc/porting.texi:360: warning: node `Libgloss' is up for `Build System Internals' in sectioning but not in menu > src-newlib/libgloss/doc/porting.texi:87: node `Libgloss' lacks menu item for `Build System Internals' despite being its Up target > make[3]: *** [Makefile:1233: src-newlib/libgloss/doc/porting.info] Error 1 > > first one is new. > > Regards, > Tamar > > > -----Original Message----- > > From: Richard Earnshaw > > Sent: Thursday, March 3, 2022 11:44 AM > > To: Tamar Christina ; newlib@sourceware.org > > Subject: Re: [PATCH] libgloss: add a little build system generation > > documentation > > > > > > > > On 03/03/2022 04:22, Mike Frysinger wrote: > > > On 02 Mar 2022 13:10, Tamar Christina wrote: > > >> This commit seems to break the build: > > >> > > >> make[3]: Entering directory '/newlib/aarch64-none-elf/libgloss' > > >> MAKEINFO /src-newlib/libgloss/doc/porting.info > > >> /src-newlib/libgloss/doc/porting.texi:360: warning: node `Board > > >> support' is prev for `Build System Internals' in sectioning but not > > >> in menu > > >> /src-newlib/libgloss/doc/porting.texi:360: warning: node `Libgloss' > > >> is up for `Build System Internals' in sectioning but not in menu > > >> /src-newlib/libgloss/doc/porting.texi:87: node `Libgloss' lacks menu > > >> item for `Build System Internals' despite being its Up target > > >> make[3]: *** [Makefile:1233: /src-newlib/libgloss/doc/porting.info] > > >> Error 1 > > >> make[3]: Leaving directory '/newlib/aarch64-none-elf/libgloss' > > >> make[2]: *** [Makefile:1439: all-recursive] Error 1 > > > > > > builds fine for me w/texinfo-6.8. what version are you using ? > > > > I think it fails with 6.7, at least that's what I have on my machine, where that's > > the standard version in Ubuntu-20.04. > > > > > > > > current texinfo guidelines is to omit the 2nd+ args for @node. > > > wonder if that would fix the build for you. > > > -mike > > > > > > --- a/libgloss/doc/porting.texi > > > +++ b/libgloss/doc/porting.texi > > > @@ -311,7 +311,7 @@ > > > and uninstalled object tree. It also makes it easier to debug the other > > > tools using libgloss's test suites. > > > > > > -@node Board support, , Building libgloss, Libgloss > > > +@node Board support > > > @section Adding Support for a New Board > > > > > > This section explains how to add support for a new board to libgloss. > > I was getting the same failure, this patch works for me. diff --git a/libgloss/doc/porting.texi b/libgloss/doc/porting.texi index 5325fb2ed..7473c3706 100644 --- a/libgloss/doc/porting.texi +++ b/libgloss/doc/porting.texi @@ -136,6 +136,8 @@ new library is called Libgloss, for Gnu Low-level OS support. * Building libgloss:: How to configure and built libgloss for a target. * Board support:: How to add support for a new board. + +* Build System Internals:: How the libgloss build system works. @end menu @node Supported targets, Building libgloss, Libgloss, Libgloss