From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17555 invoked by alias); 28 Jul 2017 11:40:42 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 16635 invoked by uid 89); 28 Jul 2017 11:40:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=BSD_VISIBLE, bsd_visible, H*f:sk:H_m6tR2, H*i:sk:H_m6tR2 X-HELO: mail-ua0-f177.google.com Received: from mail-ua0-f177.google.com (HELO mail-ua0-f177.google.com) (209.85.217.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jul 2017 11:40:38 +0000 Received: by mail-ua0-f177.google.com with SMTP id 80so161095487uas.0 for ; Fri, 28 Jul 2017 04:40:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=bDWhG7gB8Jq040iZ54/YjEPlGmhzi/g5Ta9akNUeOXA=; b=SBPimCRY6xGr9KqM4RbSzKwEdTOTkifKOgEIIal/Z2boPplmQEC6tyguKyggKE5NE6 cP71iwnuKE3Mz4UOewmAorWBrNby2WafJ7lmsW4BSmDgn8TWQCBNw71MoQJ4t/Sw6Rzq xp5xBAIwDKynVoBM/t4KiHw31hKNXq8FCnexbebFH2WiQW0FT1ohxThHWbz9NSm+Bu0J E0gjZdCSWMafzaUP9Ji1NGool3VJSbEJBP00eERntI+nXi2c+6eB6DPpUKSv7ab5RGZU tksqdbjjHiv0K5/9vNwzD8fXlv9lOr8cSQVRI3n6STBeVcS4jaUiBT3nzVV7pAzgI+E6 ljcQ== X-Gm-Message-State: AIVw113TfkUUT8H4DARqVRSHpYIcRcXQZEEdvDnBB1LfCtvW02N6Lvm3 Ufhw58VcC6rN8kHhmUaF2l4vy26Wozc/dec= X-Received: by 10.31.230.198 with SMTP id d189mr4463704vkh.47.1501242036944; Fri, 28 Jul 2017 04:40:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.59.29 with HTTP; Fri, 28 Jul 2017 04:40:36 -0700 (PDT) In-Reply-To: References: <20170726110849.GG14419@calimero.vinschen.de> <20170727123207.GB27695@calimero.vinschen.de> <20170728104304.GA24013@calimero.vinschen.de> From: Gedare Bloom Date: Fri, 28 Jul 2017 11:40:00 -0000 Message-ID: Subject: Re: Importing inttypes methods To: Aditya Upadhyay Cc: "newlib@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00685.txt.bz2 On Fri, Jul 28, 2017 at 7:02 AM, Aditya Upadhyay wrote: > Just give a little time. I am creating a new patch set that fix the > BSD_VISIBLE problem. > > Thanks, > Aditya > > > On Fri, Jul 28, 2017 at 4:13 PM, Corinna Vinschen wrote: >> On Jul 27 19:30, Aditya Upadhyay wrote: >>> Hi, >>> >>> I apologize for the inconvenience caused. Actually i am new to git and >>> still learning commands. I am trying my best and want to assure you >>> that i will be familiar with the git soon. I will try not to repeat >>> the same mistakes again in future. >>> I am attaching the fresh new patches for last 4 methods with all >>> possible changes. I am requesting you to please review the patches. >> >> Patches are fine and what we talked about, but I realized belatedly >> that we have a problem with the inttypes.h header file: >> >> Your patch includes xlocale.h only if __POSIX_VISIBLE >= 200809. >> However, you declare the _l functions unconditionally. This will >> break builds which don't define _POSIX_SOURCE to the right value. >> >> Additionally, these functions are BSD-only at the moment. They are >> neither in glibc nor in POSIX. >> >> So, what we should do here is this: >> >> * Include xlocale.h only if __BSD_VISIBLE. >> * Declare the _l functions only if __BSD_VISIBLE, too. >> >> It's your choice now: Do you want to recreate the below patches >> accordingly, or shall I aplly the patches as they are, and you create >> a followup patch just fixing inttypes.h? >> Corinna, good catch. I mentioned this issue to Joel but it dropped out the bottom some how. Is it only (for example) the strtoimax_l() that needs to be guarded, or also the _strtoimax_l? (I suspect only the strtoimax_l, but want to be clear before the next round of patches lands here.) Aditya, Please do make the fixes to the VISIBLE, and also separate the commits/patches that (1) add unmodified BSD source files from (2) the commit that modifies the source file and adds it the build system. Send a complete -v3 patch set with these changes. This set should include all of your inttypes.h changes, since you will be changing the first few patches (imaxabs, etc.) to separate the source import from its use accordingly. -Gedare >> >> Thanks, >> Corinna >> >> -- >> Corinna Vinschen >> Cygwin Maintainer >> Red Hat