From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3053 invoked by alias); 1 Aug 2017 12:10:13 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 2994 invoked by uid 89); 1 Aug 2017 12:10:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_20,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=iu, H*f:rYNqJHGB, corinnas, Corinnas X-HELO: mail-vk0-f47.google.com Received: from mail-vk0-f47.google.com (HELO mail-vk0-f47.google.com) (209.85.213.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Aug 2017 12:10:09 +0000 Received: by mail-vk0-f47.google.com with SMTP id u133so5239583vke.3 for ; Tue, 01 Aug 2017 05:10:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=H/+dJHm90dLsG/bYRrWy6l4a7gY8kt99fKD2vA7COyY=; b=U/nWOQGQt0qgq3HN/9CqaBw2iNfVWSSxcH1Bn8/ZXc/K0jF7if4cvjMKkxykl7Dv1Y VUN9PBsfKLfKZSStVj9iZ0+7ATFwn++7NCVv/ZUYvt6vpQRfxIgP8LT14AbmV4kDy0tF U0iccEXU0tbpEvs5878kMo4yb0YTaD9JaL0mq3B1ta2GzYJJXTwWbTYXr6auHSD0uRlZ 7sA1cEAB3kkGUVAdPkQ3Yw07VSPdyXY2uKpLbWFiVlwc1aiHiT1YPCZ0lJ8q+u1htlkm 7RpN7B/H56FyIht8wFI8gM1AXtezReX9Gq4lvDEYT9WMr55mLqVqz0fx3YhPXw9rOfsN h6/g== X-Gm-Message-State: AIVw111FgC623TbWEpwHTBy1DROeJaUbPOokePN2DGkos8/6vrahcOs/ h+GSX4wu+XUfR/4czHgi74Sgy2hdVf9Z X-Received: by 10.31.207.194 with SMTP id f185mr1383732vkg.47.1501589407391; Tue, 01 Aug 2017 05:10:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.59.29 with HTTP; Tue, 1 Aug 2017 05:10:06 -0700 (PDT) In-Reply-To: References: <20170728104304.GA24013@calimero.vinschen.de> <20170728130803.GD24013@calimero.vinschen.de> <20170728182942.GE24013@calimero.vinschen.de> <20170731100835.GL24013@calimero.vinschen.de> From: Gedare Bloom Date: Tue, 01 Aug 2017 12:10:00 -0000 Message-ID: Subject: Re: Importing inttypes methods To: Aditya Upadhyay Cc: "newlib@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00708.txt.bz2 On Tue, Aug 1, 2017 at 4:30 AM, Aditya Upadhyay wrote: > On Mon, Jul 31, 2017 at 3:38 PM, Corinna Vinschen wrote: >> On Jul 30 11:41, Gedare Bloom wrote: >>> All, >>> >>> It looks like to me like the str*_l functions in stdlib.h currently >>> are actually being guarded by __GNU_VISIBLE rather than __BSD_VISIBLE. >>> You should see if these locale functions from BSD are in glibc, if so >>> then I believe GNU_VISIBLE is the more appropriate guard? Someone more >>> knowledgeable on the feature test macros might comment. >> >> Yes, the functions are guarded with __GNU_VISIBLE, just as in glibc. >> No, the {str,wcs}to{i,u}max_l functions are not defined in glibc at all, >> so they should be __BSD_VISIBLE. >> > Do i need to modify the code of *max methods according to strtol > method or is this ok for master ? Aditya, I don't quite understand your question. To rephrase Corinna's answer: You should keep using the __BSD_VISIBLE as you have done, since the new functions you port are not in glibc. You still need to rewrite your code to take into consideration my other comments. Gedare