From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50280 invoked by alias); 21 Jul 2017 15:43:05 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 50218 invoked by uid 89); 21 Jul 2017 15:43:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=encouraged, H*RU:209.85.217.195, Hx-spam-relays-external:209.85.217.195 X-HELO: mail-ua0-f195.google.com Received: from mail-ua0-f195.google.com (HELO mail-ua0-f195.google.com) (209.85.217.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jul 2017 15:43:02 +0000 Received: by mail-ua0-f195.google.com with SMTP id 80so5505694uas.4 for ; Fri, 21 Jul 2017 08:43:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=dE6Zqi58gVBNOTc/+PD5bj6N+1xlk1iC1fflE2NwgpI=; b=g+lRumhr7g7NYDk/OllRd1zI0cE5Pzw2j45n05a/BJ5CPwthIEVF+ag6Z/sBYSIcEp qnY2WA2AvxW/q0r16YoY+GE6jafx79NyvJTjXEYT24dODzMyRvt8qARtuNUcX4glld2B R8BXJ4UVGdhYqHehzMfvsu/lGVGbsAgvFRQgw73Tw3j8BXPypS8Ro6HzPvSRiKEAzyaB OHyHg6kZ2FtSyzbypqtva2nshUNZczrdro7KZOm7CoK7A86HaxP55vQgcZEuzS1sUHkN aXZj+BY40uFVmaRM3DybiODbaI+wGsPUzbMkMQW9yxq/LJw23kQSeyDBOOt3qK26DvHl wFww== X-Gm-Message-State: AIVw113B4f0xN4I8R120RSwiuqY4wItWZYCBF277z6XKgMv19dNkw5J3 SKZovpN2pmCZo4D1xwXQweeSpTJ7aZ2o+Rs= X-Received: by 10.176.75.74 with SMTP id i10mr5156710uaf.19.1500651780309; Fri, 21 Jul 2017 08:43:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.60.145 with HTTP; Fri, 21 Jul 2017 08:42:59 -0700 (PDT) In-Reply-To: <20170720143742.GA20229@calimero.vinschen.de> References: <20170719122806.GA6325@calimero.vinschen.de> <20170719154430.GB6325@calimero.vinschen.de> <20170720143742.GA20229@calimero.vinschen.de> From: Gedare Bloom Date: Fri, 21 Jul 2017 15:43:00 -0000 Message-ID: Subject: Re: Importing inttypes methods from FreeBSD To: "newlib@sourceware.org" , Joel Sherrill Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00615.txt.bz2 On Thu, Jul 20, 2017 at 10:37 AM, Corinna Vinschen wrote: > Aditya, > > On Jul 20 13:54, Aditya Upadhyay wrote: >> Hello All, >> >> This is the modified patches for inttypes methods. Now I want to make >> testsuite for these methods in newlib, but i have no idea how to make >> test in newlib. Can anyone please help me for the same or point me >> some link. Please review the patch. > > Sorry to say that, but this is unusable. I can't apply the below > patches because they are missing the original patches. On the other > hand you're using the original subjects, as if the below patches are the > entire thing. They aren't. The below patches are only relative > patches to the ones you orignally sent, but which, of course, haven't > been applied yet. > > Please, make yourself familiar with `git rebase -i'. Go back to the > original patches actually adding the files imaxabs.c, etc., and squash > the below patches into the original patches. Then send the resulting, > *complete* patches as a patchset. Every addition like imaxabs.c should > be a single patch in the patchset. > >> diff --git a/newlib/libc/stdlib/Makefile.am b/newlib/libc/stdlib/Makefile.am >> index 6cca5f005..d97b0250c 100644 >> --- a/newlib/libc/stdlib/Makefile.am >> +++ b/newlib/libc/stdlib/Makefile.am >> @@ -34,7 +34,6 @@ GENERAL_SOURCES = \ >> getenv_r.c \ >> itoa.c \ >> imaxabs.c \ >> - imaxdiv.c \ >> labs.c \ >> ldiv.c \ >> ldtoa.c \ >> @@ -59,7 +58,6 @@ GENERAL_SOURCES = \ >> sb_charsets.c \ >> strtod.c \ >> strtodg.c \ >> - strtoimax.c \ >> strtol.c \ >> strtorx.c \ >> strtoul.c \ >> @@ -70,8 +68,8 @@ GENERAL_SOURCES = \ >> wcstombs.c \ >> wcstombs_r.c \ >> wctomb.c \ >> - wctomb_r.c >> - >> + wctomb_r.c \ >> + > > ^^^^^^^^^^^^ > ...and don't add gratuitious white spaces, please. > > Joel, please take an interest in Aditya's work in the first place. > *You* were the one who gave these tasks to Aditya, so *you* should be > the one guiding him and reviewing these patches, not me. > For any followup patches, I will not look into them unless you gave > your OK first. > Thank you for the helpful feedback, which is important to help new developers to understand how to work with an open source project. It usually takes Joel or myself a few days to a week to review patches. I understand completely if you would like to ignore the patches from our Google Summer of Code student since he is still learning and will inevitably make some mistakes. He started out with private emails, but I encouraged him to post to this mailing list in order to increase his visibility and learn how to better communicate with the community here. Meanwhile, he has sent me a new set of patches in private that look good. I hope he will feel comfortable to send them to the mailing list soon. Gedare > > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat