From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91470 invoked by alias); 2 Aug 2017 13:56:42 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 51433 invoked by uid 89); 2 Aug 2017 13:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=neglected, Best X-HELO: mail-vk0-f65.google.com Received: from mail-vk0-f65.google.com (HELO mail-vk0-f65.google.com) (209.85.213.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Aug 2017 13:55:54 +0000 Received: by mail-vk0-f65.google.com with SMTP id z187so2214193vkd.3 for ; Wed, 02 Aug 2017 06:55:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=sZvz0wSsqKLqFZT2gcTSnrBeyoIH4XG4thIqmGH8tmM=; b=WLQpmfslb91LsDlBIOANeISxwtet6Oy6IuW9BbEJNBQMQLQQTJlnzIeY0CocyERf0x SgMZscCho9Z2mpYxYZJU3eD8y4hH1WYPfMClr+twRwMhCWXeO7mI0e3krpeIytPRf8ow IO9R6zfO4aiBh3hISyfF7pVhLxlrOPxOgzblWltiPHhFfbybsj5dSQgvLy2fhuRrL0Mj U/Wk2eOKJqvJYjz1S1VSZ8S9EoeAacIOmeef5yxjBoCH3DlQzwHqo5BaPX6Utjq4MjJC WPGKC7EKEU3tflIddsVFBz545XjoET0GKwp2cz193FsqXzPhZiDVCmsTUOyAWiuJqwn0 EHKQ== X-Gm-Message-State: AIVw112kCOUqaawixK+mB3ytEfqGE6wPG60uERNTBfDj0hbVvp5GQVbT TP8C00vAAyIVTTuXOar2IOYxJENjjNdm X-Received: by 10.31.205.2 with SMTP id d2mr11980238vkg.77.1501682152399; Wed, 02 Aug 2017 06:55:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.59.29 with HTTP; Wed, 2 Aug 2017 06:55:51 -0700 (PDT) In-Reply-To: <20170802110435.GH25551@calimero.vinschen.de> References: <1501643979-32662-1-git-send-email-aadit0402@gmail.com> <20170802110435.GH25551@calimero.vinschen.de> From: Gedare Bloom Date: Wed, 02 Aug 2017 13:56:00 -0000 Message-ID: Subject: Re: [PATCH 1/4] Importing strtoimax inttypes method from FreeBSD. To: "newlib@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00717.txt.bz2 On Wed, Aug 2, 2017 at 7:04 AM, Corinna Vinschen wrote: > On Aug 2 08:49, Aditya Upadhyay wrote: >> --- >> newlib/libc/include/inttypes.h | 12 +++ >> newlib/libc/stdlib/Makefile.am | 1 + >> newlib/libc/stdlib/strtoimax.c | 167 +++++++++++++++++++++++++++++++++++++++++ > > All 4 patches applied. > > I made a few minor formatting changes in terms of whitespaces and > missing empty lines between functions. Please compare what I commited > with your local patch to see the differences. > Thanks. There were no empty lines between functions in the original BSD source. However, since the original source was not submitted separately from the modification to make it useful, this is hard to see. Best to leave it as you have pushed it I suppose. Aditya, if there are more patches in the future please first provide a commit with the unmodified BSD file, and then a second commit to modify the file and to add it to the build system. I neglected to follow-up on this procedure with you, but it is a good way to ensure tight synchronization with upstream sources. -Gedare > > Thanks, > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat