From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 18B143858D28 for ; Tue, 30 Nov 2021 17:12:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18B143858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638292355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GmmEdA0hYV3UQjPChK65133CekLZwOIJmH0X2cvHsFU=; b=iWK+sar5Xv47JiunbZf/o75hFeHSnwdl1TpBkufv2u33XTCZ9NUgFwVlXB8EHCldpiNoCN 9c35gxdmQd0oC6VixBpk5AVuyxuUy7elbrHOqSa47jKFfiNYUwXe6WPHyFVGuUSh6SZ6Um qc16CIpuuGTTws+3a7+TxX6mZg5dcd8= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-348-tv7-32XSPzeLPktg1R7QzQ-1; Tue, 30 Nov 2021 12:12:32 -0500 X-MC-Unique: tv7-32XSPzeLPktg1R7QzQ-1 Received: by mail-yb1-f199.google.com with SMTP id v20-20020a25fc14000000b005c2109e5ad1so30153175ybd.9 for ; Tue, 30 Nov 2021 09:12:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=GmmEdA0hYV3UQjPChK65133CekLZwOIJmH0X2cvHsFU=; b=I4S2AbtS90J0ceyyMfPpCa3czGc0QtvH7XQkVOlgz8RBslb0rteDKKiLXqFfZTuqe3 ppLjpZEQ2joiOmQHQgbVDRKmdgNMgAScVABOK3WCZ33ZPs+8uCfYy/qWecsCsMBL8gp3 4ELzYMXpL7bGS8Za9POF2DP2B+/Yud48pZlvtYJ8OuaRZ1elOPPUhypuiCOYuJQjhFsq tYwAUiFIcHWgAM2SngX8WASRZpRpytmVDaCp7RRwB+KCqB1tQe1XfZdcuHw4fnJwC0eg pJsJHp6LJbf2UIRQU5Wpj6CQQe5LJAkGR95c1CkPkxxWWZDbLwtbQnGcL4t8rudYlGCM pyXg== X-Gm-Message-State: AOAM531/DgTlFjwP8wTpIn5JftsNX3snnYWWqjdi+le5rEF3mrZRQ3Pj ZiiUrej9kaf4cfyvMcioo1tX/jau8eGPUy86AI9qfCGicWaB4wyULcrmOJz+ZWlj0CYIf1UBS5B hPBUKTdzb8zPVDZnc1Wm1WPpHD3JTA34= X-Received: by 2002:a05:6902:1009:: with SMTP id w9mr461967ybt.120.1638292352021; Tue, 30 Nov 2021 09:12:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJx/z/xGc2BLx5zE1Solp94I1NKxqhpi1GugJiqoKdOQMW8fHCoAhJKwJCksqyWmoqdd5LqN0TkMwVd4y2OBjW0= X-Received: by 2002:a05:6902:1009:: with SMTP id w9mr461942ybt.120.1638292351813; Tue, 30 Nov 2021 09:12:31 -0800 (PST) MIME-Version: 1.0 References: <20211109012447.30698-1-vapier@gentoo.org> <20211109012459.30826-1-vapier@gentoo.org> <43a8b21c-ac4e-fd33-d7ad-ae7738329d16@foss.arm.com> In-Reply-To: From: Jonathan Wakely Date: Tue, 30 Nov 2021 17:12:20 +0000 Message-ID: Subject: Re: [PATCH 2/2] ctype: use less short names in public header To: newlib@sourceware.org, Jonathan Wakely , Mike Frysinger , Richard Earnshaw Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jwakely@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 17:12:37 -0000 On Tue, 30 Nov 2021 at 15:14, Corinna Vinschen wrote: > > On Nov 30 12:01, Jonathan Wakely wrote: > > On 23/11/21 23:15 -0500, Mike Frysinger wrote: > > > On 23 Nov 2021 15:09, Richard Earnshaw wrote: > > > > This is wrong and breaks all old versions of C++. > > > > > > this is a bit vague. it would help if you provided details as to what broke. > > > i doubt this broke all old versions of C++ everywhere. > > > > > > i'm guessing you're referring to the GNU C++ (libstdc++) library specifically > > > and its hardcoding of newlib's internal ctype define names. > > > https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/config/os/newlib/ctype_base.h;hb=releases/gcc-11.2.0 > > > > Yes, you were CC'd on the GCC bug slightly before Richard sent his > > email to this list: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103305#c16 > > > > > if you're talking about something else, please state so clearly. > > > > > > > The GNU sim code should not be using reserved names (those starting _) > > > > in normal source code. Such names are reserved to the implementation. > > > > > > that's not really a good reason to go pooping all over the namespace. > > > > > > we can maintain backwards compat here for C++ code fairly easily: > > > > Yes, or only do that for GCC < 12, as I suggested in > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103305#c19 > > > > #if defined(__GNUC__) && defined(__cplusplus) > > # if __GNUC__ < 12 > > > > The libstdc++ code on trunk uses the new _ISupper names. > > > > I have no opinion on how long you should keep such backwards > > compatibility around. Whatever time limit you set, at some point it > > will make a new newlib release unusable with past G++ versions. > > Is there a good reason to revert these patches in newlib? I see the > problem but I'm unclear on how problematic the change is in real life. You cannot use newlib from Git to build any released version of GCC. Is building newlib from Git only supported when using GCC trunk, or is it supposed to build with e.g. GCC 11.2.0 from July this year? If yes, then newlib needs changes (whether reverting the change entirely, or just making another change to restore the old names in addition to the new ones).