From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by sourceware.org (Postfix) with ESMTPS id 346553858D20 for ; Wed, 5 Apr 2023 15:44:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 346553858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-545cb3c9898so609246117b3.7 for ; Wed, 05 Apr 2023 08:44:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680709455; x=1683301455; h=to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n0rOdiApN9M2yJ1gUsPn4HkFDyRtokQVgNDko3/QpUE=; b=wZFqa2BzimEc2kw5u2F7UN4Cj25dALNOCBYuKc5VTQql6gvwYc8MkgBPvPPcHt6e80 Il+MLo2VbOU1bsF9r1V3piebp+LnvXdO8ZnYzdcvuUm+0ywFShH1qlSt0CFlReu7ty/2 xmXnow1MlpkikhftOMDPVh3GpEsaH+SaLynVOUOzw0S0wGSNENbYu7U6V8PyPcwA7ruI dswulbzqxo4PfKM7lauf6sN9GG/MH89PbRSem3NcZfMxS0Axi+ZWiEYCX6BOxt/knLuS q1tMbrmSSbhY1WCluAmOxJNkJllulwlTkainS9lj/5/CTIkT8ojw0zLvjWH/1DrwyheH eN/g== X-Gm-Message-State: AAQBX9fzmmVI+A95wU9PJX8hQrVHxcaLXInSlvCroNXaRpuWevWkl7t+ kE92IBhuKNuz2UdxNTLbCofhBMIDg6E= X-Google-Smtp-Source: AKy350bxyzLvyiyH6uVG/fMyRC7rbIyokkeSGvkkft8Cdo/6DiNVUp0KFG4uXoeSO7PzHAvTTiANWg== X-Received: by 2002:a0d:c641:0:b0:54c:101:830b with SMTP id i62-20020a0dc641000000b0054c0101830bmr616990ywd.39.1680709455291; Wed, 05 Apr 2023 08:44:15 -0700 (PDT) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id v31-20020a81b71f000000b00545a081847fsm3970329ywh.15.2023.04.05.08.44.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 08:44:14 -0700 (PDT) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-5445009c26bso684321217b3.8 for ; Wed, 05 Apr 2023 08:44:13 -0700 (PDT) X-Received: by 2002:a81:b389:0:b0:545:5b2c:4bf6 with SMTP id r131-20020a81b389000000b005455b2c4bf6mr3730692ywh.7.1680709453612; Wed, 05 Apr 2023 08:44:13 -0700 (PDT) MIME-Version: 1.0 References: <20230403205837.1595602-1-jennifer.averett@oarcorp.com> In-Reply-To: Reply-To: joel@rtems.org From: Joel Sherrill Date: Wed, 5 Apr 2023 10:44:01 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3]: Add math support for non LDBL_EQ_DBL architecture To: newlib@sourceware.org, Jennifer Averett Content-Type: multipart/alternative; boundary="000000000000f40a7905f898a9e7" X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f40a7905f898a9e7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 5, 2023 at 4:23=E2=80=AFAM Corinna Vinschen wrote: > Hi Jennifer, > > On Apr 3 15:58, Jennifer Averett wrote: > > The attached set of patches add long double support for i386, aarch64 > and > > x86_64. The riscv and powerpc are supported by FreeBSD but will need > more > > work to be supported by newlib. FreeBSD has separate 64 and 32 bit > powerpc > > support which would have to be integrated for newlib. FreeBSD riscv > support > > is 64 and there are issues with fenv.h that would have to be addressed. > > Thanks for your patchset, it looks pretty well to me, though I like > to have input on this from my co-maintainer Jeff, too. > I would assume at least Jeff's input on something like this. :) Kudos to Jennifer for taking my half-finished second attempt at this and pushing it to something that is much much closer. > > I noticed that you exclude Cygwin from the new code, which makes sense > as long as we provide our own long double math taken from Mingw-w64. > What needs to happen for Cygwin/Mingw_w64? Honestly, we didn't discuss that at all. > > However, there's something not quite right. When trying to build I get > symbol conflicts for the fdim{f,l} and scalbln{f,l} symbols in the link > stage (paths shortend for readability): > > ld: libm.a(libm_a-s_fdim.o): in function `fdimf': > newlib/libm/ld/s_fdim.c:47: multiple definition of `fdimf'; > libm.a(libm_a-sf_fdim.o):newlib/libm/common/sf_fdim.c:16: first defined h= ere > > ld: libm.a(libm_a-s_fdim.o): in function `fdiml': > newlib/libm/ld/s_fdim.c:48: multiple definition of `fdiml'; > libdll.a(fdiml.o):winsup/cygwin/math/fdiml.c:11: first defined here > > ld: libm.a(libm_a-s_scalbln.o): in function `scalblnf': > newlib/libm/ld/s_scalbln.c:46: multiple definition of `scalblnf'; > libm.a(libm_a-sf_scalbln.o):newlib/libm/common/sf_scalbln.c:34: first > defined here > > ld: libm.a(libm_a-s_scalbln.o): in function `scalblnl': > newlib/libm/ld/s_scalbln.c:53: multiple definition of `scalblnl'; > libdll.a(scalbnl.o):winsup/cygwin/scalbnl.S:19: first defined here > > The conflicts really ony occur for these four functions. Any chance > to fix these? > We chatted and those will be fixed in the next round. Anything else you think needs tidying up? --joel > > > Thanks, > Corinna > > --000000000000f40a7905f898a9e7--