From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by sourceware.org (Postfix) with ESMTPS id 97B6A384A022 for ; Thu, 13 Aug 2020 13:11:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 97B6A384A022 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joel.sherrill@gmail.com Received: by mail-ed1-f65.google.com with SMTP id c10so4143491edk.6 for ; Thu, 13 Aug 2020 06:11:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=3KLKR3xScrohY6o6TNDqhaDZPRVKTG2rAqjJdL7WfjI=; b=Qe+C6ve8tNnibgaRefmUQlHBGaMx7pvL1o9mbAh6RD9Q/MLE+7XM7sqBqDLcNsN2SG tVmo8PLRDjruG9xBdAQsaGe6X9T5bJUFVQEnKWs1T+IlBrWKVwZFh6ZYjwpieCbxUIr5 TpJ6n0FifYhTYwvUw8NkDrg7AcDtz+xR/LL+92q7ELjgGfJceQCTxF9768Gfde0I0O1k oqZjbVQJ95Yx172yq/0opdVXuGPOrYT/sfCITOBVGud2hGQD7w53JSP88/yGJNHVGcDJ zXlBYgWizE58V5GqveGztPp42TsC3nJf0UIkLaO8uj0Ov6/EwnTmPBwYob5SZXVx96yd MFdw== X-Gm-Message-State: AOAM530ZRyioFveOhOQQGq1UAvcMtJQUuD7RcO+CVCcqq7RMHJ3kfN+f 588QOiRYbWA+b+G711ImKTGmldOw X-Google-Smtp-Source: ABdhPJzrNPI8ecweWy+cbDW1DJWXZhh3aWPn2eKvCkSnUkjS5NdlcTIMUFhvAsZ//jhrG+OPCU2jtA== X-Received: by 2002:aa7:d516:: with SMTP id y22mr4576233edq.221.1597324303323; Thu, 13 Aug 2020 06:11:43 -0700 (PDT) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id n25sm4009462ejr.21.2020.08.13.06.11.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Aug 2020 06:11:43 -0700 (PDT) Received: by mail-ed1-f43.google.com with SMTP id l23so4134887edv.11 for ; Thu, 13 Aug 2020 06:11:43 -0700 (PDT) X-Received: by 2002:a05:6402:785:: with SMTP id d5mr4716236edy.370.1597324302999; Thu, 13 Aug 2020 06:11:42 -0700 (PDT) MIME-Version: 1.0 References: <20200812213852.26096-1-eshandhawan51@gmail.com> <20200813081651.GU53219@calimero.vinschen.de> In-Reply-To: <20200813081651.GU53219@calimero.vinschen.de> Reply-To: joel@rtems.org From: Joel Sherrill Date: Thu, 13 Aug 2020 08:11:31 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Added FTW.H Methods To: Newlib , Eshan dhawan , joel@rtems.com Cc: Corinna Vinschen X-Spam-Status: No, score=-3032.2 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 13:11:46 -0000 On Thu, Aug 13, 2020 at 3:17 AM Corinna Vinschen via Newlib < newlib@sourceware.org> wrote: > On Aug 13 03:08, Eshan dhawan via Newlib wrote: > > Signed-off-by: Eshan dhawan > > --- > > newlib/configure.host | 2 +- > > newlib/libc/include/ftw.h | 64 ++++++++++++++ > > newlib/libc/posix/Makefile.am | 2 +- > > newlib/libc/posix/ftw.c | 36 ++++++++ > > newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++ > > 5 files changed, 256 insertions(+), 2 deletions(-) > > create mode 100644 newlib/libc/include/ftw.h > > create mode 100644 newlib/libc/posix/ftw.c > > create mode 100644 newlib/libc/posix/nftw.c > > Why do we need _FTW_ENABLE_? > > What do we need the foo64 variants for? WHile newlib defines > _LARGEFILE64_SOURCE for __linux__ and __RDOS__, it's not used > anywhere else in newlib itself. > > Also, there's a ftw/nftw implementation in Cygwin already. Did you > check it for inclusion into newlib, or to drop the Cygwin version in > favor of a new newlib versions? We could at least share a common > header, but then we will have to use the flag values already used in > the Cygwin implementation for backward compatibility. > We went straight to *BSD for implementations and didn't look at Cygwin. I've asked Eshan to replace the implementation with the Cygwin one. Hopefully that's easy and allows one more piece of shared software. --joel > > > Thanks, > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat > >