From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by sourceware.org (Postfix) with ESMTPS id 1C3733858D20 for ; Fri, 2 Dec 2022 14:15:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C3733858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-f178.google.com with SMTP id r19so5213274qtx.6 for ; Fri, 02 Dec 2022 06:15:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=205KHOgu7nOPLauTCwHZOEb+Exm1lGIonWCmzof4AV0=; b=GQlb4bV5fPZ8hoptYHtmTqD0qIXzZ1/Xh9YKu+HgWJxjpHGj4l0+Dt+pDbAY9lT6/v WHN8pzkLCVxYcSYuI3LFng6N29ubDnfnCll3D4gxDR3G1DdFWYFipj2V1wcP0XB316KH QIcQgFOE/FLizQ+1a413gH6YfgIZDwnaqyw2YZxrGrBQm+furrzJDmK0aGU1CxyLvdnE QXNj4MRu3f607IymgVcUT1ODKuZ+i5Jrrp4Cw/qgcWluhbP+HOLaw6TqZJl0DGQn4XvD cvP1OQdi6WOvmsPloLBfI1Tv9nd/5l6GMxgfoon3hFqoE2jonVYecz+30NlrKMyd0oCN +CXg== X-Gm-Message-State: ANoB5pmGplkpUUk+TGorKI+VT7QsyW132HD380zkLy+DPafvarUq754T YCrCqDFR0FJ2uihmpLgmWB3KRtMiqYY= X-Google-Smtp-Source: AA0mqf5Ojrz7uR8NMm9sxKa81eprsio1y/jZJPqEBPRus9O4cHD8U760h8C3JQpdIrrD0OX2P4yBSQ== X-Received: by 2002:a05:620a:164a:b0:6f9:5ebe:2bba with SMTP id c10-20020a05620a164a00b006f95ebe2bbamr48179296qko.426.1669990513199; Fri, 02 Dec 2022 06:15:13 -0800 (PST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com. [209.85.128.172]) by smtp.gmail.com with ESMTPSA id t14-20020a05620a450e00b006cf38fd659asm5779316qkp.103.2022.12.02.06.15.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 06:15:12 -0800 (PST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-3b10392c064so50210387b3.0 for ; Fri, 02 Dec 2022 06:15:12 -0800 (PST) X-Received: by 2002:a0d:cf07:0:b0:36a:1b29:6a39 with SMTP id r7-20020a0dcf07000000b0036a1b296a39mr50138062ywd.254.1669990512198; Fri, 02 Dec 2022 06:15:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Reply-To: joel@rtems.org From: Joel Sherrill Date: Fri, 2 Dec 2022 08:15:00 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Adding aio.h and mqueue.h To: newlib@sourceware.org, Jeff Johnston Content-Type: multipart/alternative; boundary="000000000000420f6e05eed8f78f" X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000420f6e05eed8f78f Content-Type: text/plain; charset="UTF-8" On Fri, Dec 2, 2022 at 4:07 AM Corinna Vinschen wrote: > On Dec 1 18:22, Jeff Johnston wrote: > > As long as the licensing is shared-newlib-compatible (non-GPL), it should > > be ok. > > > > -- Jeff J. > > Cygwin already comes with aio.h and mqueue.h headers. > > Ideally they are reused for newlib, or the new aio.h/mqueue.h headers > are checked that they provide the same definitions and replace the > Cygwin-only ones. > OK. So the same defines with the same values? Anything cygwin specific goes into an ifdef, etc. I vaguely recall doing this before for other header files. RTEMS is always built from source so changing the values isn't a huge binary compatibility issue. But moving the header file from RTEMS to newlib will require everyone using the git master to build new tools. So there is a bit of coordination on our side. --joel > > > Thanks, > Corinna > > > > > > > > > On Thu, Dec 1, 2022 at 11:37 AM Joel Sherrill wrote: > > > > > Hi > > > > > > We have migrated almost all of our POSIX defined header files from > RTEMS > > > itself to newlib. I think aio.h and mqueue.h are the last POSIX > headers > > > left on our side. > > > > > > What's the feeling on merging these? Would it be ok to put them in > > > newlib/libc/include? > > > > > > Our version of the headers have Doxygen comments. Would these be OK in > > > newlib or do I need to remove the Doxygen? > > > > > > Thanks. > > > > > > --joel > > > > > > > > --000000000000420f6e05eed8f78f--