From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by sourceware.org (Postfix) with ESMTPS id 8C4E93890431 for ; Thu, 20 Jun 2024 22:21:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C4E93890431 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C4E93890431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.175 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718922081; cv=none; b=TTAwJKgzwSRtxes3meGIedkaUXbb/6chRSSkN6XA+w/t2y9AStqk8BelYfRmdke9aCHTG8i21dlZVcnWKkfdGyNB3dWc3ogco/L0NVMGxbcA2SzrCYnY65EFTktuZFTpXaVRn/94Lzhm3O40PcaP/KtlOtqbJ93VgM4dE37x6Vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718922081; c=relaxed/simple; bh=UM+yeEvCjOIds5z5wpPYq1LyXPpDCSvKa9Gb2rym7N8=; h=MIME-Version:From:Date:Message-ID:Subject:To; b=PdL4EifiZU5tBFSMi2uKiqESiDF/XPKZ9lGqh3mBgXXu/xypI6YDO65WmvX9RBU3S852+UbTmWgfbK4RbhAnYHnl7Tyok9g8/Be3Nos6pEq3SIdmAoXI5EG30WhyGOc4+xSPLFd163MVttOqCoJEqItxMUDFQhXTSY2K4k0O/7k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4ecf8213dc6so407466e0c.3 for ; Thu, 20 Jun 2024 15:21:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718922079; x=1719526879; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Buxi6uePR1BDfDdmxpn3EKfL4GAgQFkrAsMG5JqRuUw=; b=d2B6WHg/6tjs60eFp3zVtwIJLQN8ALxs22WbtaHmvjKRBbBx89Q53WI5oD3W3Qrav/ B0XdXjAhvyMoD/MXQPj8L9Trf2Xwuk3pIj0G4Wy9JNS90qVwZoBn2VV2RuzM8JjzsGhF lXcJKGc5ziij/ZOvjCpUHpG/PtXXRYDm9/DwOhsujVd33Iixf649StHIuF5O8NipDwRp wMxhBMNlHMG/0QRkFjZRKGbREhtBjdOS39G3h028IHq0R2YuIgkiLahPq2VO0i5NrRor y7CS9M+ERQPOqYCRWzLDXK247MOFFjEyY6be3eryKPXniVHFqppJzWJGeNbU02KZiKKU hHXQ== X-Gm-Message-State: AOJu0YyVYxA/3YzHixMVCrRJyVhCCXYt/zcrFq+gtpzpDYMO8NsAO5gD qpPLkKJYGiv6wwGveL+484RJ2imhsAdf5g72q351Ef9XpwyrwrqRKMu/ug== X-Google-Smtp-Source: AGHT+IElHC5j6H+RRZd6PEPsdOZJtWJ3Uny2C/wS78pMaASnZgdVEWrpYVvsa50qcCtCNAAAtrV5EQ== X-Received: by 2002:a05:6122:1783:b0:4ec:f018:ee1e with SMTP id 71dfb90a1353d-4ef2778d042mr7347767e0c.12.1718922077132; Thu, 20 Jun 2024 15:21:17 -0700 (PDT) Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com. [209.85.221.171]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-4ef466f3c7bsm51030e0c.37.2024.06.20.15.21.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 15:21:16 -0700 (PDT) Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-4ed0a343db6so373146e0c.1 for ; Thu, 20 Jun 2024 15:21:16 -0700 (PDT) X-Received: by 2002:a05:6122:1692:b0:4df:261c:fc0c with SMTP id 71dfb90a1353d-4ef277c009emr7145052e0c.13.1718922076118; Thu, 20 Jun 2024 15:21:16 -0700 (PDT) MIME-Version: 1.0 References: <20240618202507.15847-1-joel@rtems.org> <29ad23ba-5235-4830-82e4-8ceb941e7889@embedded-brains.de> In-Reply-To: <29ad23ba-5235-4830-82e4-8ceb941e7889@embedded-brains.de> Reply-To: joel@rtems.org From: Joel Sherrill Date: Thu, 20 Jun 2024 17:21:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] sys/tree.h: Removed To: Sebastian Huber Cc: newlib@sourceware.org Content-Type: multipart/alternative; boundary="000000000000be6ec7061b59bb95" X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000be6ec7061b59bb95 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 20, 2024 at 4:13=E2=80=AFAM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > On 18.06.24 22:25, Joel Sherrill wrote: > > This file was from a specific older FreeBSD version. There have been > > multiple changes to this file with FreeBSD 14 including breaking > > changes to the file. > > What kind of breaking changes did you observe in the FreeBSD 14 version > of ? I see no breaking API changes. FreeBSD changed the > implementation to use rank-balanced trees instead of red-black trees, > but this should not have resulted in API breaks (the ABI changed though). > This creates a conflict between the libc and rtems-libbsd versions. When both are installed, the header installed by libbsd results in different code than the version RTEMS was compiled with. Using this internally in RTEMS, we opened ourselves to external changes impacting the score implementation of rbtree. This leaves us open to external changes having an impact on performance. We should take on the preferred implementation inside the score of RTEMS so we have control. We will end up having to do something with the file name and name space. This actually violated a core development principle for RTEMS and we should have spotted this long ago. Everything in the score and "bottom" of RTEMS should not depend on libc. We need to control the implementation used internal to RTEMS. Realizing that it was not up date in newlib just triggered the realization that we should not have been using it. --joel > -- > embedded brains GmbH & Co. KG > Herr Sebastian HUBER > Dornierstr. 4 > 82178 Puchheim > Germany > email: sebastian.huber@embedded-brains.de > phone: +49-89-18 94 741 - 16 > fax: +49-89-18 94 741 - 08 > > Registergericht: Amtsgericht M=C3=BCnchen > Registernummer: HRB 157899 > Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler > Unsere Datenschutzerkl=C3=A4rung finden Sie hier: > https://embedded-brains.de/datenschutzerklaerung/ > --000000000000be6ec7061b59bb95--