From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by sourceware.org (Postfix) with ESMTPS id BFFD33851C06 for ; Wed, 13 May 2020 18:23:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BFFD33851C06 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joel.sherrill@gmail.com Received: by mail-ej1-f51.google.com with SMTP id x20so323319ejb.11 for ; Wed, 13 May 2020 11:23:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to; bh=B1LhRU95yOeEldzn/Ug3/L7IyvB9HZ4JluAMnsMFKik=; b=e0W+wITvbe/iJUBmKnOh4KxGf/odIjp21AnCv+kWU/3Tnkallihu5lXZEULCpciYIh VosZPJloOo3sAh++oUb5hjRe6ognIwgl0mVPrTvQ7b4VlMuXf5gmVOdqQWcOvpDFNK6I catL+/lU/mBaefTTxV/FA716aVQ2ZivdAGK0mAONh/291KVQ8qioGEIN2d1Jl3RpaAlM jDyhrX7lC4waKbJgudTdH2pOI1bc9bO3/M4koOPhxMym93uGhhUEvFASB6LgOcVYGgEL isvw1mJjvv3rHCeLY/3p4Go73sBmp5Q8DAOUQHEc688TxIDtHATE9UcKUL/WyDvVFabt RryQ== X-Gm-Message-State: AOAM5326mdGW0uSLo/B9KRqRUmAkkKw6VucPaYBvjZtC0qe75d7lxzYh 8m1V1FnVDQuZODpVoZHtGKMR7NCT X-Google-Smtp-Source: ABdhPJzq5HXlvbEjuJ5UrWCYYE5ETR/V0SJG9msKyXV4G0YjbOkbPh4AOH7+oK0H/RE9Lz///DsN5g== X-Received: by 2002:a17:906:6453:: with SMTP id l19mr262276ejn.169.1589394214393; Wed, 13 May 2020 11:23:34 -0700 (PDT) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com. [209.85.218.47]) by smtp.gmail.com with ESMTPSA id cm26sm8687edb.87.2020.05.13.11.23.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2020 11:23:34 -0700 (PDT) Received: by mail-ej1-f47.google.com with SMTP id a2so357564ejx.5 for ; Wed, 13 May 2020 11:23:33 -0700 (PDT) X-Received: by 2002:a17:906:4310:: with SMTP id j16mr347281ejm.102.1589394213644; Wed, 13 May 2020 11:23:33 -0700 (PDT) MIME-Version: 1.0 References: <57210fe5-27e7-f212-b9fd-158fe2c0c8e8@SystematicSw.ab.ca> In-Reply-To: <57210fe5-27e7-f212-b9fd-158fe2c0c8e8@SystematicSw.ab.ca> Reply-To: joel@rtems.org From: Joel Sherrill Date: Wed, 13 May 2020 13:22:28 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: arm fenv support - static inline of methods To: Newlib X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2020 18:23:38 -0000 On Wed, May 13, 2020 at 1:17 PM Brian Inglis < Brian.Inglis@systematicsw.ab.ca> wrote: > On 2020-05-13 08:11, Joel Sherrill wrote: > > > Eshan Dhawan is an RTEMS GSoC 2020 student working on adding more POSIX > > methods to RTEMS and newlib if appropriate. He is currently looking at > > adding more > > fenv.h implementations. > > > > The FreeBSD implementation of arm fenv.h has static inlines for all the > > methods in sys/fenv.h. Is this OK? Or should they be turned into real > > bodies in a C file? > > Don't all functions need to be provided as linkable implementations for > cases > where they are invoked using their address directly or indirectly, unless > the > standards agree they don't need to be? > That's what I think also but that's not how FreeBSD has implemented it. IMO the static inline implementations from them need to move to .c files. --joel > > -- > Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada > > This email may be disturbing to some readers as it contains > too much technical detail. Reader discretion is advised. > [Data in IEC units and prefixes, physical quantities in SI.] >