From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by sourceware.org (Postfix) with ESMTPS id 05F74385AC3A for ; Fri, 27 Aug 2021 13:47:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 05F74385AC3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-f179.google.com with SMTP id l18so11474467lji.12 for ; Fri, 27 Aug 2021 06:47:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to; bh=OkBmHuI9Mh6l6N3ImhLuJ0M/QXsdcWwKN2TsXlJd4Cc=; b=GxFZFm3uBSCEkXjgMkLgJEGLqpcLoZUGEnty3gZytcH0NzADfY6BkdvF1zq8maNMsI qvaSqrIHjv1ZFEzGjB+zSbnsc6Xmale7aKpNQKEAI6MTv+EVLHc5oc2BP8RsAD5BEcrW wVoKZrohKIsbUUBVhRlEafbj8tMSiLdhdK9dXgEAxKyWk6afdgxHXZA+Do4FGBid7Euc m3O37/FQy7eAkCx7rRGrfs5CVCZ7GWnf7nWxn86Cv8Snfss2VcwCRURWUy0L+R7AFuJz NQJucyB4hRTEep/gr8ko13imwdREJQsIF+0IYhIcsQEuEhFQrFHAyuOHF7OO1Y3LhXZC l+Mg== X-Gm-Message-State: AOAM532iiN3OZcBs4NarEQlIhO1tp1wsgjOJQsFZu5YULfWhYzJorLX0 UVpP8FOHQoxbmOBcqJJH6tGyKxgW8drGeg== X-Google-Smtp-Source: ABdhPJxPeLCw12z/rieKbQXCc9mnRAl0iLZksaf/jfdMh9/U0EPGcjJnDz7GFN90TtjW4sqEF4mtvQ== X-Received: by 2002:a2e:a58b:: with SMTP id m11mr7848338ljp.342.1630072070109; Fri, 27 Aug 2021 06:47:50 -0700 (PDT) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com. [209.85.208.178]) by smtp.gmail.com with ESMTPSA id d24sm658391lfs.80.2021.08.27.06.47.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Aug 2021 06:47:49 -0700 (PDT) Received: by mail-lj1-f178.google.com with SMTP id q21so11513136ljj.6 for ; Fri, 27 Aug 2021 06:47:49 -0700 (PDT) X-Received: by 2002:a2e:b042:: with SMTP id d2mr7968333ljl.378.1630072069226; Fri, 27 Aug 2021 06:47:49 -0700 (PDT) MIME-Version: 1.0 References: <20210825191245.30049-1-joel@rtems.org> In-Reply-To: Reply-To: joel@rtems.org From: Joel Sherrill Date: Fri, 27 Aug 2021 08:47:37 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Fw: [PATCH newlib 0/1] sys/signal.h needs sys/_intsup.h To: Newlib Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3031.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 13:47:53 -0000 On Fri, Aug 27, 2021 at 5:16 AM Corinna Vinschen wrote: > > On Aug 26 18:28, Joel Sherrill wrote: > > We recently added this to sys/signal.h: > > > > #if __STDINT_EXP(INT_MAX) > 0x7fff > > #define SIG2STR_MAX (sizeof("RTMAX+") + sizeof("4294967295") - 1) > > #else > > #define SIG2STR_MAX (sizeof("RTMAX+") + sizeof("65535") - 1) > > #endif > > > > And -ffreestanding breaks that. I see two solutions: > > > > (1) Add __STDINT_EXP to gcc's stdint-gcc.h > > (2) Switch that #if to something else > > > > I think something like this is an OK substitute works equivalently: > > > > #if __SIZEOF_INT__ > 2 > > or even __SIZEOF_INT__ >= 4 to be extra *extra* paranoid, but yeah, > sure, go ahead. The commmit message should just briefly explain the > freestanding implementation issue. Patch posted. Hopefully the commit message is clear enough. This one definitely is in the land of subtle small things. Thanks for the feedback and push to look for a deeper explanation. --joel > > > Corinna >