From: Joel Sherrill <joel@rtems.org>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: Eshan dhawan <eshandhawan51@gmail.com>,
Newlib <newlib@sourceware.org>,
jeol@rtems.org
Subject: Re: [PATCH 1/1] fenv support arm
Date: Thu, 2 Jul 2020 17:33:21 -0500 [thread overview]
Message-ID: <CAF9ehCWsKgV72v0YF4iMTs1FviLW5e6hwwWVuh+0gk+Sb9=WVA@mail.gmail.com> (raw)
In-Reply-To: <CAF9ehCW1N9ht5yVMcFuXppZT06i-NbaVwJb0N6o-Am7udb7P8w@mail.gmail.com>
Szabolcs, is the code in question compiled with any feature flags set?
I see on Linux that the prototypes would be triggered by _GNU_SOURCE while
in newlib, it is _BSD_SOURCE. Is that possibly contributing?
Can you post a test case? The command line that is failing would also help.
I'd like to not guess at what's wrong.
--joel
On Thu, Jul 2, 2020 at 10:48 AM Joel Sherrill <joel@rtems.org> wrote:
>
>
> On Thu, Jul 2, 2020 at 7:11 AM Szabolcs Nagy <szabolcs.nagy@arm.com>
> wrote:
>
>> The 06/03/2020 23:15, Eshan dhawan via Newlib wrote:
>> > --- /dev/null
>> > +++ b/newlib/libc/machine/arm/sys/fenv.h
>> ...
>> > +#ifndef __ARM_PCS_VFP
>> > +
>> > +int feclearexcept(int excepts);
>> > +int fegetexceptflag(fexcept_t *flagp, int excepts);
>> > +int fesetexceptflag(const fexcept_t *flagp, int excepts);
>> > +int feraiseexcept(int excepts);
>> > +int fetestexcept(int excepts);
>> > +int fegetround(void);
>> > +int fesetround(int round);
>> > +int fegetenv(fenv_t *envp);
>> > +int feholdexcept(fenv_t *envp);
>> > +int fesetenv(const fenv_t *envp);
>> > +int feupdateenv(const fenv_t *envp);
>> > +#if __BSD_VISIBLE
>> > +int feenableexcept(int __mask);
>> > +int fedisableexcept(int __mask);
>> > +int fegetexcept(void);
>> > +#endif /* __BSD_VISIBLE */
>> > +
>> > +#endif /* __ARM_PCS_VFP */
>>
>> why are these declarations conditional?
>>
>
> The prototypes for the POSIX methods are in the shared fenv.h.
>
> Since the ARM has the BSD_VISIBLE extras, those should be left in the arm
> specific sys/fenv.h.
>
> But (I don't think) they need a ARM_PCS_VFP wrapper since there should be
> an implementation for all multilibs. We could discuss the BSD_VISIBLE
> prototypes being moved to <fenv.h> and removed from all the architecture
> <sys/fenv.h>
> but that was also how the code I moved from Cygwin to newlib libm was done
> so
> maybe there is a reason that I don't know to leave it here.
>
>>
>> i get build failures e.g. in libgfortran
>> because configure detects the availability
>> of feenableexcept in libm.a so it starts
>> using it but then fenv.h does not have the
>> declaration so compilation fails.
>>
>> it seems there is vfp code for all this
>> so why are the declarations removed?
>>
>
> The FreeBSD headers rely on the architecture sys/fenv.h prototypes
> even for POSIX standard methods. Most of the block of code is removed
> because the prototypes were in <fenv.h> which is where this file is
> included
> from.
>
> Eshan... re-add the BSD_VISIBLE block please and resubmit. It also
> looks like the test code isn't exercising those methods so that should
> be updated after this patch is updated. We don't want libfortran broken
> for longer than neccessary.
>
> --joel
>
next prev parent reply other threads:[~2020-07-02 22:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 17:45 [PATCH 0/1] Add fenv support for ARM Eshan dhawan
2020-06-03 17:45 ` [PATCH 1/1] fenv support arm Eshan dhawan
2020-07-02 12:11 ` Szabolcs Nagy
2020-07-02 15:48 ` Joel Sherrill
2020-07-02 22:33 ` Joel Sherrill [this message]
2020-07-03 9:14 ` Szabolcs Nagy
2020-07-03 13:12 ` Joel Sherrill
2020-06-10 1:15 ` [PATCH 0/1] Add fenv support for ARM Jeff Johnston
2020-06-10 17:31 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF9ehCWsKgV72v0YF4iMTs1FviLW5e6hwwWVuh+0gk+Sb9=WVA@mail.gmail.com' \
--to=joel@rtems.org \
--cc=eshandhawan51@gmail.com \
--cc=jeol@rtems.org \
--cc=newlib@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).