From: Joel Sherrill <joel@rtems.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH 3/6] newlib: drop unused iconvdata
Date: Mon, 7 Feb 2022 22:55:50 -0600 [thread overview]
Message-ID: <CAF9ehCWyHs+99zzazARuWBG0Lh1T86ettd2z2MuVsD4h8W_xOQ@mail.gmail.com> (raw)
In-Reply-To: <20220208015706.6482-4-vapier@gentoo.org>
Funny thing that we had been discussing this amongst some of the RTEMS
developers. It was improperly licensed for newlib unless only used for
Linux. And the placement in the tree didn't .ake that clear.
Good riddance since you determined it wasn't needed.
Thanks for this bit.
--joel
On Mon, Feb 7, 2022, 7:58 PM Mike Frysinger <vapier@gentoo.org> wrote:
> This was only ever used for i?86-pc-linux-gnu targets, but that's been
> broken for years, and has since been dropped. So clean this up too.
> ---
> newlib/Makefile.am | 3 -
> newlib/Makefile.in | 157 +-
> newlib/configure | 20 +-
> newlib/configure.ac | 3 -
> newlib/iconvdata/EUC-JP.irreversible | 2 -
> newlib/iconvdata/Makefile.inc | 20 -
> newlib/iconvdata/SJIS.irreversible | 5 -
> newlib/iconvdata/dummy.c | 1 -
> newlib/iconvdata/euc-jp.c | 246 --
> newlib/iconvdata/gconv-modules | 1511 --------
> newlib/iconvdata/jis0201.c | 58 -
> newlib/iconvdata/jis0201.h | 60 -
> newlib/iconvdata/jis0208.c | 5012 --------------------------
> newlib/iconvdata/jis0208.h | 106 -
> newlib/iconvdata/jis0212.c | 3940 --------------------
> newlib/iconvdata/jis0212.h | 110 -
> newlib/iconvdata/sjis.c | 4512 -----------------------
> 17 files changed, 36 insertions(+), 15730 deletions(-)
> delete mode 100644 newlib/iconvdata/EUC-JP.irreversible
> delete mode 100644 newlib/iconvdata/Makefile.inc
> delete mode 100644 newlib/iconvdata/SJIS.irreversible
> delete mode 100644 newlib/iconvdata/dummy.c
> delete mode 100644 newlib/iconvdata/euc-jp.c
> delete mode 100644 newlib/iconvdata/gconv-modules
> delete mode 100644 newlib/iconvdata/jis0201.c
> delete mode 100644 newlib/iconvdata/jis0201.h
> delete mode 100644 newlib/iconvdata/jis0208.c
> delete mode 100644 newlib/iconvdata/jis0208.h
> delete mode 100644 newlib/iconvdata/jis0212.c
> delete mode 100644 newlib/iconvdata/jis0212.h
> delete mode 100644 newlib/iconvdata/sjis.c
>
> diff --git a/newlib/Makefile.am b/newlib/Makefile.am
> index 1e35e64300fa..c6a2b3fe9dca 100644
> --- a/newlib/Makefile.am
> +++ b/newlib/Makefile.am
> @@ -505,9 +505,6 @@ TEXINFO_TEX = ../texinfo/texinfo.tex
> if HAVE_DOC
> include doc/local.mk
> endif
> -if HAVE_ICONVDATA
> -include iconvdata/Makefile.inc
> -endif
> include libc/Makefile.inc
> include libm/Makefile.inc
>
> diff --git a/newlib/configure.ac b/newlib/configure.ac
> index 366fffafcff3..0ae3e4bb28a5 100644
> --- a/newlib/configure.ac
> +++ b/newlib/configure.ac
> @@ -347,9 +347,6 @@ AM_CONDITIONAL(HAVE_DOC, test x$have_multisubdir = xno)
> # subdirectory withing the build directory.
> AM_CONDITIONAL(HAVE_MULTISUBDIR, test x$have_multisubdir = xyes)
>
> -HAVE_ICONVDATA=false
> -AM_CONDITIONAL([HAVE_ICONVDATA], $HAVE_ICONVDATA)
> -
> CRT0=
> CRT0_DIR=
> if test "x${have_crt0}" = "xyes"; then
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2022-02-08 4:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 9:27 can i delete libtool / shared library support ? Mike Frysinger
2022-02-07 10:30 ` Mike Frysinger
2022-02-07 11:48 ` Corinna Vinschen
2022-02-07 19:30 ` Jeff Johnston
2022-02-08 1:57 ` [PATCH 0/6] delete i?86-pc-linux-gnu & libtool support Mike Frysinger
2022-02-08 1:57 ` [PATCH 1/6] newlib: drop i?86-pc-linux-* target support Mike Frysinger
2022-02-08 1:57 ` [PATCH 2/6] newlib: punt sys/linux support Mike Frysinger
2022-02-08 1:57 ` [PATCH 3/6] newlib: drop unused iconvdata Mike Frysinger
2022-02-08 4:55 ` Joel Sherrill [this message]
2022-02-08 1:57 ` [PATCH 4/6] newlib: drop libtool support Mike Frysinger
2022-02-08 9:47 ` Corinna Vinschen
2022-02-09 0:20 ` Mike Frysinger
2022-02-09 10:54 ` Corinna Vinschen
2022-02-09 8:41 ` Brian Inglis
2022-02-09 10:55 ` Corinna Vinschen
2022-02-08 1:57 ` [PATCH 5/6] newlib: drop support for $aext Mike Frysinger
2022-02-08 1:57 ` [PATCH 6/6] newlib: drop support for $oext Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF9ehCWyHs+99zzazARuWBG0Lh1T86ettd2z2MuVsD4h8W_xOQ@mail.gmail.com \
--to=joel@rtems.org \
--cc=newlib@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).