public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Joel Sherrill <joel@rtems.org>
To: Newlib <newlib@sourceware.org>,
	Eshan dhawan <eshandhawan51@gmail.com>,
	joel@rtems.com
Cc: Corinna Vinschen <vinschen@redhat.com>
Subject: Re: [PATCH] Removed Soft float from MIPS
Date: Thu, 13 Aug 2020 08:10:30 -0500	[thread overview]
Message-ID: <CAF9ehCX1H+ujKsLYh7vEYbzB7hsRa3DTxNc905QGmot+7YG8vA@mail.gmail.com> (raw)
In-Reply-To: <20200813081945.GW53219@calimero.vinschen.de>

On Thu, Aug 13, 2020 at 3:19 AM Corinna Vinschen via Newlib <
newlib@sourceware.org> wrote:

> On Aug 13 03:05, Eshan dhawan via Newlib wrote:
> > This Patch removes Soft Float code from MIPS.
> > Instead It adds the soft float code from RISCV
>
> Why, and why is that the right thing to do?
>

The code came from FreeBSD and assumes the FreeBSD softfp
implementation not the one with GCC. That was an overlooked and
fixed in the other fenv code already.

--joel

>
>
> Thanks,
> Corinna
>
> > Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
> > ---
> >  .../machine/mips/machine/fenv-softfloat.h     | 55 +++++++------------
> >  newlib/libm/machine/mips/fenv.c               | 10 ----
> >  2 files changed, 21 insertions(+), 44 deletions(-)
>
>

  reply	other threads:[~2020-08-13 13:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 21:35 Eshan dhawan
2020-08-13  8:19 ` Corinna Vinschen
2020-08-13 13:10   ` Joel Sherrill [this message]
2020-08-14  4:51     ` Sebastian Huber
2020-08-17  9:23       ` Corinna Vinschen
2020-08-17  9:22     ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAF9ehCX1H+ujKsLYh7vEYbzB7hsRa3DTxNc905QGmot+7YG8vA@mail.gmail.com \
    --to=joel@rtems.org \
    --cc=eshandhawan51@gmail.com \
    --cc=joel@rtems.com \
    --cc=newlib@sourceware.org \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).