From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by sourceware.org (Postfix) with ESMTPS id 6529D3850438 for ; Thu, 17 Jun 2021 21:52:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6529D3850438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f49.google.com with SMTP id j2so12925743lfg.9 for ; Thu, 17 Jun 2021 14:52:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to; bh=fEauOlDalUCwLlGlHKwO1mr5cPU5JZ/xE52EX27OpEs=; b=QyrGkyRYQpxD++u51VX9AUpGWeP2xQliVj9UysvW/Q2t16ZFrBogJeavIt0mBtotFV WILk3SN4T52Va9hAO1e5lTGtpSZluYUgr4/4nUic13J/olQLsFXL4HbeCRQb2kpWME9A k4IsKT5KptLJNFpYgvmKnEavWlB5heEo1Uo3yUylz1RYYmO2Q3Ga5aQfaZ5+9ck8xN6o 3yf42ob30ehufOIfwV4xwuIcO3lrfN5p51j5IRz3ByhMyvi3qLi9MUw/oaNqgVghTcF9 g3tAMVtUzimw2QDdQ5fPm5U2YPjBQMRa/WaSKEeee7yxO9f1MqTDy6H42CEIeWWSTNWC l0lQ== X-Gm-Message-State: AOAM530VcYZGohwPNTX6tqozAQGTKNuJEcxBHsuVgESJkvdfSbKwzAXV l/YOXzmT93FuPvKoMNaihnrIY0YRyzw0GQ== X-Google-Smtp-Source: ABdhPJxZC8YlZhxZM8ZvKVa/tO5s7y6aXTbJpZ37qGhpmDFVJqMCduMj1STyjfGr7+XBrUyosndTzQ== X-Received: by 2002:a19:ca01:: with SMTP id a1mr348369lfg.306.1623966767928; Thu, 17 Jun 2021 14:52:47 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id p2sm695882lfo.141.2021.06.17.14.52.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 14:52:47 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id m21so12877103lfg.13 for ; Thu, 17 Jun 2021 14:52:47 -0700 (PDT) X-Received: by 2002:a05:6512:3044:: with SMTP id b4mr317641lfb.289.1623966767696; Thu, 17 Jun 2021 14:52:47 -0700 (PDT) MIME-Version: 1.0 References: <20210617214954.23621-1-joel@rtems.org> In-Reply-To: <20210617214954.23621-1-joel@rtems.org> Reply-To: joel@rtems.org From: Joel Sherrill Date: Thu, 17 Jun 2021 16:52:36 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] libc/sys/rtems/crt0.c: Fix two warnings. To: Newlib X-Spam-Status: No, score=-3037.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 21:52:51 -0000 Ignore this. Already committed. Just was laying around in my patch output directory. On Thu, Jun 17, 2021 at 4:50 PM Joel Sherrill wrote: > __assert_func() is marked as noreturn and stub should not. > __tls_get_addr() needed to return a value.. > --- > newlib/libc/sys/rtems/crt0.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/newlib/libc/sys/rtems/crt0.c b/newlib/libc/sys/rtems/crt0.c > index 6b8b5f98f..3b131d9c4 100644 > --- a/newlib/libc/sys/rtems/crt0.c > +++ b/newlib/libc/sys/rtems/crt0.c > @@ -195,13 +195,13 @@ RTEMS_STUB(void *, _malloc_r(struct _reent * r, > size_t s), { return 0; }) > RTEMS_STUB(void, _free_r(struct _reent *r, void *p), { }) > > /* stubs for functions required by libc/stdlib */ > -RTEMS_STUB(void, __assert_func(const char *file, int line, const char > *func, const char *failedexpr), { }) > +RTEMS_STUB(void, __assert_func(const char *file, int line, const char > *func, const char *failedexpr), { while (1) ;}) > > #if defined(__arm__) > RTEMS_STUB(void, __aeabi_read_tp(void), { }) > #endif > > -RTEMS_STUB(void *, __tls_get_addr(const void *ti), { }) > +RTEMS_STUB(void *, __tls_get_addr(const void *ti), { return NULL; }) > > /* The PowerPC expects certain symbols to be defined in the linker > script. */ > > -- > 2.24.4 > >