From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57497 invoked by alias); 25 Feb 2020 15:52:17 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 57489 invoked by uid 89); 25 Feb 2020 15:52:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*c:alternative X-HELO: mail-ed1-f67.google.com Received: from mail-ed1-f67.google.com (HELO mail-ed1-f67.google.com) (209.85.208.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Feb 2020 15:52:15 +0000 Received: by mail-ed1-f67.google.com with SMTP id e10so16740505edv.9 for ; Tue, 25 Feb 2020 07:52:14 -0800 (PST) Return-Path: Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com. [209.85.128.47]) by smtp.gmail.com with ESMTPSA id a10sm1194649edt.50.2020.02.25.07.52.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2020 07:52:12 -0800 (PST) Received: by mail-wm1-f47.google.com with SMTP id t14so3642978wmi.5 for ; Tue, 25 Feb 2020 07:52:12 -0800 (PST) MIME-Version: 1.0 References: <1582637913-28759-1-git-send-email-joel@rtems.org> <1582637913-28759-2-git-send-email-joel@rtems.org> <20200225154427.GN4045@calimero.vinschen.de> In-Reply-To: <20200225154427.GN4045@calimero.vinschen.de> Reply-To: joel@rtems.org From: Joel Sherrill Date: Tue, 25 Feb 2020 15:52:00 -0000 Message-ID: Subject: Re: [PATCH v4] x86_64/i386 fenv: Replace symlink with include fenv_stub.c To: Newlib Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020/txt/msg00106.txt Thank you for hanging in on this one. --joel On Tue, Feb 25, 2020 at 9:44 AM Corinna Vinschen wrote: > On Feb 25 07:38, Joel Sherrill wrote: > > Having symlinks for these files led to an issue reported to the RTEMS > > Project that showed up using some tar for native Windows to unpack the > > newlib sources. It creates symlinks in the tar file as copies of the > > files the symlinks point to. If the links appear in the tar file before > > the source exists, it cannot copy the file. > > > > The solution in this patch is to convert the files that are symbolic > > links into simple files which include the file they were linked to. > > This should be more portable and avoids the symbolinc link problem. > > --- > > newlib/libm/machine/i386/feclearexcept.c | 8 +++++++- > > newlib/libm/machine/i386/fegetenv.c | 8 +++++++- > > newlib/libm/machine/i386/fegetexceptflag.c | 8 +++++++- > > newlib/libm/machine/i386/fegetround.c | 8 +++++++- > > newlib/libm/machine/i386/feholdexcept.c | 8 +++++++- > > newlib/libm/machine/i386/fenv.c | 8 +++++++- > > newlib/libm/machine/i386/feraiseexcept.c | 8 +++++++- > > newlib/libm/machine/i386/fesetenv.c | 8 +++++++- > > newlib/libm/machine/i386/fesetexceptflag.c | 8 +++++++- > > newlib/libm/machine/i386/fesetround.c | 8 +++++++- > > newlib/libm/machine/i386/fetestexcept.c | 8 +++++++- > > newlib/libm/machine/i386/feupdateenv.c | 8 +++++++- > > newlib/libm/machine/x86_64/feclearexcept.c | 8 +++++++- > > newlib/libm/machine/x86_64/fegetenv.c | 8 +++++++- > > newlib/libm/machine/x86_64/fegetexceptflag.c | 8 +++++++- > > newlib/libm/machine/x86_64/fegetround.c | 8 +++++++- > > newlib/libm/machine/x86_64/feholdexcept.c | 8 +++++++- > > newlib/libm/machine/x86_64/feraiseexcept.c | 8 +++++++- > > newlib/libm/machine/x86_64/fesetenv.c | 8 +++++++- > > newlib/libm/machine/x86_64/fesetexceptflag.c | 8 +++++++- > > newlib/libm/machine/x86_64/fesetround.c | 8 +++++++- > > newlib/libm/machine/x86_64/fetestexcept.c | 8 +++++++- > > newlib/libm/machine/x86_64/feupdateenv.c | 8 +++++++- > > 23 files changed, 161 insertions(+), 23 deletions(-) > > mode change 120000 => 100644 newlib/libm/machine/i386/feclearexcept.c > > mode change 120000 => 100644 newlib/libm/machine/i386/fegetenv.c > > mode change 120000 => 100644 newlib/libm/machine/i386/fegetexceptflag.c > > mode change 120000 => 100644 newlib/libm/machine/i386/fegetround.c > > mode change 120000 => 100644 newlib/libm/machine/i386/feholdexcept.c > > mode change 120000 => 100644 newlib/libm/machine/i386/fenv.c > > mode change 120000 => 100644 newlib/libm/machine/i386/feraiseexcept.c > > mode change 120000 => 100644 newlib/libm/machine/i386/fesetenv.c > > mode change 120000 => 100644 newlib/libm/machine/i386/fesetexceptflag.c > > mode change 120000 => 100644 newlib/libm/machine/i386/fesetround.c > > mode change 120000 => 100644 newlib/libm/machine/i386/fetestexcept.c > > mode change 120000 => 100644 newlib/libm/machine/i386/feupdateenv.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/feclearexcept.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/fegetenv.c > > mode change 120000 => 100644 > newlib/libm/machine/x86_64/fegetexceptflag.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/fegetround.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/feholdexcept.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/feraiseexcept.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/fesetenv.c > > mode change 120000 => 100644 > newlib/libm/machine/x86_64/fesetexceptflag.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/fesetround.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/fetestexcept.c > > mode change 120000 => 100644 newlib/libm/machine/x86_64/feupdateenv.c > > Pushed. > > > Thanks, > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat >