From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by sourceware.org (Postfix) with ESMTPS id 655F33850438 for ; Thu, 17 Jun 2021 21:52:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 655F33850438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-f171.google.com with SMTP id x14so11105203ljp.7 for ; Thu, 17 Jun 2021 14:52:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:from:date:message-id :subject:to; bh=3VRBjXTSvPID4pnWloJ2SA2VTHnlRs6Qba3yhS0akgk=; b=a6qOyY0RJ9rni6xWYq5OicXLdV4LLNEjqnwjlFDZ6xYricgufJ/Wfvad6XUWTcW1fg 5Snqy5sqpKiIipwUY6O4NLF6OkqJQVJYgzVgFnBPXvtJAd60DxgCHaqTh/M6x9c4BBhO vh17RhIhL3tl4vSc1Cg/4w2stAyI0uJMfmUKhtDCLlTZIbZP4N0etIc70iU1MsmobPCn EE8Yx1N1Hy4YKoSWDmv4KtA0C/Y0SCGr2vEYMHyyFZ2P8agyGxlZj9mDObB6LcdX/O95 0Xmj/OMjAvJa8PKPALCyLNQ6a65ILoJV6uVto/50J8pryYs+IcVOW1MRsIPaHwU1IZLp 38lw== X-Gm-Message-State: AOAM532g0GoCRdd6RbVLkcIJVJ/ueiDDsie4jABZO8WKN0zfWYr9lMQB Gq25+Zk7FNJrT/+ZmrQMYbnOj1BYzpVcnQ== X-Google-Smtp-Source: ABdhPJxeE2r+SY6BiCxH/8oe03WJ8twyIOXdUBGrJ9HUuYzphcbsxuA+X7zIBBjD6sxAiRu9fH05pA== X-Received: by 2002:a2e:9ad0:: with SMTP id p16mr6491590ljj.133.1623966733777; Thu, 17 Jun 2021 14:52:13 -0700 (PDT) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com. [209.85.208.180]) by smtp.gmail.com with ESMTPSA id l22sm795760ljh.64.2021.06.17.14.52.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 14:52:13 -0700 (PDT) Received: by mail-lj1-f180.google.com with SMTP id 131so11134895ljj.3 for ; Thu, 17 Jun 2021 14:52:13 -0700 (PDT) X-Received: by 2002:a2e:6819:: with SMTP id c25mr6688389lja.140.1623966733420; Thu, 17 Jun 2021 14:52:13 -0700 (PDT) MIME-Version: 1.0 Reply-To: joel@rtems.org From: Joel Sherrill Date: Thu, 17 Jun 2021 16:52:02 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: makedoc.c: Warning when -Wall To: Newlib X-Spam-Status: No, score=-3031.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 21:52:16 -0000 Hi I noticed in tbe build output that makedoc.c is compiled without -Wall. I'm not sure how to add that to the Makefile but when I built it by hand, it turned up this single warning. I am not sure where the parentheses should go to address the warning and ensure this is doing what's intended. It doesn't help that I don't know what the intent is. :). ../newlib-cygwin/newlib/doc/makedoc.c: In function =E2=80=98courierize=E2= =80=99: ../newlib-cygwin/newlib/doc/makedoc.c:574:6: warning: suggest parentheses around =E2=80=98&&=E2=80=99 within =E2=80=98||=E2=80=99 [-Wparentheses] && (at(tos, idx+1) =3D=3D '.') ^ Thanks. --joel