From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by sourceware.org (Postfix) with ESMTPS id ECF5E3857C68 for ; Sat, 13 Mar 2021 20:05:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ECF5E3857C68 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joel.sherrill@gmail.com Received: by mail-lj1-f173.google.com with SMTP id 16so11586204ljc.11 for ; Sat, 13 Mar 2021 12:05:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=z2dLZkR8LBbFRjoSPq0bp66tcbmrw4D+YeB8ech90/Y=; b=hF8UEOqebFdTYHgIaJ0UQ9t4wbtIK/0T5gYr3vmtgy7nmMNOEhdrM7D+Sk9S72RDD9 01Ml8q/w7xJ6ioj60BHRkKyhol8JUbE90/BxWPeRWM1dRuEJw7XiVnqKpzXbIT1cjSBl XX0s4vMkV8i6kZEOHNapHw2SORU4ZUXhm7SVoIxcwuMzWNAkgEKjjbQzP6KjxHJg/nDD 8/QpLKFl53srzsrITsmf9JTXgiu/rfzXhLSXte8rzKx4peGfEpP7fr66UvG7ciZwFdFf 9Rg6sGicrmSkiuzybroiNCE8cQHRloG/3M80aC10U8Twtb9CX4GYj8cuPMphThwfotGc KPbQ== X-Gm-Message-State: AOAM531BKdRxhwKj+jRh9FIDbHWnFWXOBchNlebWE1zOvuSdC3W249lf e/Dg0Yo0gmuCLnbBAsrvzVWXwgwSdno= X-Google-Smtp-Source: ABdhPJzwrAPIsX9B/5o42K/MHjHPMi0pX+Nh6fRhr6qcc83ng2QEUiUNIGjmydT1m+JW1IEBbQ8xhQ== X-Received: by 2002:a2e:1649:: with SMTP id 9mr6270621ljw.74.1615665912256; Sat, 13 Mar 2021 12:05:12 -0800 (PST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id k6sm2119994lfg.28.2021.03.13.12.05.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Mar 2021 12:05:12 -0800 (PST) Received: by mail-lj1-f177.google.com with SMTP id f16so11577386ljm.1 for ; Sat, 13 Mar 2021 12:05:12 -0800 (PST) X-Received: by 2002:a2e:b6d4:: with SMTP id m20mr6126818ljo.448.1615665911975; Sat, 13 Mar 2021 12:05:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Reply-To: joel@rtems.org From: Joel Sherrill Date: Sat, 13 Mar 2021 14:05:00 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim To: David Macek Cc: Newlib , Corinna Vinschen X-Spam-Status: No, score=-3031.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2021 20:05:16 -0000 On Sat, Mar 13, 2021, 12:11 PM David Macek via Newlib wrote: > > > More to the point, how big of an issue would be to duplicate the file? > > > > I'm not hot on duplicating an identical file, it just raises maintenance > > cost. I'm currently looking into a solution to share the file without > > duplicating it. > > Something like a Makefile rule? > The include file set for newlib already merges files from multiple directories in a specific order and I recall (maybe incorrectly) that they aren't merged during the build but the include path is carefully managed. Is there a place put a shared file and have a one liner in both targets? The problem I see here is that this is an odd case where two architectures share the same code and you need a common include directory. For RTEMS, this isn't unusual and our build system accounts for this well. But this is an outlier for newlib. Maybe a mix of a unique shared filename that is included and a secondary machine directory being added to the include processing. Just thinking out loud. There is an overarching pattern to how the shared, machine, and system include directories are processed and I think any solution to avoid symbolic links across architectures is going to have to account for that. --joel > > -- > David Macek >