From: Joel Sherrill <joel@rtems.org>
To: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH v2] aarch64: Remove duplicated optimized memmove()
Date: Mon, 20 Nov 2023 15:15:59 -0600 [thread overview]
Message-ID: <CAF9ehCXiGY+KLTUO3JcnW09bPp5zAUQ8PsBL6QEQsrUP5vQfJw@mail.gmail.com> (raw)
In-Reply-To: <ZVu8QMgbPYgpJmux@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Mon, Nov 20, 2023, 2:06 PM Corinna Vinschen <vinschen@redhat.com> wrote:
> On Nov 20 15:38, Sebastian Huber wrote:
> > On 27.10.23 20:18, Sebastian Huber wrote:
> > > The optimized aarch64/memcpy.S already provides a memmove()
> implementation.
> > > ---
> > >
> > > v2: Rename memmove-stub.c in memmove.c to make the build system happy.
> >
> > Any objections to commit this change?
>
> Usually we wait for feedback from the arm guys if arm code is affected,
> but I guess this should be ok.
>
This is really just to account for the newlib build system assuming machine
specific methods override at the file name level. This fixes where two
methods were in the same assembly file but it didn't override the default
of one of them.
I don't think the arm guys care about newlib build machinery. :)
--joel
>
>
> Corinna
>
>
prev parent reply other threads:[~2023-11-20 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 18:18 Sebastian Huber
2023-10-27 19:00 ` Joel Sherrill
2023-11-01 19:21 ` Joel Sherrill
2023-11-20 14:38 ` Sebastian Huber
2023-11-20 20:06 ` Corinna Vinschen
2023-11-20 21:15 ` Joel Sherrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF9ehCXiGY+KLTUO3JcnW09bPp5zAUQ8PsBL6QEQsrUP5vQfJw@mail.gmail.com \
--to=joel@rtems.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).