From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by sourceware.org (Postfix) with ESMTPS id 00713385C405 for ; Wed, 28 Jul 2021 19:42:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00713385C405 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f43.google.com with SMTP id r26so6127516lfp.5 for ; Wed, 28 Jul 2021 12:42:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to; bh=ppxQKULU2z1PGJ7K0N88dSNR7cS4j3aI9AbterxljHc=; b=TlsgjrJL9itE1ILDVXvE6cvZmyxKfB/vM075bRBHBMUKhqWQeMUNZwHcxnQRRm/F8K tVnym8ZIaUGxWOOpUQCppMW8+Q1ciAcLyXNqJwr2OixqntMEf3l0V82u0InmfOVzDYeZ fY7enjiunT7AK7eVcLlOqJW6Rz2He5ck9IEfW9kizx8aF53CjME4gHu2+UoQg7CR66xf SeIHiXhdNFE8eIf2EPYKMPeQIaCJuzonQ9gpAc0rG7GU1o21WI199upqgj2PrS5q0MpG 2+t3k+hn8sl7krf+xWExGKRjvqDwdvZQhxIEDx1083+1h4yprAiDRji/IBev2+J7gp6c OOvw== X-Gm-Message-State: AOAM533UD1RjaMUJuxHFVg7NCDgjh5DezTGNrUAr6g4hPRNbVhrPR09e BdGEMju7EeJ8GDZxMl6NuhOgFf+/xNsqgw== X-Google-Smtp-Source: ABdhPJynqc8aHdbnvcMnVzhLGsMI9fGmVSHm1cqPkSSkMNTVgoXNJrVFUmPC5UNe6GymybnT++ix8A== X-Received: by 2002:a19:6e01:: with SMTP id j1mr878564lfc.407.1627501336618; Wed, 28 Jul 2021 12:42:16 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id y25sm80987lfe.276.2021.07.28.12.42.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 12:42:16 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id r17so6130110lfe.2 for ; Wed, 28 Jul 2021 12:42:16 -0700 (PDT) X-Received: by 2002:ac2:532d:: with SMTP id f13mr863375lfh.123.1627501335934; Wed, 28 Jul 2021 12:42:15 -0700 (PDT) MIME-Version: 1.0 References: <20210724083730.16959-1-mfjoyce2004@gmail.com> <20210724083730.16959-2-mfjoyce2004@gmail.com> <57f33efa-2450-ac5c-3ceb-be8beb183ca5@SystematicSw.ab.ca> In-Reply-To: Reply-To: joel@rtems.org From: Joel Sherrill Date: Wed, 28 Jul 2021 14:42:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] libc: Added implementations and prototypes for To: Newlib , Brian Inglis Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3031.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 19:42:20 -0000 On Wed, Jul 28, 2021 at 1:46 PM Corinna Vinschen wrote: > > On Jul 28 09:25, Brian Inglis wrote: > > On 2021-07-28 03:11, Corinna Vinschen wrote: > > > Hi Matt, > > > > > > thanks for this v2. > > > > > > On Jul 24 10:37, Matt Joyce wrote: > > > > Added implementations for sig2str() and str2sig() in libc/signal in order > > > > to improve POSIX compliance. Added function prototypes to sys/signal.h. > > > > Added Makefile.am entries to build the new file. > > > > --- > > > > [...] > > > > +#if __GNU_VISIBLE > > > > > > I think this needs discussion. The sig2str/str2sig API has not been > > > provided yet by GLibC. Using __GNU_VISIBLE in this context looks wrong. > > > What we need, in fact, is a __POSIX_VISIBLE guard, but here's the > > > problem: As far as I can see, the Issue 8 draft does not yet define a > > > version number. > > > > > > If anybody has better information or a good idea how to guard this new > > > API in the meantime, I'm all ears. > > > > Current values are: > > > > __POSIX_VISIBLE 199009 > > __POSIX_VISIBLE 199209 > > __POSIX_VISIBLE 199309 > > __POSIX_VISIBLE 199506 > > __POSIX_VISIBLE 200112 > > __POSIX_VISIBLE 200809 > > __POSIX_VISIBLE 201402 > > > > and anticipated release date is 2022 from FAQ > > > > https://www.opengroup.org/austin/faq.html > > > > Q8. Where is the schedule for draft development? > > > > so could use: > > > > __POSIX_VISIBLE >= 202202 /* FIXME when POSIX Issue 8 released */ > > Did you mean 202201? Sounds like a good idea in theory. But consider a > project actually using this value and then the POSIX release defines the > value 202207 or so. The project might stop to compile correctly. Along > these lines, using 202212 for the interim might be the better approach. > Then again, what if the release occurs in 2023 only? > > Still pretty unsure, Me too. I told Matthew early on that the header guard for this was going to require discussion because I had no idea what was right. It would be nice to have this available on multiple platforms. Would it be acceptable to make the header conditional on Cygwin and RTEMS for now? Can we conditionalize the C file for just those two? Does newlib have a ticketing/PR system? If so, we could revisit this when Issue 8 is released. Alternatively, we can file a ticket in Cygwin and RTEMS and see which one of us remembers it first after Issue 8 is out. I know if we tag a ticket with the next release, it should get reviewed as we start cleaning up as the code gets slushier. --joel > Corinna >