From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by sourceware.org (Postfix) with ESMTPS id 0A0783858D1E for ; Sun, 14 Jan 2024 16:00:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A0783858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A0783858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.161.48 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705248015; cv=none; b=BR5E8bYOD5DNnbQwtXi4WJkmvwuulQpb7mxEqUCKiiTV8v30XjAlHL/2U7IPfQqvd1ULRDjzIhBz2MK3Kk2ZXF5CeCgCsJucnOku/Gb2pqCtIhG8OGvTxZ1LQVd2LMukQzVTND9PT9FQzT9uMqXzxvYy96m7MyowEXgoH2QR0cw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705248015; c=relaxed/simple; bh=tGMDHX8s4GKYYVeLtuGcjQBtgMSS06i+O44EQxBOJkA=; h=MIME-Version:From:Date:Message-ID:Subject:To; b=LumArV6XvNP8dEZb3I8tJid2FsltGbQhSGsytsAty+5hpCxs3+iR6+wCmQppO/2qrS//Aka3Sr0UzqvIDU5BHM+n3cpZoLuVndcLZJkb+8Fd3T73O+DVkC3u3NKXOD5NXxnVwCDxZHKxJkq91fyfb0Se1mCpU9EErzFvDO3M/Oc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-598e07d9e9fso429135eaf.0 for ; Sun, 14 Jan 2024 08:00:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705248010; x=1705852810; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ED9fvBxCJ/Sw6bZhqLQ5VHx0vWNCvN0rw/fmnCWAVAo=; b=GOYPm+aQRcKy0m2ZoDAMhAen180388nnkxBCe/qlYITdGcMa3qp+Yqpnr+62AQ6Yfc dUcwZkjHgzIej1AC4Wkne7lEZ7juybiafY1b0YBqTALz68mCNMr82dhSerqmFvRkwYhS wkUONUpnPr02qMJi9nDuLUuEYPCAt/nCMorZqub9opUCY41z4WDiLQyjusiN8BXFLhkx wyEGzash7lVi9p+If8SNjnuNr4rCjar5wH969dQTdG57mBS3t/ezyFU8IWJ29RK2Zyu2 IqiVSnmx7HByREKtLv/FM/GtNDp9oKNBL0BDXconXmjGNluQMjgTjcT46M/pbFDO4Kkq 4WXA== X-Gm-Message-State: AOJu0YyznGMrZg1CGCmeUvw5jCG9nozaVkzLmfsDGmoY2D7SSrlfqQAO Mja4FbUJKekYX2pF+BmdLnUW/rnN6uQ= X-Google-Smtp-Source: AGHT+IEgcS40rCHaTj9WQvY1lfMLhNP7TLnU8g8m4TjUzNb/lkmnrCBkYhMEO91oCn23zBQxVvBC8Q== X-Received: by 2002:a05:6820:16a6:b0:598:a9e7:d1c3 with SMTP id bc38-20020a05682016a600b00598a9e7d1c3mr1799872oob.14.1705248009567; Sun, 14 Jan 2024 08:00:09 -0800 (PST) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com. [209.85.167.176]) by smtp.gmail.com with ESMTPSA id n8-20020a4abd08000000b00598e32ad8b5sm464878oop.22.2024.01.14.08.00.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jan 2024 08:00:09 -0800 (PST) Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3bd489d75b7so2183261b6e.0 for ; Sun, 14 Jan 2024 08:00:09 -0800 (PST) X-Received: by 2002:a05:6808:1245:b0:3bc:347a:5519 with SMTP id o5-20020a056808124500b003bc347a5519mr3258169oiv.117.1705248009081; Sun, 14 Jan 2024 08:00:09 -0800 (PST) MIME-Version: 1.0 References: <20240114154727.2980243-1-mikpelinux@gmail.com> In-Reply-To: <20240114154727.2980243-1-mikpelinux@gmail.com> Reply-To: joel@rtems.org From: Joel Sherrill Date: Sun, 14 Jan 2024 09:59:57 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [BUG] newlib-4.4.0 fails to build for m68k-elf To: Mikael Pettersson Cc: newlib@sourceware.org Content-Type: multipart/alternative; boundary="000000000000d5dd7f060ee9fdac" X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d5dd7f060ee9fdac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 14, 2024 at 9:47=E2=80=AFAM Mikael Pettersson wrote: > Building newlib-4.4.0 for m68k-unknown-elf fails with > > m68k-unknown-elf-gcc -B/tmp/objdir/m68k-unknown-elf/newlib/ -isystem > /tmp/objdir/m68k-unknown-elf/newlib/targ-include -isystem > /tmp/newlib-4.4.0.20231231/newlib/libc/include > -B/tmp/objdir/m68k-unknown-elf/libgloss/m68k > -L/tmp/objdir/m68k-unknown-elf/libgloss/libnosys > -L/tmp/newlib-4.4.0.20231231/libgloss/m68k -g -O2 -O2 -I. > -I/tmp/newlib-4.4.0.20231231/libgloss/m68k/.. -I./.. -idirafter > /tmp/newlib-4.4.0.20231231/libgloss/m68k/../../include -c -g -O2 > /tmp/newlib-4.4.0.20231231/libgloss/m68k/../read.c > /tmp/newlib-4.4.0.20231231/libgloss/m68k/../read.c:24:1: error: > conflicting types for 'read'; have 'int(int, void *, size_t)' {aka > 'int(int, void *, long unsigned int)'} > 24 | read (int fd, > | ^~~~ > In file included from > /tmp/newlib-4.4.0.20231231/newlib/libc/include/unistd.h:4, > from > /tmp/newlib-4.4.0.20231231/libgloss/m68k/../glue.h:16, > from > /tmp/newlib-4.4.0.20231231/libgloss/m68k/../read.c:15: > /tmp/newlib-4.4.0.20231231/newlib/libc/include/sys/unistd.h:179:25: note: > previous declaration of 'read' with type '_ssize_t(int, void *, size_t)' > {aka 'long int(int, void *, long unsigned int)'} > 179 | _READ_WRITE_RETURN_TYPE read (int __fd, void *__buf, size_t > __nbyte); > | ^~~~ > Per https://pubs.opengroup.org/onlinepubs/009604599/functions/read.html, read() returns ssize_t. It looks like READ_WRITE_RETURN_TYPE should be ssize_t. --joel > make[4]: *** [Makefile:528: read.o] Error 1 > make[4]: Leaving directory '/tmp/objdir/m68k-unknown-elf/libgloss/m68k' > make[3]: *** [Makefile:4954: all-recursive] Error 1 > make[3]: Leaving directory '/tmp/objdir/m68k-unknown-elf/libgloss' > make[2]: *** [Makefile:1225: all] Error 2 > make[2]: Leaving directory '/tmp/objdir/m68k-unknown-elf/libgloss' > make[1]: *** [Makefile:9528: all-target-libgloss] Error 2 > make[1]: Leaving directory '/tmp/objdir' > make: *** [Makefile:879: all] Error 2 > > Toolchain built from binutils-2.41 and gcc-13.2.0. > > newlib-4.3.0 built fine, the issue started with: > > # first new commit: [3d10b04f1ed9bf53c282081c88165951e8c32cec] Fix various > c99/gcc-14 issues in generic libgloss code > --000000000000d5dd7f060ee9fdac--