From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by sourceware.org (Postfix) with ESMTPS id 476D03858D28 for ; Thu, 6 Apr 2023 14:07:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 476D03858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-5491fa028adso245117837b3.10 for ; Thu, 06 Apr 2023 07:07:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680790030; x=1683382030; h=to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cuBzq78eNRRrZ4KLeRqBcXJIZDQje1VowWVx3x/17Yw=; b=4+1OqbhuX/q27NhNLZAr/6f+rSJF8dQCp8XA8utdUe1pFQTuw4+xsvoNTzuG6DwqtC EJ7qyuGT6JBK4QZEyLS6eRRquhzwu9619k1wyjDaQCNAxWjQGQ/ymlKZYsdpONB0ECoG GaFCuP5xQanpIMeMGw6DBs4SfXMLcU5CebrkrspKq4X3Lb9xwgDy7VNm6H7oOkijYAWD HSu/ERxtG6D6KLqAWgJo/OYcS7MqfTHalfeilkkzcObqKUOAaOpc1wKTFa2fzTdLu+fQ O6okpdUKju3b+gx/hI3Peaq63Ju08RiC9m6f8o7lCK+wgYDvlVcq0bRR8NactWczNAts I7Ww== X-Gm-Message-State: AAQBX9ftFtMnt+J1hAPACN137fSDyhlnHlfAiX3gHfkBmdlSJeeBbX2R Jc9GqlQ605J9mM5KyhA5A4FjnpXQQ2g= X-Google-Smtp-Source: AKy350ZYpNi+pshCJNVb5ab9bcVBL7B0lr94ke4EysgbcBOqaHJixMLkllup37+8wM3MhdAYGuQtdQ== X-Received: by 2002:a0d:cc09:0:b0:54c:db3:f95c with SMTP id o9-20020a0dcc09000000b0054c0db3f95cmr1407597ywd.33.1680790030318; Thu, 06 Apr 2023 07:07:10 -0700 (PDT) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id e7-20020a811e07000000b00545f2dbe3a2sm333423ywe.34.2023.04.06.07.07.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 07:07:10 -0700 (PDT) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-54c0c86a436so41387867b3.6 for ; Thu, 06 Apr 2023 07:07:09 -0700 (PDT) X-Received: by 2002:a81:4506:0:b0:545:1d7f:abfe with SMTP id s6-20020a814506000000b005451d7fabfemr5506729ywa.7.1680790029455; Thu, 06 Apr 2023 07:07:09 -0700 (PDT) MIME-Version: 1.0 References: <20230403205837.1595602-1-jennifer.averett@oarcorp.com> In-Reply-To: Reply-To: joel@rtems.org From: Joel Sherrill Date: Thu, 6 Apr 2023 09:06:57 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3]: Add math support for non LDBL_EQ_DBL architecture To: newlib@sourceware.org, Joel Sherrill , Jennifer Averett Content-Type: multipart/alternative; boundary="000000000000a5d6c905f8ab6c24" X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000a5d6c905f8ab6c24 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 6, 2023 at 4:00=E2=80=AFAM Corinna Vinschen wrote: > On Apr 5 10:44, Joel Sherrill wrote: > > On Wed, Apr 5, 2023 at 4:23=E2=80=AFAM Corinna Vinschen > wrote: > > > I noticed that you exclude Cygwin from the new code, which makes sense > > > as long as we provide our own long double math taken from Mingw-w64. > > > > What needs to happen for Cygwin/Mingw_w64? Honestly, we didn't discuss > > that at all. > > Not sure I understand the question. After the patch, Cygwin should > just still work. Mingw-w64 isn't supported by newlib. What do you > mean? > I was just worried there was something special we needed to account for that we didn't. I'm glad we didn't miss anything there. No worries. :) > > > > However, there's something not quite right. When trying to build I g= et > > > symbol conflicts for the fdim{f,l} and scalbln{f,l} symbols in the li= nk > > > stage (paths shortend for readability): > > > [...] > > > > We chatted and those will be fixed in the next round. > > Thanks. > > > Anything else you think needs tidying up? > > Well, yes. The patch introduces a new header . Cygwin > already maintains an header, as on Linux. > > The way we install header files is that first, the newlib headers are > installed, and then, second, Cygwin headers are installed, thus > overriding newlib headers with Cygwin headers as required. We have to > maintain for userspace compatibility, but after the > installation user will find two different versions of endian.h, > one in /usr/include, one in /usr/include/sys. > > Would it make a lot of problems to move to ? > Probably not. Just a matter of the final being a proper union of the two. It's just software after all. --joel > > > Thanks, > Corinna > > > --000000000000a5d6c905f8ab6c24--