From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119417 invoked by alias); 12 Nov 2015 10:05:55 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 119404 invoked by uid 89); 12 Nov 2015 10:05:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f181.google.com Received: from mail-ig0-f181.google.com (HELO mail-ig0-f181.google.com) (209.85.213.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 12 Nov 2015 10:05:53 +0000 Received: by igvg19 with SMTP id g19so11241151igv.1 for ; Thu, 12 Nov 2015 02:05:51 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.50.4.65 with SMTP id i1mr15148540igi.0.1447322751668; Thu, 12 Nov 2015 02:05:51 -0800 (PST) Received: by 10.107.41.1 with HTTP; Thu, 12 Nov 2015 02:05:51 -0800 (PST) In-Reply-To: <8473a04381ff7d35caa7ea1e8eb08772@labapart.com> References: <8473a04381ff7d35caa7ea1e8eb08772@labapart.com> Date: Thu, 12 Nov 2015 11:17:00 -0000 Message-ID: Subject: Re: Building newlib for Cortex-M with LLVM From: Marcus Shawcroft To: Olivier MARTIN Cc: Newlib Mailing List Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015/txt/msg00796.txt.bz2 On 11 November 2015 at 23:16, Olivier MARTIN wrote: > * The first one can be solved. The space in the call of CONCAT2(a, b) by > CONCAT() is propagated into the subsequent calls. It means when the strings > 'a' and 'b' are concatenated, the space is inserted between both strings - > which is not the expected behaviour. > > The fix would be: > > --- a/newlib/libc/machine/arm/setjmp.S > +++ b/newlib/libc/machine/arm/setjmp.S > @@ -3,7 +3,7 @@ > Nick Clifton, Cygnus Solutions, 13 June 1997. */ > > /* ANSI concatenation macros. */ > -#define CONCAT(a, b) CONCAT2(a, b) > +#define CONCAT(a, b) CONCAT2(a,b) Have you looked at the C standard on this issue? I wonder which compiler, gcc or clang is not compliant with the standard. Cheers /Marcus