From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 835FF3857812 for ; Sun, 7 Mar 2021 15:04:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 835FF3857812 Received: by mail-ot1-x330.google.com with SMTP id j22so886731otp.2 for ; Sun, 07 Mar 2021 07:04:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=CEc1kbIZ+z8zRFBCGghVC4Y1s6Z64hkp3EYY4HjIH3g=; b=gMODPhLtTtSAUGBU+MGO3CZE5VMAysiaEhIEysslwcFpCWLriC+m+KRNQeJ09w/VUY PfNq3rj0uxrlVfIOfMUSgLhhe7fitJbAzsNSJzIX5Ni+cLrbBNIhuYXiKe16qcjao4BL GZTF7vF2/BG/86xY8NXb3qYvZvTY+l20H/2nG8U8MxWD4eQxc348FYrLaxqCsxt3Yw/n C80PSa8Wc0FLMpuzbp0PZHx6bTxTxE3ONdKJZpZxylYsH4dq9zWSJoea1jXBMwPZ4glP OkKEBYss0zbDXGWhaSvmRNALbb7b/X6hdeKYLNmg8vvhyBv7jKxztxaCEH4/k4C55fs+ HtRg== X-Gm-Message-State: AOAM533oxliO6GgKVAz7idN/1ElQGcWums0SkjyKYY6G7Bl/OkGrekRI qAtcU2qFMjW6D3TfnsX1zm8IWHCGttC+CzypC22/Clg64oQ= X-Google-Smtp-Source: ABdhPJwkgccENxW6dLuBg4okIuvLKq4p1cK2HDUV2HR0Y1eUbuvyf2iEYWTNTQ+XBt2RaF7b2GVux7VB0v4GiMEhNVE= X-Received: by 2002:a9d:3b86:: with SMTP id k6mr16105657otc.194.1615129446012; Sun, 07 Mar 2021 07:04:06 -0800 (PST) MIME-Version: 1.0 From: David Macek Date: Sun, 7 Mar 2021 16:03:54 +0100 Message-ID: Subject: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim To: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Mar 2021 15:04:07 -0000 As in fbaa096772f77be664864d80508906ad018cc23b: Having symlinks leads to issue unpacking the sources on platforms without proper symlink support. These platforms mostly extract symlinks from the archive file as copies of the files the symlinks point to. If the links appear in the tar file before the source exists, it cannot copy the file. The solution in this patch is to convert the files that are symbolic links into simple files which include the file they were linked to. This should be more portable and avoids the symbolic link problem. Signed-off-by: David Macek --- Excuse my ignorance, but is this acceptable? I'm not sure what actually happens with these files, but it'd be nice to get rid of the last symlink in the repo. newlib/libc/machine/i386/sys/fenv.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) mode change 120000 => 100644 newlib/libc/machine/i386/sys/fenv.h diff --git a/newlib/libc/machine/i386/sys/fenv.h b/newlib/libc/machine/i386/sys/fenv.h deleted file mode 120000 index 218057825e..0000000000 --- a/newlib/libc/machine/i386/sys/fenv.h +++ /dev/null @@ -1 +0,0 @@ -../../x86_64/sys/fenv.h \ No newline at end of file diff --git a/newlib/libc/machine/i386/sys/fenv.h b/newlib/libc/machine/i386/sys/fenv.h new file mode 100644 index 0000000000..d2c41a6d5a --- /dev/null +++ b/newlib/libc/machine/i386/sys/fenv.h @@ -0,0 +1,5 @@ +/* + * SPDX-License-Identifier: BSD-2-Clause + */ + +#include "../../x86_64/sys/fenv.h" -- David Macek