From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by sourceware.org (Postfix) with ESMTPS id 3EBE0387085A for ; Thu, 11 Mar 2021 07:14:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3EBE0387085A Received: by mail-oo1-xc2f.google.com with SMTP id c12-20020a4ae24c0000b02901bad05f40e4so446645oot.4 for ; Wed, 10 Mar 2021 23:14:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NwapYu8poWtaYfhf7kVgZWjFBXovBajzeyelqkQZAtk=; b=JlLV6Iqdx9hh8mqiL1kY1RyFNszrI0nHoRISPv1AD94ZB6yTVUEN9O5gX4hccGvtw9 uOw/f0oKIaG/t2WiA2TuFQgYICAg5mijUCAWHiY1zGdJWpSFJqIv8+q8h4Mmpu6ibWZp QJ2nED6Ets9YKbV+wPFplj+5ob+7keQNkcYF4HWb7f5+67nC8GqSF4q//C/Hy8e/00+v hhAg0TRC/gnoa2O94ZQ31pMnAy+AyYw+mAwLzhDy8qL9SkOEz+IBWxYNtzqCXtcTNaIY aYXOmtsao3M4xlMX2Vd5xRpdLHRn+cZEeFsg0Jw2ld/0vs2UuA6CpSSNw/vsOMyoZ1ZG fYrw== X-Gm-Message-State: AOAM5331HARU9TGuNwF+eMW9otmrXAYMDFhuxB2MXggyavGmYdHciane 6PlTA/HrUkn8yTU6SO2HjQfW09WF3BihrLEXFePV3Zhd X-Google-Smtp-Source: ABdhPJyIqX5gUgVCEQPaJWr3AAzJhwBkuETAaEW3MqKimgClW2b2kwy90bBrTYLx5CFfsS0dGcGqnFrJi9n0QQepypY= X-Received: by 2002:a4a:37c5:: with SMTP id r188mr5538066oor.77.1615446849592; Wed, 10 Mar 2021 23:14:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Macek Date: Thu, 11 Mar 2021 08:13:57 +0100 Message-ID: Subject: Re: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim To: newlib@sourceware.org Cc: Corinna Vinschen Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 07:14:11 -0000 > > > This doesn't work. The machine-specific header will get installed to > > > $DESTDIR/usr/include/sys/fenv.h, and it will now include a non-existing > > > file. We have to keep the symlink or to duplicate the file. > > > > How come the newlib/libm/machine/i386/fenv.c non-symlink works? Is it > > installed differently? > > It's not installed at all. It's a source file so the include only has > to work at build time. The header file on the other hand will be > installed on the target. As such, the result has to work on the target. Ah, right. But then I'm confused how a symlink can work in the first place. I guess some part of the build process copies the contents instead of the file. More to the point, how big of an issue would be to duplicate the file? > > Coincidentally, is newlib/libc/machine/ft32/stpcmp.S file correct? > > I have no idea, you have to ask the guys knowing that chip type. I didn't read the instructions, it's just the label looks wrong. :) Should I start another thread? -- David Macek