From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id CD2263857C7C for ; Wed, 23 Sep 2020 09:23:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CD2263857C7C Received: by mail-ot1-x331.google.com with SMTP id m13so13823561otl.9 for ; Wed, 23 Sep 2020 02:23:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0FWAVggmlKUZDsXq83c+FHKPVvIUZiYXgtTlLDmHASk=; b=GK+GUJHwsTHjwun9iG62kmeMCEBe7GI9ddoJYVvvbnfj6tvKwoMqP1VZTc1gw9YGIe 8Suxi2s0bDFWxIQ8Rjlumk4M36QmjH1WKzGe27bm8EGZVDv25kAyzBNeqgt0Zr+S6rqr O+/qcUsr8NuRKsnXB1kWmOGV9bz6E6jSaizNk7yJgb4Ibbm6oHLJOQCFNsbHpKNiQRX/ WVCJ3mXXjNbAGFa42dad3cJ9qC5ktT1gmASvwdKsWggv0ZJVJadr5UVNxqDEifg7tUh7 PRRGSjigqG6cIDVC+u59ll6UJFzX6/JPx0GcgI1aLoCnTrElHurUNebLV/niOZUv4N1Y KS2A== X-Gm-Message-State: AOAM533ztBXMTb6v8B698dtjBMWXS+VxPm4LbH0A7aggIaYDQE/xpzBe CkK3jMvTmOeH9OyC8VdRV245Cnp19dVQaoIXLJwK5w== X-Google-Smtp-Source: ABdhPJydDSJXRxF6dyVmqR5uCbQgQEZ4dTYXqeb1eVDLFvaJg8cRXUOfso/6V0Wg0cJKh7hm8RPCrjPH0GLnPie0E2U= X-Received: by 2002:a9d:4c97:: with SMTP id m23mr5560790otf.218.1600853002041; Wed, 23 Sep 2020 02:23:22 -0700 (PDT) MIME-Version: 1.0 References: <1600702161-13623-1-git-send-email-christophe.lyon@linaro.org> In-Reply-To: From: Christophe Lyon Date: Wed, 23 Sep 2020 11:23:10 +0200 Message-ID: Subject: Re: [PATCH] libc/include/math.h: Remove parameter name To: Jeff Johnston Cc: Newlib Content-Type: multipart/mixed; boundary="0000000000008669d805aff7a28b" X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 09:23:24 -0000 --0000000000008669d805aff7a28b Content-Type: text/plain; charset="UTF-8" On Wed, 23 Sep 2020 at 00:07, Jeff Johnston wrote: > > Hi Christophe, > > Can you please resend the patch as an attachment? > Sure, here it is. Christohe > Thanks, > > -- Jeff J. > > On Mon, Sep 21, 2020 at 11:29 AM Christophe Lyon via Newlib wrote: >> >> As discussed in GCC bug 97088 >> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in >> prototypes of library functions should use reserved names, or no name >> at all. >> >> This patch removes the 'x' parameter name from >> extern int __isinff (float); >> extern int __isinfd (double); >> extern int __isnanf (float); >> extern int __isnand (double); >> extern int __fpclassifyf (float); >> extern int __fpclassifyd (double); >> extern int __signbitf (float); >> extern int __signbitd (double); >> >> to avoid possible clashes with user code in case someone uses >> before including Newlib's math.h (or uses some other conflicting >> definition) >> --- >> newlib/libc/include/math.h | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h >> index 5e6155c..ba1a8a1 100644 >> --- a/newlib/libc/include/math.h >> +++ b/newlib/libc/include/math.h >> @@ -201,14 +201,14 @@ extern int isnan (double); >> # define math_errhandling (_MATH_ERRHANDLING_ERRNO | _MATH_ERRHANDLING_ERREXCEPT) >> #endif >> >> -extern int __isinff (float x); >> -extern int __isinfd (double x); >> -extern int __isnanf (float x); >> -extern int __isnand (double x); >> -extern int __fpclassifyf (float x); >> -extern int __fpclassifyd (double x); >> -extern int __signbitf (float x); >> -extern int __signbitd (double x); >> +extern int __isinff (float); >> +extern int __isinfd (double); >> +extern int __isnanf (float); >> +extern int __isnand (double); >> +extern int __fpclassifyf (float); >> +extern int __fpclassifyd (double); >> +extern int __signbitf (float); >> +extern int __signbitd (double); >> >> /* Note: isinf and isnan were once functions in newlib that took double >> * arguments. C99 specifies that these names are reserved for macros >> -- >> 2.7.4 >> --0000000000008669d805aff7a28b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-libc-include-math.h-Remove-parameter-name.patch" Content-Disposition: attachment; filename="0001-libc-include-math.h-Remove-parameter-name.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kff6jb0q0 RnJvbSA0NjgwYWNlY2FhYzZhMWJkMmY4ZGEwNmVkM2UzNDAzZThhNjZlZDQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RvcGhlIEx5b24gPGNocmlzdG9waGUubHlvbkBsaW5h cm8ub3JnPgpEYXRlOiBNb24sIDIxIFNlcCAyMDIwIDE1OjIyOjMwICswMDAwClN1YmplY3Q6IFtQ QVRDSF0gbGliYy9pbmNsdWRlL21hdGguaDogUmVtb3ZlIHBhcmFtZXRlciBuYW1lCgpBcyBkaXNj dXNzZWQgaW4gR0NDIGJ1ZyA5NzA4OAooaHR0cHM6Ly9nY2MuZ251Lm9yZy9idWd6aWxsYS9zaG93 X2J1Zy5jZ2k/aWQ9OTcwODgpLCBwYXJhbWV0ZXJzIGluCnByb3RvdHlwZXMgb2YgbGlicmFyeSBm dW5jdGlvbnMgc2hvdWxkIHVzZSByZXNlcnZlZCBuYW1lcywgb3Igbm8gbmFtZQphdCBhbGwuCgpU aGlzIHBhdGNoIHJlbW92ZXMgdGhlICd4JyBwYXJhbWV0ZXIgbmFtZSBmcm9tCmV4dGVybiBpbnQg X19pc2luZmYgKGZsb2F0KTsKZXh0ZXJuIGludCBfX2lzaW5mZCAoZG91YmxlKTsKZXh0ZXJuIGlu dCBfX2lzbmFuZiAoZmxvYXQpOwpleHRlcm4gaW50IF9faXNuYW5kIChkb3VibGUpOwpleHRlcm4g aW50IF9fZnBjbGFzc2lmeWYgKGZsb2F0KTsKZXh0ZXJuIGludCBfX2ZwY2xhc3NpZnlkIChkb3Vi bGUpOwpleHRlcm4gaW50IF9fc2lnbmJpdGYgKGZsb2F0KTsKZXh0ZXJuIGludCBfX3NpZ25iaXRk IChkb3VibGUpOwoKdG8gYXZvaWQgcG9zc2libGUgY2xhc2hlcyB3aXRoIHVzZXIgY29kZSBpbiBj YXNlIHNvbWVvbmUgdXNlcwpiZWZvcmUgaW5jbHVkaW5nIE5ld2xpYidzIG1hdGguaCAob3IgdXNl cyBzb21lIG90aGVyIGNvbmZsaWN0aW5nCmRlZmluaXRpb24pCi0tLQogbmV3bGliL2xpYmMvaW5j bHVkZS9tYXRoLmggfCAxNiArKysrKysrKy0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL25ld2xpYi9saWJjL2luY2x1 ZGUvbWF0aC5oIGIvbmV3bGliL2xpYmMvaW5jbHVkZS9tYXRoLmgKaW5kZXggNWU2MTU1Yy4uYmEx YThhMSAxMDA2NDQKLS0tIGEvbmV3bGliL2xpYmMvaW5jbHVkZS9tYXRoLmgKKysrIGIvbmV3bGli L2xpYmMvaW5jbHVkZS9tYXRoLmgKQEAgLTIwMSwxNCArMjAxLDE0IEBAIGV4dGVybiBpbnQgaXNu YW4gKGRvdWJsZSk7CiAjIGRlZmluZSBtYXRoX2VycmhhbmRsaW5nIChfTUFUSF9FUlJIQU5ETElO R19FUlJOTyB8IF9NQVRIX0VSUkhBTkRMSU5HX0VSUkVYQ0VQVCkKICNlbmRpZgogCi1leHRlcm4g aW50IF9faXNpbmZmIChmbG9hdCB4KTsKLWV4dGVybiBpbnQgX19pc2luZmQgKGRvdWJsZSB4KTsK LWV4dGVybiBpbnQgX19pc25hbmYgKGZsb2F0IHgpOwotZXh0ZXJuIGludCBfX2lzbmFuZCAoZG91 YmxlIHgpOwotZXh0ZXJuIGludCBfX2ZwY2xhc3NpZnlmIChmbG9hdCB4KTsKLWV4dGVybiBpbnQg X19mcGNsYXNzaWZ5ZCAoZG91YmxlIHgpOwotZXh0ZXJuIGludCBfX3NpZ25iaXRmIChmbG9hdCB4 KTsKLWV4dGVybiBpbnQgX19zaWduYml0ZCAoZG91YmxlIHgpOworZXh0ZXJuIGludCBfX2lzaW5m ZiAoZmxvYXQpOworZXh0ZXJuIGludCBfX2lzaW5mZCAoZG91YmxlKTsKK2V4dGVybiBpbnQgX19p c25hbmYgKGZsb2F0KTsKK2V4dGVybiBpbnQgX19pc25hbmQgKGRvdWJsZSk7CitleHRlcm4gaW50 IF9fZnBjbGFzc2lmeWYgKGZsb2F0KTsKK2V4dGVybiBpbnQgX19mcGNsYXNzaWZ5ZCAoZG91Ymxl KTsKK2V4dGVybiBpbnQgX19zaWduYml0ZiAoZmxvYXQpOworZXh0ZXJuIGludCBfX3NpZ25iaXRk IChkb3VibGUpOwogCiAvKiBOb3RlOiBpc2luZiBhbmQgaXNuYW4gd2VyZSBvbmNlIGZ1bmN0aW9u cyBpbiBuZXdsaWIgdGhhdCB0b29rIGRvdWJsZQogICogICAgICAgYXJndW1lbnRzLiAgQzk5IHNw ZWNpZmllcyB0aGF0IHRoZXNlIG5hbWVzIGFyZSByZXNlcnZlZCBmb3IgbWFjcm9zCi0tIAoyLjcu NAoK --0000000000008669d805aff7a28b--