From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 4FAB73858D1E for ; Wed, 29 Nov 2023 06:41:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FAB73858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FAB73858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701240097; cv=none; b=N5E3ndz+jfklecfD07Y6Sz1Cy36akMZXoo7BO91MT1trqPwhBo6lbXTXOvuwe914vj5OU7Ih04fEgIGRJRYdheOBSSttnHYuP5W8R4Fe2PhHdY+67cc3zTRt5g8CKoqYbWl1jHBAfEPxpwjGDdgZktba43sEy9psHHwfcmPy4wk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701240097; c=relaxed/simple; bh=PlJcUeEwUeiwRsHySdRDEfE1yYz5FgG+yb8/vRjAGTo=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=WMUPUuAmvzMJF2ZDQhV5IvJk8WmUf0u2r1ISJC/XU3WoKs2RmaBAo+eYuRbbGwbGhp8COPWPwhJ98QJ3f5q6kgkinz3ejTNvxGlPAs/LWx8VGSdyMGwf9Dqt1kj7yl02RWsOc/u5ENnxuc4m1mZr6Lvu74u0UoCBm7GHjWAI02o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-2839b922c18so5063943a91.1 for ; Tue, 28 Nov 2023 22:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1701240094; x=1701844894; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M80wNxb9Wgb/opozlsM48Pvdg4QCRzlt3vnql5pZNvw=; b=GNEsZwWsI+OrYMxGqtPF6clPFFUKfzi/UiXHrDgD/H6uFbQi3M6KIJGpTGhswBVuW3 n5FXRYp5COGQ5AoEGGORoxAgZlHRjGFCAHJO2Jw8o9/5Zh7G5IZIPzVTIM6VWFTulsN0 8mmgeFrRNSOzaZajr9oOCDTH+KKvnncaW1RaE6cYBSdOKQvDrRwMKRSF3nAyrtg29j1k t/o5trB3Yi2weJW6l+7HfzYGnb+PjWLoiIBek6+14PHizp1EeDHv++369GBPxEIbnjl4 KfS7KpoZ9mayBtdga+6efavw+Oug1xxvWC77dqoKAFflZiQZrFq46pr7wISPCg0Vw1pm raXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701240094; x=1701844894; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M80wNxb9Wgb/opozlsM48Pvdg4QCRzlt3vnql5pZNvw=; b=qjjtEQB8UFB1LiboW6rx324exF8muXZpYVHyN/7o5U+eLNIV2X+XC7OYw3rekc0B65 isBNBdyU5iBtvpgsa5E9vE8l06tbBPrpSwV71geQ6gIW9BYTPWzJAh+BR3QrJtdZ+hHV cgww4EA4nAVcHJr6xGYWhjOaXdv93R7fN5WpnvUgf8u2cn00GiVtPUewdI7lEzRz+WmP FdeO3cSX8J36tr/iuaXSY6H7Fb9g8IVUFTephCTnxvRqQTe1jEgwIUyBRvq3eGa5AZQD 673fXl0YQBiL+zQFCw22bQu5K4LcJLZe6FzB3QMIsVoJ0eOry9GmiYfeArIF8yx8SIoS uSKA== X-Gm-Message-State: AOJu0YzMoGiDzjmQANjySn4NQFmcB1osvvJm5NxTUs8y9bGi14ZZX2f7 2HLLDYCwjVsPeZTscWJwq7Si4tL6vKC+hK8KAgi1F2zybkAfpOEV X-Google-Smtp-Source: AGHT+IFN8m4YTrvwyfoDvjVntKk630yaXXIUcRGQXJft0PNgHHxe7s8uS+xwIa2nahEy0ehPJFs9ICxrh3TqN378Lns= X-Received: by 2002:a17:90b:3883:b0:285:a0ae:6a65 with SMTP id mu3-20020a17090b388300b00285a0ae6a65mr13983282pjb.17.1701240094164; Tue, 28 Nov 2023 22:41:34 -0800 (PST) MIME-Version: 1.0 References: <20231128223739.463754-1-visitorckw@gmail.com> <20231129035714.469943-1-visitorckw@gmail.com> In-Reply-To: <20231129035714.469943-1-visitorckw@gmail.com> From: Kito Cheng Date: Wed, 29 Nov 2023 14:41:22 +0800 Message-ID: Subject: Re: [PATCH v2] RISC-V: Fix timeval conversion in _gettimeofday() To: Kuan-Wei Chiu Cc: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thanks for the fix, I am suppressing that we mis-scale that for such a long time! On Wed, Nov 29, 2023 at 11:57=E2=80=AFAM Kuan-Wei Chiu wrote: > > Replace multiplication with division for microseconds calculation from > nanoseconds in _gettimeofday function. > > Signed-off-by: Kuan-Wei Chiu > --- > v1 -> v2: > - Add missing Signed-off-by tag. > > libgloss/riscv/sys_gettimeofday.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libgloss/riscv/sys_gettimeofday.c b/libgloss/riscv/sys_getti= meofday.c > index 81bea8e55..5379a8963 100644 > --- a/libgloss/riscv/sys_gettimeofday.c > +++ b/libgloss/riscv/sys_gettimeofday.c > @@ -23,7 +23,7 @@ _gettimeofday(struct timeval *tp, void *tzp) > int rv; > rv =3D syscall_errno (SYS_clock_gettime64, 2, 0, (long)&ts64, 0, 0, 0,= 0); > tp->tv_sec =3D ts64.tv_sec; > - tp->tv_usec =3D ts64.tv_nsec * 1000; > + tp->tv_usec =3D ts64.tv_nsec / 1000; > return rv; > #else > return syscall_errno (SYS_gettimeofday, 1, tp, 0, 0, 0, 0, 0); > -- > 2.25.1 >