public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@sifive.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: Newlib <newlib@sourceware.org>, Jesse Huang <jesse.huang@sifive.com>
Subject: Re: [PATCH] riscv: Fix fenv.h support
Date: Thu, 12 Oct 2023 07:36:49 -0700	[thread overview]
Message-ID: <CALLt3Ti7kND4V-U-tJF_NJQ+8Qxp73xFWyCKD=h2g1_avKJiyg@mail.gmail.com> (raw)
In-Reply-To: <20231012100602.48059-1-sebastian.huber@embedded-brains.de>

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

LGTM, I didn't notice that backwards compatible issue, thanks for fixing
that :)

Sebastian Huber <sebastian.huber@embedded-brains.de> 於 2023年10月12日 週四 03:06
寫道：

> Use the same C preprocessor expressions to define FE_RMODE_MASK and
> __RISCV_HARD_FLOAT.
>
> The problem was noticed on GCC 10 which does not define __riscv_f.
> ---
>  newlib/libc/machine/riscv/sys/fenv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/machine/riscv/sys/fenv.h
> b/newlib/libc/machine/riscv/sys/fenv.h
> index 1d577d527b..98387d2205 100644
> --- a/newlib/libc/machine/riscv/sys/fenv.h
> +++ b/newlib/libc/machine/riscv/sys/fenv.h
> @@ -14,7 +14,7 @@
>
>  #include <stddef.h>
>
> -#if defined(__riscv_f) || defined(__riscv_zfinx)
> +#if defined(__riscv_flen) || defined(__riscv_zfinx)
>
>  /* Per "The RISC-V Instruction Set Manual: Volume I: User-Level ISA:
>   * Version 2.1", Section 8.2, "Floating-Point Control and Status
> --
> 2.35.3
>
>

  reply	other threads:[~2023-10-12 14:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12 10:06 Sebastian Huber
2023-10-12 14:36 ` Kito Cheng [this message]
2023-10-12 15:07 ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALLt3Ti7kND4V-U-tJF_NJQ+8Qxp73xFWyCKD=h2g1_avKJiyg@mail.gmail.com' \
    --to=kito.cheng@sifive.com \
    --cc=jesse.huang@sifive.com \
    --cc=newlib@sourceware.org \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).