From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id 5E0C23858CDB for ; Wed, 22 Feb 2023 03:18:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E0C23858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-lf1-x132.google.com with SMTP id bp25so8451742lfb.0 for ; Tue, 21 Feb 2023 19:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qQrOOS3lgBRnJLKiEqs7mfqxDx7xy1OgO5037UQ9CYg=; b=Hf66VaATLvN0jghfaDh5YtJiBiPg9sExReg6H7z1M6zhkPH7Q9aB6EQq93VD9HXtkT yf7rRogbhZdD0NBM/NltGtYCKtV8Mo3M9hUMDtEDeAESqLOsArBitNjirApx8jsn4ibo QcPhpB0RP4yIEhpOglkXNQTyUGXuVzbIalwCtPXIMIULAKwciHdw0adO0BEtbRF1vRRH Ws5KZV+HuKh4Kt2NRSidW8bgxnzyiheUWUZ2lNFGh8j5DCdZYCIBy9w2bn1d+pKNHIa6 tyd9WaHe5OvhrGKUnNf/wKW4+yOXDhZoMFdke2T7W93szKgqxV+TTiaNRc1Ivj3rQSpE YsJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qQrOOS3lgBRnJLKiEqs7mfqxDx7xy1OgO5037UQ9CYg=; b=b0d5acuX04Oy0ziiS6c3DgWhQcNv9B4SIsa8fHMrl1rjzUi2FgPNA4roE7+T/qHofq 7MhcnzSF3yUo0NeU4KC2ytPZzQWP+2OLxxSnaC+LkQAtHLAFnr8xXbeoOGo0mWzUv55a n4c2sMaMHXQFo8TeJkKYt3lLOrAu+i11ZepwotXh6xEKJ4cBCBgZgl7s3zFJMKgJOthE F+uONuNlAyMB9tcpSF0NosAV+w7fYBcWxNwBZ5cb9GNglQXM7+n3PCP67oGSY+pkJnzi J2stCGr5E+U7eaNZAKxcq2o7R/UgTHM/tCAeX/3G+QIcdpurbnSd/W83+6bX4uXHqEv7 zmLw== X-Gm-Message-State: AO0yUKWxkXVJAAj1003pSfOzHBYiNwIN2Ae/YodTniK01U1ahiz1CUxn OdPHCgBUEjBO2gk6F0C4MGCknzx6EOIgvM46DnYQaQ== X-Google-Smtp-Source: AK7set85CHGQbSfHPBVZuJvWUs4ePPvRVHErNuJmgnuytcuxfDl09Wa7d6ejHBTlsguZrp2DwYUEr+fK/Vg0QkWiXhE= X-Received: by 2002:a05:6512:38c9:b0:4db:2c5a:e4f6 with SMTP id p9-20020a05651238c900b004db2c5ae4f6mr2361125lft.3.1677035895613; Tue, 21 Feb 2023 19:18:15 -0800 (PST) MIME-Version: 1.0 References: <20230222015907.43288-1-hau.hsu@sifive.com> In-Reply-To: <20230222015907.43288-1-hau.hsu@sifive.com> From: Kito Cheng Date: Wed, 22 Feb 2023 11:18:03 +0800 Message-ID: Subject: Re: [PATCH 1/1] RISC-V: Use the new libm code if possible To: Hau Hsu Cc: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thank Hau :) On Wed, Feb 22, 2023 at 9:59 AM Hau Hsu wrote: > > Set __OBSOLETE_MATH_DEFAULT to 0 if 'd' extension is supported (i.e. > __riscv_flen == 64). > > Base on the comment for __OBSOLETE_MATH_DEFAULT: > > > ... it assumes that the toolchain has ISO C99 support (hexfloat > > literals, standard fenv semantics), the target has IEEE-754 conforming > > binary32 float and binary64 double (not mixed endian) representation, > > standard SNaN representation, double and single precision arithmetics > > has similar latency and it has no legacy SVID matherr support, only > > POSIX errno and fenv exception based error handling. > > Signed-off-by: Hau Hsu > --- > newlib/libc/include/machine/ieeefp.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/newlib/libc/include/machine/ieeefp.h b/newlib/libc/include/machine/ieeefp.h > index 9bb8af02f..a29557a6d 100644 > --- a/newlib/libc/include/machine/ieeefp.h > +++ b/newlib/libc/include/machine/ieeefp.h > @@ -221,6 +221,11 @@ > #ifdef __riscv_flen > # define _SUPPORTS_ERREXCEPT > #endif > +#if __riscv_flen == 64 > +# define __OBSOLETE_MATH_DEFAULT 0 > +#else > +# define __OBSOLETE_MATH_DEFAULT 1 > +#endif > #endif > > #ifdef __i960__ > -- > 2.39.0 >