public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@sifive.com>
To: Keith Packard <keithp@keithp.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH 2/2] RISC-V: Implment finite and fpclassify
Date: Wed, 28 Oct 2020 23:42:24 +0800	[thread overview]
Message-ID: <CALLt3TjnEhFoMHcYOZFOO7uVZr_X7qKL_+BzegBYsSib=+P8NQ@mail.gmail.com> (raw)
In-Reply-To: <87361zfs1e.fsf@keithp.com>

Hi Keith:

Thanks for your review! I sent patches to fix those two issues :)

On Wed, Oct 28, 2020 at 2:22 AM Keith Packard <keithp@keithp.com> wrote:

> Kito Cheng <kito.cheng@sifive.com> writes:
>
> > +#if defined(__riscv_flen) && __riscv_flen >= 64
> > +#include "riscv_math.h"
> > +int finite(double x)
> > +{
> > +     long fclass = _fclass_d (x);
> > +     return (fclass & FCLASS_INF) == 0;
> > +}
>
> This also needs to check for FCLASS_NAN:
>
>         return (class & (FCLASS_INF|FCLASS_NAN)) == 0;
>
> Same for finitef
>
> --
> -keith
>

  reply	other threads:[~2020-10-28 15:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27  6:19 [PATCH 1/2] RISC-V: Add fabs[f], fmax[f] and fmin[f] Kito Cheng
2020-10-27  6:19 ` [PATCH 2/2] RISC-V: Implment finite and fpclassify Kito Cheng
2020-10-27 18:11   ` Keith Packard
2020-10-27 18:22   ` Keith Packard
2020-10-28 15:42     ` Kito Cheng [this message]
2020-10-28 20:45       ` Jim Wilson
2020-10-29  3:02         ` Kito Cheng
2020-10-27  7:59 ` [PATCH 1/2] RISC-V: Add fabs[f], fmax[f] and fmin[f] Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALLt3TjnEhFoMHcYOZFOO7uVZr_X7qKL_+BzegBYsSib=+P8NQ@mail.gmail.com' \
    --to=kito.cheng@sifive.com \
    --cc=keithp@keithp.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).