public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Richard Allen <rsaxvc@rsaxvc.net>
To: newlib@sourceware.org
Subject: [PATCH] Convert 0.0/0.0 to NAN
Date: Wed, 19 Apr 2017 23:50:00 -0000	[thread overview]
Message-ID: <CAMY0PLWxEvHZ7q1m=MW=dV0JjzOrzQ4B277nxgZrmW7AfvnMJQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

With newlib's default compiler flags(-O2 and whatnot),
the GCC I'm using creates calls to __aeabi_(f|d)div.
This causes a little extra register copying
and an unnecessary branch.

Additionally, __aeabi_?div may throw exceptions,
which is probably not what we want a
simple assignment to do.

Compiler version tested:
arm-none-eabi-gcc (15:5.4.1+svn241155-1) 5.4.1 20160919

-Richard

[-- Attachment #2: 0001-Convert-rint-to-rintf.patch --]
[-- Type: text/x-patch, Size: 1105 bytes --]

From 2369a552cf62dfb53f14978587a338072f6abd2c Mon Sep 17 00:00:00 2001
From: Richard <rsaxvc@rsaxvc.net>
Date: Wed, 19 Apr 2017 18:37:17 -0500
Subject: [PATCH] Convert rint() to rintf()

This was causing an unnecessary increase
in precision, as well as additional function
calls to do float->double conversion on
platforms with only a single-precision FPU.
---
 newlib/libm/math/wf_pow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libm/math/wf_pow.c b/newlib/libm/math/wf_pow.c
index bd9de0ad0..5b79dd151 100644
--- a/newlib/libm/math/wf_pow.c
+++ b/newlib/libm/math/wf_pow.c
@@ -126,11 +126,11 @@
 		    if (_LIB_VERSION == _SVID_) {
 		       exc.retval = HUGE;
 		       y *= 0.5;
-		       if(x<0.0&&rint(y)!=y) exc.retval = -HUGE;
+		       if(x<0.0&&rintf(y)!=y) exc.retval = -HUGE;
 		    } else {
 		       exc.retval = HUGE_VAL;
                        y *= 0.5;
-		       if(x<0.0&&rint(y)!=y) exc.retval = -HUGE_VAL;
+		       if(x<0.0&&rintf(y)!=y) exc.retval = -HUGE_VAL;
 		    }
 		    if (_LIB_VERSION == _POSIX_)
 		        errno = ERANGE;
-- 
2.11.0


             reply	other threads:[~2017-04-19 23:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 23:50 Richard Allen [this message]
2017-04-20  0:01 ` Richard Allen
2017-04-20  0:25   ` Craig Howland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMY0PLWxEvHZ7q1m=MW=dV0JjzOrzQ4B277nxgZrmW7AfvnMJQ@mail.gmail.com' \
    --to=rsaxvc@rsaxvc.net \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).