From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71297 invoked by alias); 2 Aug 2017 14:06:24 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 116995 invoked by uid 89); 2 Aug 2017 14:01:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:Zj0GwXA, Hx-spam-relays-external:209.85.223.194, Hx-languages-length:1451, H*RU:209.85.223.194 X-HELO: mail-io0-f194.google.com Received: from mail-io0-f194.google.com (HELO mail-io0-f194.google.com) (209.85.223.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Aug 2017 14:01:25 +0000 Received: by mail-io0-f194.google.com with SMTP id o9so3754387iod.5 for ; Wed, 02 Aug 2017 07:01:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=c0UDB8F/Gbczd6fptezF92TyKkcYMKWRgADVYjfzJ+w=; b=kB9Qh8vYFSGyT6Z1AuIa/N5sBcIALeZDYvN6k9RXTsOBgKMGApJbQxHvBJCIe8OvuN 3EMltVWIKDj+ORovpY0HOVgUC5+vy9e2M/3NUtS5qhlHSlXjl5jd+kPx9wnCfPTJER1K oGkle4o/HHi1XPk8HCM0IuohbGALPlOQ3pPKb2YA45i38Y6Jd2Qqsx49MQizKcYP5zXa nP9m/nOsqBw6phUjqdm/9iGyewfmcOqoeIKXtBR9QzVT+tzo9s6QJkJJ6o18oowVAuKf 2WV04z9ai7UyxkfQVwSmShlNrO02W0tkxwy2t798g9eFzfBXnrzgk/OHJhwLRl01eGcR De7w== X-Gm-Message-State: AIVw112tWIx0uKImfm/okKDTW54Eg49NdT0iX3K2oFRpPWxgYbc0XpJ/ zFt9T+FosWPUFnnjhR9J3uIV+P++cw== X-Received: by 10.107.203.6 with SMTP id b6mr24831209iog.232.1501682483826; Wed, 02 Aug 2017 07:01:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.124.208 with HTTP; Wed, 2 Aug 2017 07:01:23 -0700 (PDT) In-Reply-To: References: <1501643979-32662-1-git-send-email-aadit0402@gmail.com> <20170802110435.GH25551@calimero.vinschen.de> From: Aditya Upadhyay Date: Wed, 02 Aug 2017 14:06:00 -0000 Message-ID: Subject: Re: [PATCH 1/4] Importing strtoimax inttypes method from FreeBSD. To: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00718.txt.bz2 Yes, I will commit the thrid party unmodified code first, then i will commit the modified code. On Wed, Aug 2, 2017 at 7:25 PM, Gedare Bloom wrote: > On Wed, Aug 2, 2017 at 7:04 AM, Corinna Vinschen wrote: >> On Aug 2 08:49, Aditya Upadhyay wrote: >>> --- >>> newlib/libc/include/inttypes.h | 12 +++ >>> newlib/libc/stdlib/Makefile.am | 1 + >>> newlib/libc/stdlib/strtoimax.c | 167 +++++++++++++++++++++++++++++++++++++++++ >> >> All 4 patches applied. >> >> I made a few minor formatting changes in terms of whitespaces and >> missing empty lines between functions. Please compare what I commited >> with your local patch to see the differences. >> > Thanks. There were no empty lines between functions in the original > BSD source. However, since the original source was not submitted > separately from the modification to make it useful, this is hard to > see. Best to leave it as you have pushed it I suppose. > > Aditya, if there are more patches in the future please first provide a > commit with the unmodified BSD file, and then a second commit to > modify the file and to add it to the build system. I neglected to > follow-up on this procedure with you, but it is a good way to ensure > tight synchronization with upstream sources. > > -Gedare > >> >> Thanks, >> Corinna >> >> -- >> Corinna Vinschen >> Cygwin Maintainer >> Red Hat