From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91884 invoked by alias); 4 Jul 2017 21:56:43 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 91826 invoked by uid 89); 4 Jul 2017 21:56:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:zUvdi2m, aadit0402gmailcom, joel.sherrill@oarcorp.com, H*f:sk:zUvdi2m X-HELO: mail-qk0-f181.google.com Received: from mail-qk0-f181.google.com (HELO mail-qk0-f181.google.com) (209.85.220.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Jul 2017 21:56:40 +0000 Received: by mail-qk0-f181.google.com with SMTP id p21so176914976qke.3 for ; Tue, 04 Jul 2017 14:56:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=E2BgRY15pD0GvHgDNHIZDH9AL87tQ14LAaK3JuFALfk=; b=WOT7UJ5T5kXO51z+tzecwYyePgKCz7u8InSHBDKab1m1LIwj0fEc70CVtsRLqrCS1L CBhd/FfF2HNcGkLibWiSgc2SXq4j+Gw4yAcKYbyCTNtfHlPGLq5RoJO4t9UkjCU0iGJf rlAwXLOSdYCwwx5s3sYU0Finn7Nm91sqyuSKW8wGT4mUXE/w60POXaGhu6jO/whwcx2x 0QtKrM+m8MVgM/wZ3g2O5xbQJgmc8rkl8hjeOgT+SF+HRZcToLn3wlRxpXphVCC+F3id pQAWwMUlabzfbtDfHnGBWRodwOtKopy8V8UuNfrd8OSZniA2Y7BFzY6w4rB51eo5FQVD RJsg== X-Gm-Message-State: AKS2vOxkwj1IFUndCbyR8ZjPbaz7wF4W9lsSfgjbBXuAojVzSEIwJs0w WNfLy2bijechl9bwKlLsGk8s/elyzg== X-Received: by 10.55.97.148 with SMTP id v142mr51425056qkb.107.1499205398949; Tue, 04 Jul 2017 14:56:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.233.235.73 with HTTP; Tue, 4 Jul 2017 14:56:38 -0700 (PDT) In-Reply-To: References: <20170629063911.GB31936@calimero.vinschen.de> <20170629115309.GU6201@calimero.vinschen.de> <20170629120417.GV6201@calimero.vinschen.de> <5cff4633-2ef4-623b-e526-61c22e707d87@oarcorp.com> From: Aditya Upadhyay Date: Tue, 04 Jul 2017 21:56:00 -0000 Message-ID: Subject: Re: Long double complex methods To: newlib@sourceware.org Content-Type: multipart/mixed; boundary="94eb2c0572e64028cc055384f542" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00552.txt.bz2 --94eb2c0572e64028cc055384f542 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 3977 Removed blank lines from complex.h. The modified patch for fix warnings , i am attaching here. Please check it = once. Thanks & Regards, Aditya Upadhyay On Wed, Jul 5, 2017 at 3:01 AM, Aditya Upadhyay wrote: > Hello Developers, > > I have fixed the warnings related to cacoshl, casinhl, cargl etc what > Joel Had pointed out.. This is the patch. i am requesting you to > please check it and tell me whether i have correctly fixed the > warnings or not ? > > Thanks & Regards, > Aditya Upadhyay > > On Fri, Jun 30, 2017 at 2:41 PM, Aditya Upadhyay wr= ote: >> I am tring to resolve the warnings. Thank you for pointing it out. >> >> >> Regards, >> Aditya >> >> On Fri, Jun 30, 2017 at 2:47 AM, Joel Sherrill >> wrote: >>> >>> >>> On 6/29/2017 2:38 PM, Yaakov Selkowitz wrote: >>>> >>>> On 2017-06-29 07:04, Corinna Vinschen wrote: >>>>> >>>>> On Jun 29 13:53, Corinna Vinschen wrote: >>>>>> >>>>>> On Jun 29 12:41, Aditya Upadhyay wrote: >>>>>>> >>>>>>> Hello Developers, >>>>>>> >>>>>>> This is the modified patch for csinl.c which reflects changes in >>>>>>> Makefile.am. >>>>>> >>>>>> >>>>>> Uhm... this patch now contains *only* the Makefile.am change, but >>>>>> not the expected csinl.c file. >>>>>> >>>>>> v3? ;) >>>>> >>>>> >>>>> Never mind, I'm going to apply v1 and v2 of patch 18. However, usual= ly >>>>> a v2 (or v3, v4, ...) of a patch is expected to replace the v1 of the >>>>> patch entirely, not that it just contains a diff to v1. >>>>> >>>>> I pushed the set now and regenerated complex/Makefile.in. >>>> >>>> >>>> This patchset is causing errors when building Cygwin: >>>> >>>> newlib/libm/complex/cargl.c: In function cargl=E2=80=99: >>>> newlib/libm/complex/cargl.c:16:25: error: implicit declaration of >>>> function =E2=80=98imag=E2=80=99 [-Werror=3Dimplicit-function-declarati= on] >>>> return atan2l (imag (z), real (z)); >>>> ^ >>>> newlib/libm/complex/cargl.c:16:35: error: implicit declaration of >>>> function =E2=80=98real=E2=80=99 [-Werror=3Dimplicit-function-declarati= on] >>>> return atan2l (imag (z), real (z)); >>>> ^ >>>> >>> >>> It builds for RTEMS (sparc) with some new warnings: >>> >>> newlib/libm/complex/cacoshl.c:42:16: warning: implicit declaration of >>> function 'csqrtl'; did you mean 'csqrtf'? [-Wimplicit-function-declarat= ion] >>> newlib/libm/complex/cacoshl.c:42:6: warning: implicit declaration of >>> function 'clogl'; did you mean 'clogf'? [-Wimplicit-function-declaratio= n] >>> newlib/libm/complex/cacosl.c:41:6: warning: implicit declaration of fun= ction >>> 'casinl'; did you mean 'asinl'? [-Wimplicit-function-declaration] >>> newlib/libm/complex/casinhl.c:39:18: warning: implicit declaration of >>> function 'casinl'; did you mean 'casinhl'? [-Wimplicit-function-declara= tion] >>> newlib/libm/complex/casinl.c:112:7: warning: implicit declaration of >>> function 'csqrtl'; did you mean 'sqrtl'? [-Wimplicit-function-declarati= on] >>> newlib/libm/complex/casinl.c:115:7: warning: implicit declaration of >>> function 'clogl'; did you mean 'logl'? [-Wimplicit-function-declaration] >>> newlib/libm/complex/catanhl.c:39:18: warning: implicit declaration of >>> function 'catanl'; did you mean 'catanhl'? [-Wimplicit-function-declara= tion] >>> newlib/libm/complex/cpowl.c:47:9: warning: implicit declaration of func= tion >>> 'cargl'; did you mean 'cargf'? [-Wimplicit-function-declaration] >>> >>> I don't see any Cygwin ifdef's related to imag() >>> so I built for i386-rtems to see if it was related >>> to _LDBL_EQ_DBL. i386-rtems built with a few warnings. >>> >>> We have an x86_64-rtems tool target in anticipation of >>> a port. I built a tool chain just to check this and >>> the newlib master built cleanly on that. >>> >>> I am sorry but I am not duplicating this. What would >>> be different about Cygwin in this case? >>> >>> --joel >>> --94eb2c0572e64028cc055384f542 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Fixed-warnings-for-some-long-double-complex-methods.patch" Content-Disposition: attachment; filename="0002-Fixed-warnings-for-some-long-double-complex-methods.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4q46lm51 Content-length: 1546 RnJvbSBiZDU5NmRkNDEyNWFjYmU3YmQyOTIyZjI1YTQ0ZTRkYmYzMWJjNGIw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBZGl0eWEgVXBhZGh5 YXkgPGFhZGl0MDQwMkBnbWFpbC5jb20+CkRhdGU6IFdlZCwgNSBKdWwgMjAx NyAwMzoyMDoxOSArMDUzMApTdWJqZWN0OiBbUEFUQ0ggdjIgMi8yXSBGaXhl ZCB3YXJuaW5ncyBmb3Igc29tZSBsb25nIGRvdWJsZSBjb21wbGV4IG1ldGhv ZHMKCi0tLQogbmV3bGliL2xpYmMvaW5jbHVkZS9jb21wbGV4LmggfCA0IC0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL25ld2xpYi9saWJjL2luY2x1ZGUvY29tcGxleC5oIGIvbmV3bGliL2xp YmMvaW5jbHVkZS9jb21wbGV4LmgKaW5kZXggYWYyYTNjZS4uOWVlNDBjMCAx MDA2NDQKLS0tIGEvbmV3bGliL2xpYmMvaW5jbHVkZS9jb21wbGV4LmgKKysr IGIvbmV3bGliL2xpYmMvaW5jbHVkZS9jb21wbGV4LmgKQEAgLTEzMCw4ICsx MzAsNiBAQCBmbG9hdCBjb21wbGV4IGNsb2cxMGYoZmxvYXQgY29tcGxleCk7 CiAKICNpZiBkZWZpbmVkKF9fQ1lHV0lOX18pCiBsb25nIGRvdWJsZSBjb21w bGV4IGNhY29zbChsb25nIGRvdWJsZSBjb21wbGV4KTsKLQotCiBsb25nIGRv dWJsZSBjb21wbGV4IGNjb3NsKGxvbmcgZG91YmxlIGNvbXBsZXgpOwogbG9u ZyBkb3VibGUgY29tcGxleCBjc2lubChsb25nIGRvdWJsZSBjb21wbGV4KTsK IGxvbmcgZG91YmxlIGNvbXBsZXggY3RhbmwobG9uZyBkb3VibGUgY29tcGxl eCk7CkBAIC0xNDQsOCArMTQyLDYgQEAgbG9uZyBkb3VibGUgY29tcGxleCBj dGFuaGwobG9uZyBkb3VibGUgY29tcGxleCk7CiBsb25nIGRvdWJsZSBjb21w bGV4IGNleHBsKGxvbmcgZG91YmxlIGNvbXBsZXgpOwogbG9uZyBkb3VibGUg Y29tcGxleCBjbG9nbChsb25nIGRvdWJsZSBjb21wbGV4KTsKIGxvbmcgZG91 YmxlIGNvbXBsZXggY3Bvd2wobG9uZyBkb3VibGUgY29tcGxleCwgbG9uZyBk b3VibGUgY29tcGxleCk7Ci0KLQogbG9uZyBkb3VibGUgY29tcGxleCBjb25q bChsb25nIGRvdWJsZSBjb21wbGV4KTsKIGxvbmcgZG91YmxlIGNvbXBsZXgg Y3Byb2psKGxvbmcgZG91YmxlIGNvbXBsZXgpOwogI2lmIF9fR05VX1ZJU0lC TEUKLS0gCjIuNy40Cgo= --94eb2c0572e64028cc055384f542--