From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116741 invoked by alias); 26 Jul 2017 12:02:28 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 116398 invoked by uid 89); 26 Jul 2017 12:02:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=yours X-HELO: mail-io0-f174.google.com Received: from mail-io0-f174.google.com (HELO mail-io0-f174.google.com) (209.85.223.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 12:02:22 +0000 Received: by mail-io0-f174.google.com with SMTP id g35so34136639ioi.3 for ; Wed, 26 Jul 2017 05:02:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=rHYqZz0yoXglMpm3ksaDq1OG8Ru2/mRpAPSHRzE5AE4=; b=UGJpeXeEdDsSml9VPymJYllIsu8lNFcLNsJwjnisuVkxoJV4BYr8hdQXZub984eUEZ tZF1vV9qIj2u1YrXpIBnQ9mJBQ6jpyvFXOc8SMehbw7NYdQCaHJ+VXPEKNjX3eAwWLPF Wq3eNAfTy2RlXyWMpwbqPt4PJluv1pmwBulyZnCRkciRGN50xb/OK4HK6XxAUzBHXVBV p0qyZtDplPK6BDQ9YqoH6wRJ8vUI69v4E4AUggUF4bApvM/Ch0K955khgnfPp/ouGBDl GhxYsWss1ZIoKYOY6IGPZTtethM48HuUHAVYy6ts3UYjqmEeq0UGXJ83yw/b2Npr44ag iCIg== X-Gm-Message-State: AIVw112bA5jYzQO8ByIL+0ZUe6t52MmSkCP+JAEFpKFQx8pklbHlrvpc cJskYQsqitUPYbjsgfCg+M8ZIk937A== X-Received: by 10.107.201.23 with SMTP id z23mr667335iof.6.1501070538036; Wed, 26 Jul 2017 05:02:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.124.208 with HTTP; Wed, 26 Jul 2017 05:02:17 -0700 (PDT) In-Reply-To: <20170726110849.GG14419@calimero.vinschen.de> References: <20170726110849.GG14419@calimero.vinschen.de> From: Aditya Upadhyay Date: Wed, 26 Jul 2017 12:02:00 -0000 Message-ID: Subject: Re: Importing inttypes methods To: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00649.txt.bz2 On Wed, Jul 26, 2017 at 4:38 PM, Corinna Vinschen wrote: > On Jul 26 01:20, Aditya Upadhyay wrote: >> Hello All, >> >> I have ported the inttypes methods from freeBSD. I have made all the >> possible changes whatever my mentors suggested me. I am requesting you >> to please review the same. Is this ok for master ? > > The patches apply and build. This looks 99% good now, thank you. > Thanks. > Just one last minor problem, which is my fault, not yours: > > You named the reentrant functions _strtoimax_r, _wcstoumax_r, etc., > which is basically right. > > However, the *other*, equivalent reentrant, locale-specific functions > for other datatypes are all named with a trailing l: _strtol_l, > _wcstoull_l, etc. In retrospect, this wasn't the brightest idea, > but the API has been exported this way, so I'm reluctant to change > it after the fact. > > Would you mind to call your new functions with trailing 'l' rather > than 'r', too, to use the same naming convention, please? > I will keep your points in mind whenever i will port a new function. > Oh, btw., please make sure the patches have no trailing whitespace. > That's not really a problem, but `git am' complains about them. > > > Thanks, > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat