From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48337 invoked by alias); 4 Jul 2017 21:31:25 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 48314 invoked by uid 89); 4 Jul 2017 21:31:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=7372, anticipation X-HELO: mail-qt0-f176.google.com Received: from mail-qt0-f176.google.com (HELO mail-qt0-f176.google.com) (209.85.216.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Jul 2017 21:31:21 +0000 Received: by mail-qt0-f176.google.com with SMTP id i2so173303773qta.3 for ; Tue, 04 Jul 2017 14:31:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=GmX6Zg2W2mcCR8nEYqGO+eOOQdnrlt7oTeJ81U8BCrw=; b=CIGPV1KVGbxHD++qkLVtldmsnQhr50kzGw4jAg0VXD7kLFeNwKcA01ABvJ+qxhAZXy /wqLweFchIL+jyjE3gqx2iS+3YgBk4hX18q80F19ZDxGKMSoRzaX0ZxJauQzcm7xulIy pT9rvgHcCXVtHC07ZdVwaS5HHwiVjaifdrAUpbzujr/nv92eYghtP4VtfL6FWvyORfVM tDnMiyR8A2OID5UYeyMGdPHZ318VlFLtCCSi5tVY6fhhsRFzoM8f1F8OHko70prq5Ts0 EwOkiWLZKKDrI1cDx8ZLtvWrWdwWLm0/u44/4zJDhC/CLmNbBGDY9PF3GsMeANNpc63V pvdw== X-Gm-Message-State: AKS2vOwe4rgq5yg9BVBu1i/B44hdfhjTyIc/FEYiqSb8oROTpyN5NATq 96sXlXT6fbKnvTOcdo6LgCzxUXlRtQ== X-Received: by 10.237.43.35 with SMTP id p32mr48641948qtd.86.1499203879062; Tue, 04 Jul 2017 14:31:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.233.235.73 with HTTP; Tue, 4 Jul 2017 14:31:18 -0700 (PDT) In-Reply-To: References: <20170629063911.GB31936@calimero.vinschen.de> <20170629115309.GU6201@calimero.vinschen.de> <20170629120417.GV6201@calimero.vinschen.de> <5cff4633-2ef4-623b-e526-61c22e707d87@oarcorp.com> From: Aditya Upadhyay Date: Tue, 04 Jul 2017 21:31:00 -0000 Message-ID: Subject: Re: Long double complex methods To: newlib@sourceware.org Content-Type: multipart/mixed; boundary="94eb2c12583ca875fd0553849a48" X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00551.txt.bz2 --94eb2c12583ca875fd0553849a48 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 3640 Hello Developers, I have fixed the warnings related to cacoshl, casinhl, cargl etc what Joel Had pointed out.. This is the patch. i am requesting you to please check it and tell me whether i have correctly fixed the warnings or not ? Thanks & Regards, Aditya Upadhyay On Fri, Jun 30, 2017 at 2:41 PM, Aditya Upadhyay wrot= e: > I am tring to resolve the warnings. Thank you for pointing it out. > > > Regards, > Aditya > > On Fri, Jun 30, 2017 at 2:47 AM, Joel Sherrill > wrote: >> >> >> On 6/29/2017 2:38 PM, Yaakov Selkowitz wrote: >>> >>> On 2017-06-29 07:04, Corinna Vinschen wrote: >>>> >>>> On Jun 29 13:53, Corinna Vinschen wrote: >>>>> >>>>> On Jun 29 12:41, Aditya Upadhyay wrote: >>>>>> >>>>>> Hello Developers, >>>>>> >>>>>> This is the modified patch for csinl.c which reflects changes in >>>>>> Makefile.am. >>>>> >>>>> >>>>> Uhm... this patch now contains *only* the Makefile.am change, but >>>>> not the expected csinl.c file. >>>>> >>>>> v3? ;) >>>> >>>> >>>> Never mind, I'm going to apply v1 and v2 of patch 18. However, usually >>>> a v2 (or v3, v4, ...) of a patch is expected to replace the v1 of the >>>> patch entirely, not that it just contains a diff to v1. >>>> >>>> I pushed the set now and regenerated complex/Makefile.in. >>> >>> >>> This patchset is causing errors when building Cygwin: >>> >>> newlib/libm/complex/cargl.c: In function cargl=E2=80=99: >>> newlib/libm/complex/cargl.c:16:25: error: implicit declaration of >>> function =E2=80=98imag=E2=80=99 [-Werror=3Dimplicit-function-declaratio= n] >>> return atan2l (imag (z), real (z)); >>> ^ >>> newlib/libm/complex/cargl.c:16:35: error: implicit declaration of >>> function =E2=80=98real=E2=80=99 [-Werror=3Dimplicit-function-declaratio= n] >>> return atan2l (imag (z), real (z)); >>> ^ >>> >> >> It builds for RTEMS (sparc) with some new warnings: >> >> newlib/libm/complex/cacoshl.c:42:16: warning: implicit declaration of >> function 'csqrtl'; did you mean 'csqrtf'? [-Wimplicit-function-declarati= on] >> newlib/libm/complex/cacoshl.c:42:6: warning: implicit declaration of >> function 'clogl'; did you mean 'clogf'? [-Wimplicit-function-declaration] >> newlib/libm/complex/cacosl.c:41:6: warning: implicit declaration of func= tion >> 'casinl'; did you mean 'asinl'? [-Wimplicit-function-declaration] >> newlib/libm/complex/casinhl.c:39:18: warning: implicit declaration of >> function 'casinl'; did you mean 'casinhl'? [-Wimplicit-function-declarat= ion] >> newlib/libm/complex/casinl.c:112:7: warning: implicit declaration of >> function 'csqrtl'; did you mean 'sqrtl'? [-Wimplicit-function-declaratio= n] >> newlib/libm/complex/casinl.c:115:7: warning: implicit declaration of >> function 'clogl'; did you mean 'logl'? [-Wimplicit-function-declaration] >> newlib/libm/complex/catanhl.c:39:18: warning: implicit declaration of >> function 'catanl'; did you mean 'catanhl'? [-Wimplicit-function-declarat= ion] >> newlib/libm/complex/cpowl.c:47:9: warning: implicit declaration of funct= ion >> 'cargl'; did you mean 'cargf'? [-Wimplicit-function-declaration] >> >> I don't see any Cygwin ifdef's related to imag() >> so I built for i386-rtems to see if it was related >> to _LDBL_EQ_DBL. i386-rtems built with a few warnings. >> >> We have an x86_64-rtems tool target in anticipation of >> a port. I built a tool chain just to check this and >> the newlib master built cleanly on that. >> >> I am sorry but I am not duplicating this. What would >> be different about Cygwin in this case? >> >> --joel >> --94eb2c12583ca875fd0553849a48 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fixed-warnings-for-some-long-double-complex-methods.patch" Content-Disposition: attachment; filename="0001-Fixed-warnings-for-some-long-double-complex-methods.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4q39e3l0 Content-length: 3494 RnJvbSAyOTJkOTIwYjEyMTBjNjc2ODRiMTNhZDgyZmM1NmM3MjAxYzVlZTU5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBZGl0eWEgVXBhZGh5 YXkgPGFhZGl0MDQwMkBnbWFpbC5jb20+CkRhdGU6IFdlZCwgNSBKdWwgMjAx NyAwMjo1NjoxNSArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIEZpeGVkIHdhcm5p bmdzIGZvciBzb21lIGxvbmcgZG91YmxlIGNvbXBsZXggbWV0aG9kcwoKLS0t CiBuZXdsaWIvbGliYy9pbmNsdWRlL2NvbXBsZXguaCB8IDEzICsrKysrKysr Ky0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDQgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbmV3bGliL2xpYmMvaW5jbHVkZS9j b21wbGV4LmggYi9uZXdsaWIvbGliYy9pbmNsdWRlL2NvbXBsZXguaAppbmRl eCA4OWQ2MTYyLi5hZjJhM2NlIDEwMDY0NAotLS0gYS9uZXdsaWIvbGliYy9p bmNsdWRlL2NvbXBsZXguaAorKysgYi9uZXdsaWIvbGliYy9pbmNsdWRlL2Nv bXBsZXguaApAQCAtMjQsMTAgKzI0LDEyIEBAIGZsb2F0IGNvbXBsZXggY2Fj b3NmKGZsb2F0IGNvbXBsZXgpOwogLyogNy4zLjUuMiBUaGUgY2FzaW4gZnVu Y3Rpb25zICovCiBkb3VibGUgY29tcGxleCBjYXNpbihkb3VibGUgY29tcGxl eCk7CiBmbG9hdCBjb21wbGV4IGNhc2luZihmbG9hdCBjb21wbGV4KTsKK2xv bmcgZG91YmxlIGNvbXBsZXggY2FzaW5sKGxvbmcgZG91YmxlIGNvbXBsZXgp OwogCiAvKiA3LjMuNS4xIFRoZSBjYXRhbiBmdW5jdGlvbnMgKi8KIGRvdWJs ZSBjb21wbGV4IGNhdGFuKGRvdWJsZSBjb21wbGV4KTsKIGZsb2F0IGNvbXBs ZXggY2F0YW5mKGZsb2F0IGNvbXBsZXgpOworbG9uZyBkb3VibGUgY29tcGxl eCBjYXRhbmwobG9uZyBkb3VibGUgY29tcGxleCk7CiAKIC8qIDcuMy41LjEg VGhlIGNjb3MgZnVuY3Rpb25zICovCiBkb3VibGUgY29tcGxleCBjY29zKGRv dWJsZSBjb21wbGV4KTsKQEAgLTc0LDYgKzc2LDcgQEAgZmxvYXQgY29tcGxl eCBjZXhwZihmbG9hdCBjb21wbGV4KTsKIC8qIDcuMy43LjIgVGhlIGNsb2cg ZnVuY3Rpb25zICovCiBkb3VibGUgY29tcGxleCBjbG9nKGRvdWJsZSBjb21w bGV4KTsKIGZsb2F0IGNvbXBsZXggY2xvZ2YoZmxvYXQgY29tcGxleCk7Cits b25nIGRvdWJsZSBjb21wbGV4IGNsb2dsKGxvbmcgZG91YmxlIGNvbXBsZXgp OwogCiAvKiA3LjMuOCBQb3dlciBhbmQgYWJzb2x1dGUtdmFsdWUgZnVuY3Rp b25zICovCiAvKiA3LjMuOC4xIFRoZSBjYWJzIGZ1bmN0aW9ucyAqLwpAQCAt OTQsMTEgKzk3LDEzIEBAIGZsb2F0IGNvbXBsZXggY3Bvd2YoZmxvYXQgY29t cGxleCwgZmxvYXQgY29tcGxleCk7CiAvKiA3LjMuOC4zIFRoZSBjc3FydCBm dW5jdGlvbnMgKi8KIGRvdWJsZSBjb21wbGV4IGNzcXJ0KGRvdWJsZSBjb21w bGV4KTsKIGZsb2F0IGNvbXBsZXggY3NxcnRmKGZsb2F0IGNvbXBsZXgpOwor bG9uZyBkb3VibGUgY29tcGxleCBjc3FydGwobG9uZyBkb3VibGUgY29tcGxl eCk7CiAKIC8qIDcuMy45IE1hbmlwdWxhdGlvbiBmdW5jdGlvbnMgKi8KIC8q IDcuMy45LjEgVGhlIGNhcmcgZnVuY3Rpb25zICovIAogZG91YmxlIGNhcmco ZG91YmxlIGNvbXBsZXgpOwogZmxvYXQgY2FyZ2YoZmxvYXQgY29tcGxleCk7 Citsb25nIGRvdWJsZSBjYXJnbChsb25nIGRvdWJsZSBjb21wbGV4KTsKIAog LyogNy4zLjkuMiBUaGUgY2ltYWcgZnVuY3Rpb25zICovCiBkb3VibGUgY2lt YWcoZG91YmxlIGNvbXBsZXgpOwpAQCAtMTI1LDggKzEzMCw4IEBAIGZsb2F0 IGNvbXBsZXggY2xvZzEwZihmbG9hdCBjb21wbGV4KTsKIAogI2lmIGRlZmlu ZWQoX19DWUdXSU5fXykKIGxvbmcgZG91YmxlIGNvbXBsZXggY2Fjb3NsKGxv bmcgZG91YmxlIGNvbXBsZXgpOwotbG9uZyBkb3VibGUgY29tcGxleCBjYXNp bmwobG9uZyBkb3VibGUgY29tcGxleCk7Ci1sb25nIGRvdWJsZSBjb21wbGV4 IGNhdGFubChsb25nIGRvdWJsZSBjb21wbGV4KTsKKworCiBsb25nIGRvdWJs ZSBjb21wbGV4IGNjb3NsKGxvbmcgZG91YmxlIGNvbXBsZXgpOwogbG9uZyBk b3VibGUgY29tcGxleCBjc2lubChsb25nIGRvdWJsZSBjb21wbGV4KTsKIGxv bmcgZG91YmxlIGNvbXBsZXggY3RhbmwobG9uZyBkb3VibGUgY29tcGxleCk7 CkBAIC0xMzksOCArMTQ0LDggQEAgbG9uZyBkb3VibGUgY29tcGxleCBjdGFu aGwobG9uZyBkb3VibGUgY29tcGxleCk7CiBsb25nIGRvdWJsZSBjb21wbGV4 IGNleHBsKGxvbmcgZG91YmxlIGNvbXBsZXgpOwogbG9uZyBkb3VibGUgY29t cGxleCBjbG9nbChsb25nIGRvdWJsZSBjb21wbGV4KTsKIGxvbmcgZG91Ymxl IGNvbXBsZXggY3Bvd2wobG9uZyBkb3VibGUgY29tcGxleCwgbG9uZyBkb3Vi bGUgY29tcGxleCk7Ci1sb25nIGRvdWJsZSBjb21wbGV4IGNzcXJ0bChsb25n IGRvdWJsZSBjb21wbGV4KTsKLWxvbmcgZG91YmxlIGNhcmdsKGxvbmcgZG91 YmxlIGNvbXBsZXgpOworCisKIGxvbmcgZG91YmxlIGNvbXBsZXggY29uamwo bG9uZyBkb3VibGUgY29tcGxleCk7CiBsb25nIGRvdWJsZSBjb21wbGV4IGNw cm9qbChsb25nIGRvdWJsZSBjb21wbGV4KTsKICNpZiBfX0dOVV9WSVNJQkxF Ci0tIAoyLjcuNAoK --94eb2c12583ca875fd0553849a48--