From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120049 invoked by alias); 30 Jun 2017 09:11:27 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 119922 invoked by uid 89); 30 Jun 2017 09:11:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.4 required=5.0 tests=AWL,BAYES_40,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=anticipation, atan2l, cargl=e2, imag=e2?= X-HELO: mail-it0-f51.google.com Received: from mail-it0-f51.google.com (HELO mail-it0-f51.google.com) (209.85.214.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Jun 2017 09:11:24 +0000 Received: by mail-it0-f51.google.com with SMTP id v202so57887057itb.0 for ; Fri, 30 Jun 2017 02:11:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=pVTLRVGILm+QNVsP2RGWdVS9O6y7R/OmGJJTVW9Ao6g=; b=M7Wj6fug6fOfMpSkVUdg9u/daAPHyvzBR8X+afAAStmTwOS/Ul1TT645KoeSEvQaac zkJFOMExWA+I/pCfkQUdEiy39aEtdlxLlGYn3bfc6FNq+4n+fNFM8eu6yv9WQv81vZHk aPNw1wYMUGBKjUnrw9TSTLJw2jF4O3yXFXx5PSJEvYJZBphigRQdgeZqmYIKH4obAtoP RmcC0UCGH2aBkAhv9LyPXEoc/AKgLRgooW6Evb6huCUZdrjDSNEw1py7ToiDsWtZ7zaV RdcYSWfFwjTjIOPGjb3uZ4ASyhAktMju3SVoyRftxnlaTBmgKd9SxhS1h0RjosKgkQdY /O1A== X-Gm-Message-State: AKS2vOzyZSc2/8Ib5ahcEDcDjOgIskf98pvnaemSRr6mB6UnVh/WgUuj IIkjCJLp3izcy8fuR8QUlflVCiIzBw== X-Received: by 10.36.147.69 with SMTP id y66mr6620153itd.61.1498813882149; Fri, 30 Jun 2017 02:11:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.4.203 with HTTP; Fri, 30 Jun 2017 02:11:21 -0700 (PDT) In-Reply-To: <5cff4633-2ef4-623b-e526-61c22e707d87@oarcorp.com> References: <20170629063911.GB31936@calimero.vinschen.de> <20170629115309.GU6201@calimero.vinschen.de> <20170629120417.GV6201@calimero.vinschen.de> <5cff4633-2ef4-623b-e526-61c22e707d87@oarcorp.com> From: Aditya Upadhyay Date: Fri, 30 Jun 2017 09:11:00 -0000 Message-ID: Subject: Re: Long double complex methods To: newlib@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00540.txt.bz2 I am tring to resolve the warnings. Thank you for pointing it out. Regards, Aditya On Fri, Jun 30, 2017 at 2:47 AM, Joel Sherrill wrote: > > > On 6/29/2017 2:38 PM, Yaakov Selkowitz wrote: >> >> On 2017-06-29 07:04, Corinna Vinschen wrote: >>> >>> On Jun 29 13:53, Corinna Vinschen wrote: >>>> >>>> On Jun 29 12:41, Aditya Upadhyay wrote: >>>>> >>>>> Hello Developers, >>>>> >>>>> This is the modified patch for csinl.c which reflects changes in >>>>> Makefile.am. >>>> >>>> >>>> Uhm... this patch now contains *only* the Makefile.am change, but >>>> not the expected csinl.c file. >>>> >>>> v3? ;) >>> >>> >>> Never mind, I'm going to apply v1 and v2 of patch 18. However, usually >>> a v2 (or v3, v4, ...) of a patch is expected to replace the v1 of the >>> patch entirely, not that it just contains a diff to v1. >>> >>> I pushed the set now and regenerated complex/Makefile.in. >> >> >> This patchset is causing errors when building Cygwin: >> >> newlib/libm/complex/cargl.c: In function cargl=E2=80=99: >> newlib/libm/complex/cargl.c:16:25: error: implicit declaration of >> function =E2=80=98imag=E2=80=99 [-Werror=3Dimplicit-function-declaration] >> return atan2l (imag (z), real (z)); >> ^ >> newlib/libm/complex/cargl.c:16:35: error: implicit declaration of >> function =E2=80=98real=E2=80=99 [-Werror=3Dimplicit-function-declaration] >> return atan2l (imag (z), real (z)); >> ^ >> > > It builds for RTEMS (sparc) with some new warnings: > > newlib/libm/complex/cacoshl.c:42:16: warning: implicit declaration of > function 'csqrtl'; did you mean 'csqrtf'? [-Wimplicit-function-declaratio= n] > newlib/libm/complex/cacoshl.c:42:6: warning: implicit declaration of > function 'clogl'; did you mean 'clogf'? [-Wimplicit-function-declaration] > newlib/libm/complex/cacosl.c:41:6: warning: implicit declaration of funct= ion > 'casinl'; did you mean 'asinl'? [-Wimplicit-function-declaration] > newlib/libm/complex/casinhl.c:39:18: warning: implicit declaration of > function 'casinl'; did you mean 'casinhl'? [-Wimplicit-function-declarati= on] > newlib/libm/complex/casinl.c:112:7: warning: implicit declaration of > function 'csqrtl'; did you mean 'sqrtl'? [-Wimplicit-function-declaration] > newlib/libm/complex/casinl.c:115:7: warning: implicit declaration of > function 'clogl'; did you mean 'logl'? [-Wimplicit-function-declaration] > newlib/libm/complex/catanhl.c:39:18: warning: implicit declaration of > function 'catanl'; did you mean 'catanhl'? [-Wimplicit-function-declarati= on] > newlib/libm/complex/cpowl.c:47:9: warning: implicit declaration of functi= on > 'cargl'; did you mean 'cargf'? [-Wimplicit-function-declaration] > > I don't see any Cygwin ifdef's related to imag() > so I built for i386-rtems to see if it was related > to _LDBL_EQ_DBL. i386-rtems built with a few warnings. > > We have an x86_64-rtems tool target in anticipation of > a port. I built a tool chain just to check this and > the newlib master built cleanly on that. > > I am sorry but I am not duplicating this. What would > be different about Cygwin in this case? > > --joel >