From: Alexander Fedotov <alfedotov@gmail.com>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
"newlib@sourceware.org" <newlib@sourceware.org>, nd <nd@arm.com>
Subject: Re: [AArch64] use stack symbol provided by linker for nosys
Date: Tue, 15 Aug 2017 14:20:00 -0000 [thread overview]
Message-ID: <CAN8C2CqXh=rPWZOrTQsskmJ88TjtEW0x7ziBQi0U8E_=cg6C_g@mail.gmail.com> (raw)
In-Reply-To: <DB6PR0802MB230994DE0152501620F2A092FF8D0@DB6PR0802MB2309.eurprd08.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
Yes, old fashion habits )
Alex
On Tue, Aug 15, 2017 at 4:57 PM, Tamar Christina
<Tamar.Christina@arm.com> wrote:
>> -----Original Message-----
>> From: Alexander Fedotov [mailto:alfedotov@gmail.com]
>> Sent: 15 August 2017 14:35
>> To: Tamar Christina
>> Cc: Szabolcs Nagy; newlib@sourceware.org; nd
>> Subject: Re: [AArch64] use stack symbol provided by linker for nosys
>>
>> Yes, there is a typo - it should be ARM_RDI_MONITOR
>
> Think you forgot to submit it as a git format-patch :)
>
>>
>> Thanks !
>>
>> On Tue, Aug 15, 2017 at 3:46 PM, Tamar Christina
>> <Tamar.Christina@arm.com> wrote:
>> >> > diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
>> >> > index
>> >> > 3bf0278..0c669d9 100644
>> >> > --- a/libgloss/aarch64/crt0.S
>> >> > +++ b/libgloss/aarch64/crt0.S
>> >> > @@ -83,7 +83,7 @@
>> >> > FUNC_START _start
>> >> >
>> >> > /* Start by setting up a stack */
>> >> > -
>> >> > +#ifdef ARM_RDI_MONITOR
>> >>
>> >> i think this should match
>> >>
>> >> ...
>> >> > +#ifdef ARM_RDP_MONITOR
>> >
>> > We don't define ARM_RDP_MONITOR in AArch64, so this should be
>> ARM_RDI_MONITOR.
>> >
>> >>
>> >> this.
>> >>
>> >> > .LC0:
>> >> > GEN_DWORD HeapBase
>> >
>>
>>
>>
>> --
>> Best regards,
>> AF
--
Best regards,
AF
[-- Attachment #2: aarch64_fix_typo.patch --]
[-- Type: text/x-patch, Size: 603 bytes --]
From 041c8b2d571a96c1ebecb7cba6e8afb2d96064bb Mon Sep 17 00:00:00 2001
From: Alexander Fedotov-B55613 <b55613@freescale.com>
Date: Tue, 15 Aug 2017 17:01:05 +0300
Subject: [PATCH] fix typo in AArch64 crt0
---
libgloss/aarch64/crt0.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
index 0c669d9..cc7e84d 100644
--- a/libgloss/aarch64/crt0.S
+++ b/libgloss/aarch64/crt0.S
@@ -243,7 +243,7 @@ FUNCTION (_cpu_init_hook):
ret
.align 3
-#ifdef ARM_RDP_MONITOR
+#ifdef ARM_RDI_MONITOR
.LC0:
GEN_DWORD HeapBase
#else
--
2.7.4
next prev parent reply other threads:[~2017-08-15 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 13:55 Alexander Fedotov
2017-08-14 8:21 ` Corinna Vinschen
2017-08-15 12:47 ` Szabolcs Nagy
2017-08-15 13:35 ` Tamar Christina
2017-08-15 13:57 ` Alexander Fedotov
2017-08-15 14:06 ` Tamar Christina
2017-08-15 14:20 ` Alexander Fedotov [this message]
2017-08-15 15:55 ` Corinna Vinschen
2017-08-16 22:07 ` Szabolcs Nagy
2017-08-17 11:52 ` Szabolcs Nagy
2017-08-17 11:54 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN8C2CqXh=rPWZOrTQsskmJ88TjtEW0x7ziBQi0U8E_=cg6C_g@mail.gmail.com' \
--to=alfedotov@gmail.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=nd@arm.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).