From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by sourceware.org (Postfix) with ESMTPS id 4EE4F3858C2C for ; Thu, 10 Feb 2022 18:03:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EE4F3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf2a.google.com with SMTP id d3so5810370qvb.5 for ; Thu, 10 Feb 2022 10:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=fbBZmvJhpXjaSOAIuqpQIb8OdyH5Q7cwZTPxclsVYxc=; b=WpKXiFObAAaKlvWj68hyJEQhStQsQ0OEaCasfYY/w12yBiG/lz7bl5EQG4As3PTTN3 BK4PYEglXB5vm/qxBCybYw/U2M2N8Kt4iLQcqeICtWba9qQ70wCMPNpEM+Xxg08IrDha sw49P+xThpmc98xM7UO3V10QQZOA8EkR+cp6yL8Oel3ltB9oUtoWj/m1qLLpmJ+9fQ3c jXJYo9gxofWHT2ahzUD4EiVOUbmvV1IKAhl8O4JcYV3qeSOUgsLdO9j5KiUTTBgEntJ3 mqQ6YFgr/UT0HGimgGWv8l3oHerNxkqNWOi/W7ytb7NYEn7tJ0uwW+yMXo77uznLf2Bd +LTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=fbBZmvJhpXjaSOAIuqpQIb8OdyH5Q7cwZTPxclsVYxc=; b=1Ov/uK89Bodr7rYX6mlCxaGRWfduS9g2q/8FAC2SXzLXnb+Qf4nGfCgPOr8CZ81xuU NIjDxzUED97sOjVpiiMLj+oiFdo58DmQamTe+v4n+kIUsnUgOhRjabcDLdzjFhWbq0wY LTjW3VgbggR4UvdK/M0qGOjxJa75S6lyBnAJ7draJbPuK7hn7m9RSakOtAi1qhw3HXlP YHNRP53UXxS3jKB8JauaBBC4N/KpOhsEJj8FNDQyiCecba7efwfCTKxLtfT3bZxAV3Nw CiUqqojpaGKI2LKPmn8UTTL8Pw4EgNrsyyaVg1CEPZEXTBwwsoJZK2P1eulbzLwKP45n Px+Q== X-Gm-Message-State: AOAM530c7mP/kRDBkKm2BEW2zfCbhfNfJrjey0JXyWyw197PlSnuBnVn o+hAOUbLPliNfH8bI9Ebo061CFS5w35qRzBQNiqZbIs= X-Google-Smtp-Source: ABdhPJwZFn8eV92fOA2iD9qRGqNaBZnBvY/hTczJ+f8mn1HRvvv81/OT8uN8ekZzfxTp3qjfZGVvjjb/cJ7/cIcLJDQ= X-Received: by 2002:a05:6214:d0c:: with SMTP id 12mr5913605qvh.118.1644516187792; Thu, 10 Feb 2022 10:03:07 -0800 (PST) MIME-Version: 1.0 References: <20220210055347.24825-1-vapier@gentoo.org> In-Reply-To: From: C Howland Date: Thu, 10 Feb 2022 13:02:57 -0500 Message-ID: Subject: Re: [PATCH] newlib: remove unused fenv flags To: newlib@sourceware.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 18:03:10 -0000 > > > ------------------------------ > *From:* Newlib on > behalf of Corinna Vinschen > *Sent:* Thursday, February 10, 2022 10:04 AM > *To:* newlib@sourceware.org > *Subject:* Re: [PATCH] newlib: remove unused fenv flags > > > > On Feb 10 00:53, Mike Frysinger wrote: > > These look like they were just copied & pasted from common/Makefile.am. > > The funcs in this dir are all stubs that don't actually call any math > > or builtin functions, and a simple compile shows they produce identical > > object code. So delete to simplify the build rules. > > --- > > newlib/libm/fenv/Makefile.am | 3 -- > > newlib/libm/fenv/Makefile.in | 90 +++--------------------------------- > > 2 files changed, 6 insertions(+), 87 deletions(-) > > > > diff --git a/newlib/libm/fenv/Makefile.am b/newlib/libm/fenv/Makefile.am > > index 50b59004c17e..66755e394cb7 100644 > > --- a/newlib/libm/fenv/Makefile.am > > +++ b/newlib/libm/fenv/Makefile.am > > @@ -6,11 +6,8 @@ src = feclearexcept.c fe_dfl_env.c fegetenv.c > fegetexceptflag.c \ > > fegetround.c feholdexcept.c feraiseexcept.c fesetenv.c \ > > fesetexceptflag.c fesetround.c fetestexcept.c feupdateenv.c > > > > -lib_a_CFLAGS = -fbuiltin -fno-math-errno > > - > > noinst_LIBRARIES = lib.a > > lib_a_SOURCES = $(src) > > -lib_a_CFLAGS += $(AM_CFLAGS) > > > > # A partial dependency list. > > > > -- > > 2.34.1 > > Ok. > > > Thanks, > Corinna > No, not OK, it doesn't sound like. The fenv functions are all machine-specific and the files in the libm/fenv directory are all stubs (which they clearly state internally). Unless all targets were checked (and it doesn't sound like they were), the conclusion is faulty that no difference happens. Taking away -fbuiltin would definitely break any machine source relying on it, but not the stubs. Craig