From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id E8E1D3853800 for ; Wed, 28 Jul 2021 19:54:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8E1D3853800 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x730.google.com with SMTP id 184so3494464qkh.1 for ; Wed, 28 Jul 2021 12:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=61YGKjj/drpHtK9EHt3Y6gBX46HpiEymafNPbsJYQbM=; b=n9NGUmFO0EL1zPItEUUmu14SAH8h1kNvNl/BI2nQqHgol1bzX1i8bzeku+7e7DaGoi RFNH2ogGOvlAzkiH1RKR+J/ph14bGbvUDwGJlSNKV6p12yYpHLNdbRrvKNm+HJKu51MT 1uq5cjEQmGsaILNk6/8T1+lbyK54IQpnWBT6BAWR8mFwAoTwPkC4l6DZtoa1ugha64S8 kYYJbCgRRtKPdLNwi1XlpPn1dKDvGt4vwhlAW7ODNKIYMB8ZpGEqvMiruepc9Twc5FyB 1V99te/+atLDpirq/uh4tq97hmjFLJP08YC0wt/AWCAubrn0mV7owAFD1IhHBnjhkp4B RnmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=61YGKjj/drpHtK9EHt3Y6gBX46HpiEymafNPbsJYQbM=; b=iI9Ao24vSdUUHSOgkJgnTKj92mqrq93UiaFrxfQ3N/drflNuN5d40nvsXF/05otM2+ AS7qvuWx1NU49wA/SgyhsrgGhOUW7U1HHZekDXOhKFFUXBXartqUh9Khk8jxzLtPGzJc qqEFrekdnOFzw1ShJ5Yuqo6OpJzP/fGbhLzG8PQV54QdT550B/Dkx0KCkF9GA6oAN8ZB FBqxkvRrcbjRT4YFx6eeIhieMh3rU5PcVRhpSyt3gWMpwhrzq4jGDmeWCsP+h5PTSBN6 qogQAuGhfdiUvB4SyNgrTfHFV7GEGZgfe+BC0l6/z0b4rn4/rew/rjOPpfeY7j1zDMwm kDFQ== X-Gm-Message-State: AOAM531HsitfHyeEc6FMpzSj0mslBMt4cCStDkusuRpHZUSSvlLvNkQg G5xXqMSBFh7306WCWKaSpRzke+vgzmpTEGCsviqInx60dQ== X-Google-Smtp-Source: ABdhPJyeeTlqCG6G1AZDE8nhqqcH/lr8UPiF3o8FNqWbLWNEce7lRMuEuNbDXme1Dhpr5WfAP+pdYMzQHIYinza6dNk= X-Received: by 2002:a37:a20d:: with SMTP id l13mr1367716qke.83.1627502085494; Wed, 28 Jul 2021 12:54:45 -0700 (PDT) MIME-Version: 1.0 References: <20210724083730.16959-1-mfjoyce2004@gmail.com> <20210724083730.16959-2-mfjoyce2004@gmail.com> <57f33efa-2450-ac5c-3ceb-be8beb183ca5@SystematicSw.ab.ca> In-Reply-To: From: C Howland Date: Wed, 28 Jul 2021 15:54:34 -0400 Message-ID: Subject: Re: Fw: [PATCH 1/1] libc: Added implementations and prototypes for To: newlib@sourceware.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 19:54:47 -0000 > > ------------------------------ > *From:* Newlib on > behalf of Joel Sherrill > *Sent:* Wednesday, July 28, 2021 3:42 PM > *To:* Newlib ; Brian Inglis < > Brian.Inglis@systematicsw.ab.ca> > *Subject:* Re: [PATCH 1/1] libc: Added implementations and prototypes for > > > On Wed, Jul 28, 2021 at 1:46 PM Corinna Vinschen > wrote: > > > > On Jul 28 09:25, Brian Inglis wrote: > > > On 2021-07-28 03:11, Corinna Vinschen wrote: > > > > Hi Matt, > > > > > > > > thanks for this v2. > > > > > > > > On Jul 24 10:37, Matt Joyce wrote: > > > > > Added implementations for sig2str() and str2sig() in libc/signal > in order > > > > > to improve POSIX compliance. Added function prototypes to > sys/signal.h. > > > > > Added Makefile.am entries to build the new file. > > > > > --- > > > > > [...] > > > > > +#if __GNU_VISIBLE > > > > > > > > I think this needs discussion. The sig2str/str2sig API has not been > > > > provided yet by GLibC. Using __GNU_VISIBLE in this context looks > wrong. > > > > What we need, in fact, is a __POSIX_VISIBLE guard, but here's the > > > > problem: As far as I can see, the Issue 8 draft does not yet define a > > > > version number. > > > > > > > > If anybody has better information or a good idea how to guard this > new > > > > API in the meantime, I'm all ears. > > > > > > Current values are: > > > > > > __POSIX_VISIBLE 199009 > > > __POSIX_VISIBLE 199209 > > > __POSIX_VISIBLE 199309 > > > __POSIX_VISIBLE 199506 > > > __POSIX_VISIBLE 200112 > > > __POSIX_VISIBLE 200809 > > > __POSIX_VISIBLE 201402 > > > > > > and anticipated release date is 2022 from FAQ > > > > > > https://www.opengroup.org/austin/faq.html > > > > > > Q8. Where is the schedule for draft development? > > > > > > so could use: > > > > > > __POSIX_VISIBLE >= 202202 /* FIXME when POSIX Issue 8 released */ > > > > Did you mean 202201? Sounds like a good idea in theory. But consider a > > project actually using this value and then the POSIX release defines the > > value 202207 or so. The project might stop to compile correctly. Along > > these lines, using 202212 for the interim might be the better approach. > > Then again, what if the release occurs in 2023 only? > > > > Still pretty unsure, > > Me too. I told Matthew early on that the header guard for this was going > to require discussion because I had no idea what was right. > > It would be nice to have this available on multiple platforms. Would it be > acceptable to make the header conditional on Cygwin and RTEMS for now? > Can we conditionalize the C file for just those two? > It really does not matter a whole lot. The gates are only on the function prototypes in the header file. It could just use the date of when the file is added for the time being, really. To be more gung-ho, something like #define POSIX8_RELDATE 202202 // FIXME WHEN REAL RELEASE DATE KNOWN could be added to sys/features.h, and then this file could use that. features.h will have to be edited when the new POSIX comes out, so just place it appropriately to make the need to change it obvious. Craig > > Does newlib have a ticketing/PR system? If so, we could revisit this when > Issue 8 is released. Alternatively, we can file a ticket in Cygwin and > RTEMS > and see which one of us remembers it first after Issue 8 is out. I know if > we > tag a ticket with the next release, it should get reviewed as we start > cleaning > up as the code gets slushier. > > --joel > > > Corinna > > > >