From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by sourceware.org (Postfix) with ESMTPS id 9CE7F3858D28 for ; Mon, 19 Sep 2022 15:51:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CE7F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2e.google.com with SMTP id 130so43074965ybw.8 for ; Mon, 19 Sep 2022 08:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=ygoF8zRoSzXvhrleRWiT0PNtA0nEeHQ2FeYgGRHCHH4=; b=i+wsgs9oPoCSZb+nRdYTSVQV6qo1zfhgQ7ZaY4TrFGGrclEU93b6iqo+teKzpK4mwY WVPENAigKDaoGqDN2WxAyHnqAtgH9Lg3WaHu5HOkNbiZvbOOVzgf4qNrm8O3rNN93nKT OPljE0KnGh9bazu2WaixB11PBBQkgeJOENxAZLxQvctWgghGS03TvAvydEMWwRMCs4PL dQC85mGCKgvNiu2RMLONcYOemoA9Vj+xmDlR1+NBXpu8c0dNbpUmRGYb5D3Ytbz0WYCs hvFDC1btFZacr/kQZkbI2foYPecaXwcLr/LS/CClHWwbkEDkPKXgPRMrgBw3LI8jfk/a HxUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=ygoF8zRoSzXvhrleRWiT0PNtA0nEeHQ2FeYgGRHCHH4=; b=fWrYhCS2fYWyEq1FIx2KQdISjkAJlUo0QTXz36m5ibtguBQxrhD/h+Yk3e/5sEkggx OkRgRSqcesWnCt/BkkeGEit4JbAf44KzBhoeaJxctpMloVu6RVyOAjPYXS8uiVBW/KEO CXciqLoDfqL1wiBZTGEjvmvZnbdYVPvIjD9E9UhBPo3TLwMQXcNX0EFiYwNfn1JgaKib YjmuQpONwxLubUzJ7gHBJKoWyaBZWiPJvxQgC1UiVXJP+/5Moz/9QHtnDKx1dbm82dIG GaCUxr7QkuNOE2tDmNshIAEPw3Ji731xpPxNaRRENIHOrRzTX6oGV0m3XtO818bGGzMt twvQ== X-Gm-Message-State: ACrzQf38bCL110ytm64a9zLQvqvQALYQwXnMvKYvvrw1DQupA+w2MzAw qlW7H88nLpgqKZ5eSuMs3xkwkCSs1HBh33mxg704Ew6AYA== X-Google-Smtp-Source: AMsMyM4QHSK3DURyrby3uKG2LPOCe+pTpH0DpRsFNAXWlMbg1+x2VSmFUmqHTYXgYTboTu4bTH5G4EpkQHKS8ERJIx4= X-Received: by 2002:a25:81cf:0:b0:6a9:4d0d:5ee6 with SMTP id n15-20020a2581cf000000b006a94d0d5ee6mr15522205ybm.153.1663602689802; Mon, 19 Sep 2022 08:51:29 -0700 (PDT) MIME-Version: 1.0 References: <20220917050005.5758-1-Brian.Inglis@SystematicSW.ab.ca> <20220917050005.5758-2-Brian.Inglis@SystematicSW.ab.ca> In-Reply-To: From: C Howland Date: Mon, 19 Sep 2022 11:51:18 -0400 Message-ID: Subject: Re: Fw: [PATCH 1/2] strftime.c(__strftime): add %i, %q, %v, tests; tweak %Z docs To: newlib@sourceware.org, Brian.Inglis@systematicsw.ab.ca Content-Type: multipart/alternative; boundary="0000000000005f84d105e909afb4" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000005f84d105e909afb4 Content-Type: text/plain; charset="UTF-8" > > ------------------------------ > *From:* Newlib on > behalf of Brian Inglis > *Sent:* Saturday, September 17, 2022 1:00 AM > *To:* Newlib > *Subject:* [PATCH 1/2] strftime.c(__strftime): add %i, %q, %v, tests; > tweak %Z docs > > > > newlib/libc/time/strftime.c(__strftime): > %i year in century [00..99] Synonym for "%y". Non-POSIX extension. > [tm_year] > %q GNU quarter of the year (from `<<1>>' to `<<4>>') [tm_mon] > %v OSX/Ruby VMS/Oracle date "%d-%b-%Y". Non-POSIX extension. [tm_mday, > tm_mon, tm_year] > add %i %q %v tests > %Z clarify current time zone *abbreviation* not "name" [tm_isdst] > --- > newlib/libc/time/strftime.c | 67 +++++++++++++++++++++++++++++++++++-- > 1 file changed, 64 insertions(+), 3 deletions(-) > > While the additions themselves nominally look good, all being extensions they ought to be gated by the appropriate ifdefs, and the manual would best mention what gates are needed to get them. %q would be __GNU_VISIBLE as the gate and _GNU_SOURCE for the user/manual, and I'd guess probably __MISC_VISIBLE gate for the others (user action as noted in sys/features.h). Craig --0000000000005f84d105e909afb4--