From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by sourceware.org (Postfix) with ESMTPS id D72A03858C56 for ; Tue, 21 Jun 2022 14:42:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D72A03858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x733.google.com with SMTP id n197so10256913qke.1 for ; Tue, 21 Jun 2022 07:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=U8G+Sm5eKx+ittYNb7muOlwJzyiOZEuUu9mes5QLoHU=; b=EPfBKRD0PuSn4vyHpTfgGXa4/CtF19ifi4JYohM87C5UiQ9I9qarKhLK0CL8sZzC89 rhievcG2xLwfZtZZEU+x5HXaveDQooP2ig3g82K2wYr7yru3yWoet3SQL4tfgkSi8Lxf GQb2qdfcez+z7lmjsujs9XvPRA9aNfzMlrrR0p/QusRfbpR/sNkIH9oYauHc2uIfe5DH DUpktLNa1f57obaXx5rakave56vfsHtQrRYBsy4Hjfd6MRdRBU2P6w+26ry5Z2ukZnDo 6OWa0ClJtBBxM0JKKmbDUCuXtPuG4rHT1O7Yp3dh8z9i/zPXusd+agDyko1spzHHptKa MojA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=U8G+Sm5eKx+ittYNb7muOlwJzyiOZEuUu9mes5QLoHU=; b=mjMdoeh+lssnLqMLsiCYLlJZkhhYrkVa+DTGzqiW2obMxuGsYK3GhF9VekxiDmBbi4 qSEYlhrX1Bp9Houz2tNAw3ZgyLqdlSE+Xz6u5sA4sdCzKQ/TU5Q4Sx3eFtNVdMvviNuw pGdJywOdJ1zv+GsQZL4pvl7edW/kTX255x/ENiBTThsSO9HgemWnPLo8VqkcOVZflMAy 4O4IFHMoPIrObtj+eGvf1W7l1Efq+vNMRjifMnNPVlyiO0tqTyjpb5sD53/T+68i+WaO qqo+xEVd2awZadxxfq1StvVeLwc0isRG94jcZdK+HoZex+WLZZCtuJ3AkTwU91Sudtw0 pu/g== X-Gm-Message-State: AJIora/nbiBNE4KFepg5v7KEwAgxY2sTe0fBwOccoRMXmnJPXZqDIO1N tV4DOxKkI140w5wef7EJaeUKh0G1aOOc4FXV/V4phRYaog== X-Google-Smtp-Source: AGRyM1sHGZjMZXJI7iP0ogJKK45Lfgie5qr7vRDSY20Ubf5OUzmF4oJTay3Pfr3rXwcGaWgOVqJ8kxb0437IAI/SxEE= X-Received: by 2002:a05:620a:4590:b0:6a7:2543:2938 with SMTP id bp16-20020a05620a459000b006a725432938mr19899647qkb.590.1655822520106; Tue, 21 Jun 2022 07:42:00 -0700 (PDT) MIME-Version: 1.0 References: <20220621124931.36450-1-sebastian.huber@embedded-brains.de> <20220621124931.36450-4-sebastian.huber@embedded-brains.de> In-Reply-To: From: C Howland Date: Tue, 21 Jun 2022 10:41:49 -0400 Message-ID: Subject: Re: Fw: [PATCH 03/14] Add _REENT_ERRNO(ptr) To: newlib@sourceware.org X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 14:42:02 -0000 > > > ------------------------------ > *From:* Newlib on > behalf of Sebastian Huber > *Sent:* Tuesday, June 21, 2022 8:49 AM > *To:* newlib@sourceware.org > *Subject:* [PATCH 03/14] Add _REENT_ERRNO(ptr) > > > > From: Matt Joyce > > Add a _REENT_ERRNO() macro to encapsulate the access to the > _errno member of struct reent. This will help to replace the > structure member with a thread-local storage object in a follow > up patch. > --- > There already exists an __errno_r() macro that does the very same function (defined in sys/errno.h). (Its use, however, is limited, only being used in files under iconv/lib.) Having the same thing done both ways probably doesn't make sense. The new name is more consistent with the rest of the things being done, while the old name is established and errno is a more specialized case. It probably would be a good idea to either 1) use __errno_r() instead of creating _REENT_ERRNO() or 2) replace __errno_r() with _REENT_ERRNO() as part of adding the latter. Craig